New config key for files metadata

[mmattel]

WHAT Needs to be Documented?

owncloud/core#39126 (Feature/version metadata)
'file_storage.save_version_author' => true

WHERE Does This Need To Be Documented (Link)?

config-to-docs run and in user_manual/pages/files/version_control.adoc

WHY Should This Change Be Made?

Completeness of docs

(Optional) What Type Of Content Change Is This?

• New Content Addition
• Old Content Deprecation
• Existing Content Simplification
• Bug Fix to Existing Content

(Optional) Which Manual Does This Relate To?

• Admin Manual
• Developer Manual
• User Manual
• Android
• iOS
• Branded Clients
• Desktop Client
• Other

@janackermann

[mmattel]

After some testing to create screenshots:

user1 creates testfile.txt - no versions shown
admin changes testfile.txt - version admin
user1 - sees no versions shown
user1 changes testfile.txt - version user (with a timestamp 3 minuten ago)
admin - sees version admin

@janackermann @jnweiger any tip for my understanding

[phil-davis]

The behavior in release-10.9.0 is currently wrong. PR owncloud/core#39516 is currently WIP to get the correct behavior.

The required behavior is in this scenario:
https://github.com/owncloud/core/blob/dcb4287896a9c15641958ab39acf6872698f89f7/tests/acceptance/features/apiVersions/fileVersions.feature#L474

I am not sure that the doc screenshots... can be done until we have code that behaves as specified.

[mmattel]

I am not sure that the doc screenshots... can be done until we have code that behaves as specified.

Correct, as long that is not fixed, I will not continue on how to implement this in docs. Thanks for linking this to the followup core PR. Just wanted to do the same.

@IljaN added you to the docs loop

[jnweiger]

Tested that feature in 10.9.0 beta1 -- seems to work correctly for me.

• The unusual use of 'author' might need clarification. One could expect that the author is the original creator of the document, and later editors are called contributor or similar.
  In this context, everybody is called an 'author'. They 'author' a new version, even if they just delete a line.

• trashbin delete / restore behaviour might change due to Versions author info is lost after delete and restore by share receiver core#39571

[phil-davis]

"The unusual use of 'author' might need clarification."

The tricky part with the words is that, I guess, the oldest version (the one that first existed) has an "author" and then each version after that has a person who changed the file. They may not have even "edited" it. If it is a file that some local application "changed for them" then they won't have "opened the file in Word or Excel or Powerpoint or an image/video app and edited it". The file will have changed and been synced up to the cloud storage without them really being aware they the are somehow the "author" or "editor".

When the file has been upload and then changed 3 times there is:

• oldest version (3rd version) has an "author"
• 2nd oldest version has a "changer"
• most recent version in the version history has a "changer"
• the current file has a "changer" (what do we even call the current file - for me it is "the latest version of the file", but that might create confusion because there is also "the most recent version in the version history" - some people might look at the version history and say that " the most recent version in the version history" is what they would describe as " the latest version of the file".

Words are hard!