Skip to content

Commit be3382f

Browse files
authored
Merge pull request #34 from oumoussa98/fix/remove-event-listener
fix: fixed remove event listener TypeError
2 parents 9c9a268 + 4bb52f4 commit be3382f

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "v3-infinite-loading",
3-
"version": "1.1.3",
3+
"version": "1.1.4",
44
"description": "Infinite scroller component for vuejs-3",
55
"homepage": "https://vue3-infinite-loading.netlify.app/",
66
"repository": {

src/components/InfiniteLoading.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ onMounted(() => {
6868
});
6969
7070
onUnmounted(() => {
71-
removeScrollEvent(params.parentEl);
71+
removeScrollEvent(params);
7272
});
7373
</script>
7474

src/utils.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,8 @@ const startScrollEvent = params => {
6666
};
6767

6868
// remove scroll event
69-
const removeScrollEvent = parentEl => {
69+
const removeScrollEvent = params => {
70+
const parentEl = getParent(params.target);
7071
parentEl.removeEventListener("scroll", eventHandler);
7172
};
7273

0 commit comments

Comments
 (0)