`osm2pgsql --user`, but `osm2pgsql-replication --username`

[knowname]

I am running osm2pgsql version 2.1.1 and noticed that the command line options for osm2pgsql and osm2pgsql-replication are differing regarding the database user.

/# osm2pgsql -h | grep -i username
  -U,--user USERNAME

# osm2pgsql-replication update -h | grep -i username
  -U, --username NAME   PostgreSQL user name

What version of osm2pgsql are you using?

osm2pgsql --version
osm2pgsql version 2.1.1 (2.1.1)
Build: RelWithDebInfo
Compiled using the following library versions:
Libosmium 2.22.0
Proj 9.6.0
Lua 5.1.4 (LuaJIT 2.1.1723681758)

What operating system and PostgreSQL/PostGIS version are you using?

Alpine / Postgres 17 / PostGIS 3.5

What did you expect to happen?

I´d expect consistent naming. Obviously a minor flaw.

[joto]

Good point. The psql command uses --username, we should be consistent with that. That's why osm2pgsql-replication uses that despite the older osm2pgsql using --user.

[lonvia]

Not ideal, true. Note however that due to the way how command-line parsing in Python works, --user <user> happens to work as well in osm2pgsql-replication. So copying the commandline parameters from osm2pgsql to osm2pgsql-replication will just work. That's why I'm inclinded to just leave it as is.

Closing as not-planned-to-be-fixed.

[lonvia]

On further investigation, we seem to be really confused about this parameter throughout the code and documentation. Reopening.

[knowname]

Thanks!

Good point. The psql command uses --username, we should be consistent with that. That's why osm2pgsql-replication uses that despite the older osm2pgsql using --user.

If you are looking for proximity to psql CLI flags you could also consider adding the --dbname (psql) to the existing --database (osm2pgsql/osm2pgsql-replication update).

[lonvia]

Fixed in #2343.