Fixed bug creating a homogeneous connection pool with a proxy user

(#101).

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -7,6 +7,16 @@ python-oracledb Release Notes
 
 For deprecations, see :ref:`Deprecations <deprecations>`.
 
+oracledb 1.2.1 (TBD)
+--------------------
+
+Thick Mode Changes
+++++++++++++++++++
+
+#)  Fixed bug creating a homogeneous connection pool with a proxy user
+    (`issue 101 <https://github.com/oracle/python-oracledb/issues/101>`__).
+
+
 oracledb 1.2.0 (November 2022)
 ------------------------------
 

src/oracledb/impl/thick/pool.pyx

@@ -126,7 +126,7 @@ cdef class ThickPoolImpl(BasePoolImpl):
 
         # prepare user, password and DSN for use
         if self.username is not None:
-            user_bytes = self.username.encode()
+            user_bytes = params.get_full_user().encode()
             user_ptr = user_bytes
             user_len = <uint32_t> len(user_bytes)
         password_bytes = params._get_password()

src/oracledb/version.py

@@ -30,4 +30,4 @@
 # file doc/src/conf.py both reference this file directly.
 #------------------------------------------------------------------------------
 
-__version__ = "1.2.0"
+__version__ = "1.2.1"

tests/test_2400_pool.py

@@ -717,5 +717,13 @@ def test_2430_get_different_types_from_pooled_connections(self):
             typ = conn.gettype("UDT_OBJECTARRAY")
             self.assertEqual(typ.name, "UDT_OBJECTARRAY")
 
+    def test_2431_proxy_user_in_create(self):
+        "2431 - test creating a pool using a proxy user"
+        user_str = "%s[%s]" % \
+                (test_env.get_main_user(), test_env.get_proxy_user())
+        pool = test_env.get_pool(user=user_str)
+        self.__verify_connection(pool.acquire(), test_env.get_proxy_user(),
+                                 test_env.get_main_user())
+
 if __name__ == "__main__":
     test_env.run_test_cases()