Fixed bug that caused "Connection.is_healthy()" to return "True" after a

connection has been killed.

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -15,6 +15,8 @@ Thin Mode Changes
 
 #)  Fixed bug that prevented binding data of types
     :data:`~oracledb.DB_TYPE_ROWID` and :data:`~oracledb.DB_TYPE_UROWID`.
+#)  Fixed bug that caused :meth:`Connection.is_healthy()` to return `True`
+    after a connection has been killed.
 #)  Internally, before a connection is returned from a pool, perform additional
     checks in order to avoid returning a dead connection from the pool.
 

src/oracledb/connection.py

@@ -503,7 +503,7 @@ def is_healthy(self) -> bool:
         This function performs a local check. To fully check a connection's
         health, use ping() which performs a round-trip to the database.
         """
-        return self._impl.get_is_healthy()
+        return self._impl is not None and self._impl.get_is_healthy()
 
     @property
     def ltxid(self) -> bytes:

src/oracledb/impl/thin/connection.pyx

@@ -325,7 +325,8 @@ cdef class ThinConnImpl(BaseConnImpl):
         return self._internal_name
 
     def get_is_healthy(self):
-        return not self._protocol._read_buf._session_needs_to_be_closed
+        return self._protocol._socket is not None \
+                and not self._protocol._read_buf._session_needs_to_be_closed
 
     def get_ltxid(self):
         return self._ltxid or b''

tests/test_4300_cursor_other.py

@@ -739,6 +739,7 @@ def test_4358_kill_conn_with_open_cursor(self):
             admin_cursor.execute(sql)
         self.assertRaisesRegex(oracledb.DatabaseError, "^DPY-4011:",
                                cursor.execute, "select user from dual")
+        self.assertFalse(conn.is_healthy())
 
     def test_4359_kill_conn_in_context_manager(self):
         "4359 - kill connection in cursor context manager"

utils/templates/connection.py

@@ -501,7 +501,7 @@ def is_healthy(self) -> bool:
         This function performs a local check. To fully check a connection's
         health, use ping() which performs a round-trip to the database.
         """
-        return self._impl.get_is_healthy()
+        return self._impl is not None and self._impl.get_is_healthy()
 
     @property
     def ltxid(self) -> bytes: