Fixed bug when executing PL/SQL with a large number of binds.

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -20,6 +20,7 @@ Thin Mode Changes
 #)  Fixed bugs in the implementation of the statement cache.
 #)  Fixed bug which could cause a redirect loop with improperly configured
     listener redirects.
+#)  Fixed bug when executing PL/SQL with a large number of binds.
 #)  Eliminated unneeded round trip when using token authentication to connect
     to the database.
 

src/oracledb/impl/thin/messages.pyx

@@ -787,13 +787,15 @@ cdef class MessageWithData(Message):
         It indicates whether binds are IN only, IN/OUT or OUT only.
         """
         cdef:
-            uint16_t i, num_binds, num_bytes, temp16
+            uint16_t i, num_bytes, temp16
+            uint32_t temp32, num_binds
             BindInfo bind_info
         buf.skip_ub1()                      # flag
-        buf.read_ub2(&num_binds)            # num requests
-        buf.read_ub4(&self.row_index)       # iter num
+        buf.read_ub2(&temp16)               # num requests
+        buf.read_ub4(&temp32)               # num iters
+        num_binds = temp32 * 256 + temp16
         buf.skip_ub4()                      # num iters this time
-        buf.read_ub2(&temp16)               # uac buffer length
+        buf.skip_ub2()                      # uac buffer length
         buf.read_ub2(&num_bytes)            # bit vector for fast fetch
         if num_bytes > 0:
             buf.skip_raw_bytes(num_bytes)

tests/test_4000_cursor_executemany.py

@@ -1,5 +1,5 @@
 #------------------------------------------------------------------------------
-# Copyright (c) 2020, 2022, Oracle and/or its affiliates.
+# Copyright (c) 2020, 2023, Oracle and/or its affiliates.
 #
 # This software is dual-licensed to you under the Universal Permissive License
 # (UPL) 1.0 as shown at https://oss.oracle.com/licenses/upl and Apache License
@@ -310,5 +310,32 @@ def test_4021_defer_type_assignment(self):
         fetched_data = self.cursor.fetchall()
         self.assertEqual(data, fetched_data)
 
+    def test_4022_plsql_large_number_of_binds(self):
+        "4022 - test PL/SQL with a lerge number of binds"
+        parts = []
+        bind_names = []
+        all_bind_values = []
+        out_binds = []
+        for i in range(5):
+            all_bind_values.append([])
+        for i in range(350):
+            n = len(parts) + 1
+            bind_names.extend([f"v_out_{n}_0", f"a_{n}", f"b_{n}", f"c_{n}"])
+            parts.append(f":v_out{n} := :a_{n} + :b_{n} + :c_{n};")
+            out_binds.append(self.cursor.var(int,
+                                             arraysize=len(all_bind_values)))
+            for j, bind_values in enumerate(all_bind_values):
+                bind_values.extend([out_binds[-1], n * 1 + j, n * 2 + j,
+                                    n * 3 + j])
+        lf = "\n"
+        sql = f"begin{lf}{lf.join(parts)}{lf}end;"
+        self.cursor.executemany(sql, all_bind_values)
+        init_val = 6
+        for var in out_binds:
+            expected = [init_val, init_val + 3, init_val + 6, init_val + 9,
+                        init_val + 12]
+            self.assertEqual(var.values, expected)
+            init_val += 6
+
 if __name__ == "__main__":
     test_env.run_test_cases()