Fixed Memory leak while running PL/SQL function returning Objects in a loop (Issue #1711)

Author: sharadraju

doc/src/release_notes.rst

@@ -14,7 +14,7 @@ node-oracledb `v6.7.1 <https://github.com/oracle/node-oracledb/compare/v6.7.0...
 Common Changes
 ++++++++++++++
 
-#)  Fixed the issue causing segmentation fault while getting connection from 
+#)  Fixed the issue causing segmentation fault while getting connection from
     pool for external authentication.
 
 #)  Fixed SyntaxError with Bun runtime.
@@ -50,6 +50,12 @@ Thin Mode Changes
 #)  Fixed bug with associative arrays indexed by integers that caused the
     :meth:`dbObject.getPrevIndex()` method to change the array order.
 
+Thick Mode changes
+++++++++++++++++++
+
+#)  Fixed Memory leak while running PL/SQL function returning Objects in a loop.
+    See `Issue #1711 <https://github.com/oracle/node-oracledb/issues/1711>`__.
+
 node-oracledb `v6.7.0 <https://github.com/oracle/node-oracledb/compare/v6.6.0...v6.7.0>`__ (18 Nov 2024)
 ---------------------------------------------------------------------------------------------------------
 

lib/connection.js

@@ -748,6 +748,11 @@ class Connection extends EventEmitter {
     }
 
     delete this._impl;
+    if (!this.thin) {
+      for (const cls of this._dbObjectClasses.values()) {
+        cls._objType.refCleanup();
+      }
+    }
     this._dbObjectClasses.clear();
     this.emit('_afterConnClose');
   }

src/njsDbObject.c

@@ -110,6 +110,8 @@ static bool njsDbObjectType_populateTypeInfo(njsDataTypeInfo *info,
         njsBaton *baton, napi_env env, dpiDataTypeInfo *sourceInfo);
 static bool njsDbObject_wrap(napi_env env, napi_value value,
         njsDbObject **obj);
+static napi_value njsDbObjectType_refCleanup(napi_env env,
+        napi_callback_info info);
 
 
 //-----------------------------------------------------------------------------
@@ -188,6 +190,7 @@ static void njsDbObject_finalize(napi_env env, void *finalizeData,
         dpiObject_release(obj->handle);
         obj->handle = NULL;
     }
+    obj->type = NULL;
     free(obj);
 }
 
@@ -877,6 +880,21 @@ static void njsDbObjectType_finalize(napi_env env, void *finalizeData,
     free(type);
 }
 
+//-----------------------------------------------------------------------------
+// njsDbObjectType_refCleanup()
+//   Invoked when njsDbObjectType reference count needs to be decremented.
+//   This is required for the clean up of obj type reference created
+//   in njsDbObjectType_populate.
+//-----------------------------------------------------------------------------
+static napi_value njsDbObjectType_refCleanup(napi_env env,
+        napi_callback_info info)
+{
+    njsDbObjectType *type;
+
+    napi_get_cb_info(env, info, NULL, NULL, NULL, (void**) &type);
+    NJS_DELETE_REF_AND_CLEAR(type->jsDbObjectType);
+    return NULL;
+}
 
 //-----------------------------------------------------------------------------
 // njsDbObjectType_populate()
@@ -995,6 +1013,11 @@ static bool njsDbObjectType_populate(njsDbObjectType *objType,
     NJS_CHECK_NAPI(env, napi_set_named_property(env, jsObjectType,
             "isCollection", temp))
 
+    // cleanup function
+    NJS_CHECK_NAPI(env, napi_create_function(env, "refCleanup", NAPI_AUTO_LENGTH,
+            njsDbObjectType_refCleanup, objType, &temp))
+    NJS_CHECK_NAPI(env, napi_set_named_property(env, jsObjectType, "refCleanup",
+             temp))
     return true;
 }