Incorporate review comments (#84)

* Incorporate review comments
* Add 24.03
* Update README
* Update image
* Correct target version to 1.8

Author: Tim Middleton

.github/workflows/test-against-released.yml

@@ -45,9 +45,9 @@ jobs:
           - 14.1.1-0-16
           - 22.06.7
           - 22.06.6
-          - 23.09
           - 23.09.1
           - 23.09.2
+          - 24.03
 
     steps:
     - name: Checkout

README.md

@@ -33,9 +33,9 @@ NOTE: The most current version of the Plugin requires VisualVM release 2.1 or la
 
 The Plugin will connect to and display data for the following Coherence versions:
 
-* **Community Editions**: 24.03.x, 23.09.x, 22.06.x, 21.12.x (*), 14.1.1.0.x
+* **Community Editions**: 24.03.x, 23.09.x, 22.06.x, 14.1.1.0.x
 
-* **Commercial Editions**: 14.1.1.2206.x, 14.1.1.0.x, 12.2.1.5.x, 12.2.1.4.x 12.1.3.x and 12.1.2.x
+* **Commercial Editions**: 14.1.1.2206.x, 14.1.1.0.x and 12.2.1.4.x
 
 >Note: If you wish to connect to Coherence version 12.2.1.4.x via REST you should have Coherence version 12.2.1.4.7 or greater.
 
@@ -195,18 +195,37 @@ Depending upon the edition and functionality you are using, the following option
 
 ## <a id="tracer"></a> Using Coherence with the Tracer framework
 
-Version 1.7.0 of the Coherence VisualVM Plugin introduces initial integration with the VisualVM Tracer framework.
+Version 1.7.0 of the Coherence VisualVM Plugin introduces initial integration with the 
+VisualVM Tracer framework.
 
-From the VisualVM website 
+From the VisualVM website:
 
 > The VisualVM Tracer framework provides detailed monitoring and analyzing Java applications. Using various probes, 
 > the Tracer gathers metrics from an application and displays the data in a timeline. The data are 
 > displayed both graphically and in a table and can be exported to common formats for further processing 
 > by external tools.
 
-When you connect to a cluster via JMX, you will see the `Tracer` tab as shown below:
+After installation, when you connect to a cluster via JMX, you will see the `Tracer` tab as shown below:
 
-TBC. 
+![Tracer Tab](assets/visualvm-tracer.png)
+
+There are a number of expandable groups allowing you to choose Coherence related probes to display on the timeline including:
+
+* Coherence Cluster Overview - shows general cluster data such as members, heap, package publisher/receive rates and load averages
+* Coherence Services - Overall - shows overall service partition data
+* Coherence Services - Selected - shows data for the selected service only
+* Coherence Caches - Overall - shows overall cache data such as total cache sizes and memory usage
+* Coherence Caches - Selected - shows data for the selected cache only
+* Coherence Proxy Servers - shows proxy connection details and outgoing backlogs
+* Coherence Persistence - shows active and backup persistence data as well as maximum latency
+* Coherence Federation - shows send and receive rates
+* Coherence Elastic Data - shows elastic data flash a ram journal usage
+
+To start recording tracer data, select the tracer probes that you wish to display and click `Start`.
+
+> Note: The data displayed is the same as is display on the various Coherence tabs.
+ 
+![Tracer Tab](assets/visualvm-tracer-timeline.png)
 
 ## <a id="build"></a> Building the Plugin
 

assets/visualvm-tracer-timeline.png

@@ -169,10 +169,6 @@
           <source>${java.version}</source>
           <target>${java.version}</target>
           <release>${java.version.release}</release>
-          <compilerArgs>
-            <arg>--add-opens</arg>
-            <arg>jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED</arg>
-          </compilerArgs>
         </configuration>
       </plugin>
 

assets/visualvm-tracer.png

@@ -27,12 +27,17 @@
 
 import com.oracle.coherence.plugin.visualvm.Localization;
 import com.oracle.coherence.plugin.visualvm.VisualVMModel;
+
 import com.oracle.coherence.plugin.visualvm.tablemodel.model.CacheData;
+
 import com.oracle.coherence.plugin.visualvm.tracer.AbstractCoherenceMonitorProbe;
+
 import org.graalvm.visualvm.modules.tracer.ItemValueFormatter;
 import org.graalvm.visualvm.modules.tracer.ProbeItemDescriptor;
 import org.graalvm.visualvm.modules.tracer.TracerProbeDescriptor;
 
+import static com.oracle.coherence.plugin.visualvm.helper.GraphHelper.MB;
+
 /**
  * Tracer probe to return the total memory size of all caches across all services.
  *
@@ -68,7 +73,7 @@ private static ProbeItemDescriptor[] createItemDescriptors()
             {
             ProbeItemDescriptor.continuousLineFillItem(Localization.getLocalText(LBL),
                     getMonitorsString(LBL), ItemValueFormatter.DEFAULT_BYTES,
-                    1d, 0, 1),
+                    1d, 0, MB),
             };
         }
 

coherence-visualvm-plugin/pom.xml

@@ -25,7 +25,6 @@
 
 package com.oracle.coherence.plugin.visualvm.tracer.cache;
 
-import com.oracle.coherence.plugin.visualvm.Localization;
 import com.oracle.coherence.plugin.visualvm.VisualVMModel;
 
 import com.oracle.coherence.plugin.visualvm.tablemodel.model.CacheData;
@@ -36,6 +35,8 @@
 import org.graalvm.visualvm.modules.tracer.ProbeItemDescriptor;
 import org.graalvm.visualvm.modules.tracer.TracerProbeDescriptor;
 
+import static com.oracle.coherence.plugin.visualvm.Localization.getLocalText;
+
 /**
  * Tracer probe to return the total number of cache entries across all services.
  *
@@ -61,17 +62,17 @@ public long[] getValues(VisualVMModel model)
 
     public static TracerProbeDescriptor createDescriptor(boolean available)
         {
-        return new TracerProbeDescriptor(Localization.getLocalText(LBL),
-                Localization.getLocalText("LBL_cache_size_desc"), ICON, 10, available);
+        return new TracerProbeDescriptor(getLocalText(LBL),
+                getLocalText("LBL_cache_size_desc"), ICON, 10, available);
         }
 
     private static ProbeItemDescriptor[] createItemDescriptors()
         {
         return new ProbeItemDescriptor[]
             {
-            ProbeItemDescriptor.continuousLineFillItem(Localization.getLocalText(LBL),
+            ProbeItemDescriptor.continuousLineFillItem(getLocalText("LBL_all_caches") + " - " + getLocalText(LBL),
                     getMonitorsString(LBL), ItemValueFormatter.DEFAULT_DECIMAL,
-                    1d, 0, 1),
+                    1d, 0, 0),
             };
         }
 

coherence-visualvm-plugin/src/main/java/com/oracle/coherence/plugin/visualvm/tracer/cache/CacheMemorySizeProbe.java

@@ -74,10 +74,10 @@ private static ProbeItemDescriptor[] createItemDescriptors()
             {
             ProbeItemDescriptor.continuousLineFillItem(Localization.getLocalText(LBL1),
                     getMonitorsString(LBL1), ItemValueFormatter.DEFAULT_DECIMAL,
-                    1d, 0, 1),
+                    1d, 0, 0),
             ProbeItemDescriptor.continuousLineFillItem(Localization.getLocalText(LBL2),
                     getMonitorsString(LBL2), ItemValueFormatter.DEFAULT_DECIMAL,
-                    1d, 0, 1),
+                    1d, 0, 0),
             };
         }
 

coherence-visualvm-plugin/src/main/java/com/oracle/coherence/plugin/visualvm/tracer/cache/CacheSizeProbe.java

@@ -75,10 +75,10 @@ private static ProbeItemDescriptor[] createItemDescriptors()
             {
             ProbeItemDescriptor.continuousLineFillItem(Localization.getLocalText(LBL1),
                     getMonitorsString(LBL1), ItemValueFormatter.DEFAULT_BYTES,
-                    1d, 0, 1),
+                    1d, 0, 0),
             ProbeItemDescriptor.continuousLineFillItem(Localization.getLocalText(LBL2),
                     getMonitorsString(LBL2), ItemValueFormatter.DEFAULT_BYTES,
-                    1d, 0, 1),
+                    1d, 0, 0),
             };
         }
 

coherence-visualvm-plugin/src/main/java/com/oracle/coherence/plugin/visualvm/tracer/cache/SelectedCacheListenersProbe.java

@@ -73,13 +73,13 @@ private static ProbeItemDescriptor[] createItemDescriptors()
             {
             ProbeItemDescriptor.continuousLineFillItem(Localization.getLocalText(LBL),
                     getMonitorsString(LBL), new CustomFormatter(1000, "ms"),
-                    1000d, 0, 1),
+                    1000d, 0, 0),
             ProbeItemDescriptor.continuousLineFillItem(Localization.getLocalText(LBL2),
                     getMonitorsString(LBL2), new CustomFormatter(1000, "ms"),
-                    1000d, 0, 1),
+                    1000d, 0, 0),
             ProbeItemDescriptor.continuousLineFillItem(Localization.getLocalText(LBL3),
                     getMonitorsString(LBL3), new CustomFormatter(1000, "ms"),
-                    1000d, 0, 1),
+                    1000d, 0, 0),
             };
         }