Minor

Author: Tim Middleton

coherence-visualvm-plugin/src/main/java/com/oracle/coherence/plugin/visualvm/VisualVMModel.java

@@ -406,8 +406,8 @@ public List<Entry<Object, Data>> getData(RequestSender requestSender, Class claz
                     {
                     // we received an error running the report, so mark as
                     // a fall back so it will be immediately run
-                    LOGGER.warning(Localization.getLocalText("ERR_Failed_to_run_report", new String[] { clazz.toString(), e.toString() }));
-                    e.printStackTrace();
+                    LOGGER.warning(Localization.getLocalText("ERR_Failed_to_run_report", clazz.toString(), e.toString()));
+                    e.printStackTrace(); 
                     fFallBack = true;
                     }
                 }

coherence-visualvm-plugin/src/main/java/com/oracle/coherence/plugin/visualvm/impl/CoherenceClusterConfigurator.java

@@ -98,6 +98,14 @@ public static CoherenceClusterConfigurator defineApplication()
         return hc;
         }
 
+    /**
+     * Checks to see if the URL is valid.
+     *
+     * @param sClusterName cluster name
+     * @param sUrl         uRL
+     *
+     * @return true if the URL is valid
+     */
     private static boolean isValid(String sClusterName, String sUrl)
         {
         if (sClusterName == null || sClusterName.equals(""))

coherence-visualvm-plugin/src/main/java/com/oracle/coherence/plugin/visualvm/tablemodel/model/AbstractData.java

@@ -146,7 +146,7 @@ public SortedMap<Object, Data> getAggregatedDataUsingReport(VisualVMModel model,
 
         JMXRequestSender jmxRequestSender = (JMXRequestSender) requestSender;
         // carry out any parameter substitution or pre-processing of reporter XML
-        sReportXML = preProcessReporterXML(model, new StringBuffer(sReportXML).toString());
+        sReportXML = preProcessReporterXML(model, sReportXML);
 
 
         if (m_sReporterLocation == null)
@@ -173,8 +173,8 @@ public SortedMap<Object, Data> getAggregatedDataUsingReport(VisualVMModel model,
                 }
             catch (Exception e)
                 {
-                String sError =
-                        Localization.getLocalText("ERR_error_running_report", new String[]{sReportXML, this.getClass().getCanonicalName(), e.getMessage()});
+                String sError = Localization.getLocalText("ERR_error_running_report",
+                        sReportXML, this.getClass().getCanonicalName(), e.getMessage());
 
                 LOGGER.log(Level.WARNING, sError);
                 e.printStackTrace();
@@ -183,7 +183,7 @@ public SortedMap<Object, Data> getAggregatedDataUsingReport(VisualVMModel model,
 
                 // this exception is thrown so we can catch above and re-run the report
                 // using the standard way
-                throw new RuntimeException("Error running report");
+                throw new RuntimeException("Error running report", e);
                 }
             }
         return mapCollectedData;

coherence-visualvm-plugin/src/main/java/com/oracle/coherence/plugin/visualvm/tablemodel/model/ServiceData.java

@@ -231,7 +231,7 @@ public Data processReporterData(Object[] aoColumns, VisualVMModel model)
     @Override
     protected void preProcessReporterData(VisualVMModel model)
         {
-        setDistributedCaches = new HashSet<String>();
+        setDistributedCaches = new HashSet<>();
         }
 
     /**

coherence-visualvm-plugin/src/main/resources/com/oracle/coherence/plugin/visualvm/Bundle.properties

@@ -512,8 +512,8 @@ LBL_Coherence_Cluster=Name
 DESCR_CoherenceClusterProperties=Properties
 LBL_CoherenceClusterProperties=Properties
 ERR_Invalid_Cluster_Name=The provided cluster name is not valid.
-ERR_Invalid_URL=The provided Management URL is not valid or cannot connect to the URL "{0}".\nThe URL must be in the format of http://host:management-port/management/coherence/cluster or \
-  http://<admin-host>:<admin-port>/management/coherence/<version>/clusters for Managed Coherence Servers.  \nNote: The version number should be full 5 digits such as 12.2.1.4.0 or can also be the string "latest".
+ERR_Invalid_URL=The provided Management URL is not valid or cannot connect to the URL "{0}".\nThe URL must be in the format of\nhttp://<host>:<management-port>/management/coherence/cluster \nOR \n\
+ http://<admin-host>:<admin-port>/management/coherence/<version>/clusters for Managed Coherence Servers.  \nNote: The version number should be full 5 digits such as 12.2.1.4.0 or can also be the string "latest".
 ERR_Failed_to_run_report=The report {0} failed to run with exception {1}. Falling back from reporter.
 
 # Options