Skip to content

Commit 0a28169

Browse files
author
Tim Middleton
committed
Minor
1 parent 33be27c commit 0a28169

File tree

3 files changed

+40
-4
lines changed

3 files changed

+40
-4
lines changed

coherence-visualvm-plugin/src/main/java/com/oracle/coherence/plugin/visualvm/helper/GraphHelper.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,7 @@ public class GraphHelper
5151
*/
5252
public static SimpleXYChartSupport createClusterMemoryGraph()
5353
{
54-
SimpleXYChartDescriptor sxycd = SimpleXYChartDescriptor.bytes(0, true,
55-
VALUES_LIMIT);
54+
SimpleXYChartDescriptor sxycd = SimpleXYChartDescriptor.bytes(0, true, VALUES_LIMIT);
5655

5756
sxycd.setChartTitle(getLocalText("GRPH_cluster_memory_details"));
5857
sxycd.addLineFillItems(getLocalText("GRPH_total_cluster_memory"), getLocalText("GRPH_used_cluster_memory"));

coherence-visualvm-plugin/src/main/java/com/oracle/coherence/plugin/visualvm/helper/HttpRequestSender.java

Lines changed: 39 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1469,25 +1469,57 @@ private String encodeServiceName(String sServiceName)
14691469
return sServiceName.replaceAll("\"", "");
14701470
}
14711471

1472+
/**
1473+
* Internal class to build a URL.
1474+
*/
14721475
public static class URLBuilder
14731476
{
1477+
// ----- constructors ----------------------------------------------
1478+
1479+
/**
1480+
* Construct a {@link URLBuilder}.
1481+
*
1482+
* @param sBasePath base path
1483+
*/
14741484
public URLBuilder(String sBasePath)
14751485
{
14761486
m_bldrUrl.append(sBasePath);
14771487
}
14781488

1489+
/**
1490+
* Add a path segment.
1491+
*
1492+
* @param sPath path to add
1493+
*
1494+
* @return a {@link URLBuilder}
1495+
*/
14791496
public URLBuilder addPathSegment(String sPath)
14801497
{
14811498
m_bldrUrl.append("/").append(sPath);
14821499
return this;
14831500
}
14841501

1502+
/**
1503+
* Add a query parameter.
1504+
*
1505+
* @param sKey key
1506+
* @param sValue value
1507+
*
1508+
* @return a {@link URLBuilder}
1509+
*/
14851510
public URLBuilder addQueryParameter(String sKey, String sValue)
14861511
{
14871512
m_mapQueryParams.put(sKey, sValue);
14881513
return this;
14891514
}
14901515

1516+
/**
1517+
* Returns the {@link URL}.
1518+
*
1519+
* @return {@link URL}
1520+
*
1521+
* @throws Exception if any errors
1522+
*/
14911523
public URL getUrl() throws Exception
14921524
{
14931525
StringBuilder completeUrl = new StringBuilder(m_bldrUrl);
@@ -1502,9 +1534,15 @@ public URL getUrl() throws Exception
15021534
return new URL(completeUrl.toString());
15031535
}
15041536

1537+
/**
1538+
* {@link StringBuilder} to build the url.
1539+
*/
15051540
private final StringBuilder m_bldrUrl = new StringBuilder();
15061541

1507-
private Map<String, String> m_mapQueryParams = new HashMap<>();
1542+
/**
1543+
* {@link Map} of query parameters.
1544+
*/
1545+
private final Map<String, String> m_mapQueryParams = new HashMap<>();
15081546
}
15091547

15101548
// ----- data members ---------------------------------------------------

coherence-visualvm-plugin/src/main/java/com/oracle/coherence/plugin/visualvm/helper/JMXUtils.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
import javax.management.MBeanServerConnection;
3434
import javax.management.ObjectName;
3535

36-
import javax.management.openmbean.CompositeData;
3736

3837
/**
3938
* Utility class for querying JMX.

0 commit comments

Comments
 (0)