Upgrade golangci-lint version and configured nilaway (#441)

* updated golangci-lint version and integrated nilaway

* added staticcheck linter and increased managed oke version to 1.31.10 for e2e testing

Author: dranicu

.custom-gcl.yml

@@ -0,0 +1,6 @@
+version: v2.4.0
+plugins:
+  - module: "go.uber.org/nilaway"
+    import: "go.uber.org/nilaway/cmd/gclplugin"
+    version: latest
+

.golangci.yml

@@ -0,0 +1,23 @@
+# .golangci.yml
+version: "2"
+linters:
+  default: none
+  enable:
+    - unused
+    - govet
+    - nilnil
+    - staticcheck
+    - nilnesserr
+    - nilerr
+    - nilaway
+  settings:
+    custom:
+      nilaway:
+        type: module
+        description: "Static analysis tool to detect potential nil panics in Go code."
+        settings:
+          include-pkgs: "github.com/oracle/cluster-api-provider-oci/" 
+
+issues:
+  max-issues-per-linter: 500
+  max-same-issues: 100

Makefile

@@ -72,6 +72,9 @@ KUSTOMIZE := $(BIN_DIR)/$(KUSTOMIZE_BIN)
 
 GOLANGCI_LINT_BIN := golangci-lint
 GOLANGCI_LINT := $(BIN_DIR)/$(GOLANGCI_LINT_BIN)
+GOLANGCI_LINT_VER := v2.4.0
+GOLANGCI_LINT_CONFIG_FILE := ./custom-gcl
+LINT_ARGS := run ./...
 
 GINKGO_BIN := ginkgo
 GINKGO := $(BIN_DIR)/$(GINKGO_BIN)
@@ -183,8 +186,9 @@ run: manifests generate fmt ## Run a controller from your host.
 ## Linting
 ## --------------------------------------
 
+.PHONY: lint
 lint: $(GOLANGCI_LINT)
-	$(GOLANGCI_LINT) run -v --timeout 300s --fast=false
+	$(GOLANGCI_LINT_CONFIG_FILE) $(LINT_ARGS)
 
 ## --------------------------------------
 ## Docker
@@ -384,7 +388,8 @@ $(GINKGO): ## Build ginkgo.
 	GOBIN=$(BIN_DIR)/ $(GO_INSTALL) github.com/onsi/ginkgo/v2/ginkgo $(GINKGO_BIN) v2.17.1
 
 $(GOLANGCI_LINT): ## Build golanci-lint.
-	GOBIN=$(BIN_DIR)/ $(GO_INSTALL) github.com/golangci/golangci-lint/cmd/golangci-lint $(GOLANGCI_LINT_BIN) v1.44.0
+	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(BIN_DIR) $(GOLANGCI_LINT_VERSION)
+	$(GOLANGCI_LINT) custom
 
 $(ENVSUBST): ## Build envsubst from tools folder.
 	GOBIN=$(TOOLS_BIN_DIR) $(GO_INSTALL) github.com/drone/envsubst/v2/cmd/envsubst $(ENVSUBST_BIN) $(ENVSUBST_VER)

test/e2e/config/e2e_conf.yaml

@@ -84,7 +84,7 @@ providers:
 
 variables:
   KUBERNETES_VERSION: "v1.29.6"
-  OCI_MANAGED_KUBERNETES_VERSION: "v1.31.1"
+  OCI_MANAGED_KUBERNETES_VERSION: "v1.31.10"
   OCI_MANAGED_KUBERNETES_VERSION_UPGRADE: "v1.32.1"
   EXP_CLUSTER_RESOURCE_SET: "true"
   NODE_DRAIN_TIMEOUT: "60s"