Updated pr.

Author: lu-ohai

ads/aqua/extension/deployment_handler.py

@@ -119,7 +119,15 @@ def post(self, *args, **kwargs):  # noqa: ARG002
         if not input_data:
             raise HTTPError(400, Errors.NO_INPUT_DATA)
 
-        self.finish(AquaDeploymentApp().create(**input_data))
+        model_deployment_id = input_data.pop("model_deployment_id", None)
+        if model_deployment_id:
+            self.finish(
+                AquaDeploymentApp().update(
+                    model_deployment_id=model_deployment_id, **input_data
+                )
+            )
+        else:
+            self.finish(AquaDeploymentApp().create(**input_data))
 
     def read(self, id):
         """Read the information of an Aqua model deployment."""

ads/aqua/modeldeployment/deployment.py

@@ -82,7 +82,8 @@
     AquaDeploymentDetail,
     ConfigValidationError,
     CreateModelDeploymentDetails,
-    UpdateModelGroupDeploymentDetails,
+    ModelDeploymentDetails,
+    UpdateModelDeploymentDetails,
 )
 from ads.aqua.modeldeployment.model_group_config import ModelGroupConfig
 from ads.aqua.shaperecommend.recommend import AquaShapeRecommend
@@ -399,14 +400,14 @@ def create(
 
     def _validate_input_models(
         self,
-        create_deployment_details: CreateModelDeploymentDetails,
+        deployment_details: ModelDeploymentDetails,
     ):
-        """Validates the base models and associated fine tuned models from 'models' in create_deployment_details for stacked or multi model deployment."""
+        """Validates the base models and associated fine tuned models from 'models' in create_deployment_details or update_deployment_details for stacked or multi model deployment."""
         # Collect all unique model IDs (including fine-tuned models)
         source_model_ids = list(
             {
                 model_id
-                for model in create_deployment_details.models
+                for model in deployment_details.models
                 for model_id in model.all_model_ids()
             }
         )
@@ -417,7 +418,7 @@ def _validate_input_models(
         source_models = self.get_multi_source(source_model_ids) or {}
 
         try:
-            create_deployment_details.validate_input_models(model_details=source_models)
+            deployment_details.validate_input_models(model_details=source_models)
         except ConfigValidationError as err:
             raise AquaValueError(f"{err}") from err
 
@@ -1255,16 +1256,14 @@ def _get_container_type_key(
     def update(
         self,
         model_deployment_id: str,
-        update_model_deployment_details: Optional[
-            UpdateModelGroupDeploymentDetails
-        ] = None,
+        update_model_deployment_details: Optional[UpdateModelDeploymentDetails] = None,
         **kwargs,
     ) -> AquaDeployment:
         """Updates a AQUA model group deployment.
 
         Args:
-            update_model_deployment_details : UpdateModelGroupDeploymentDetails, optional
-                An instance of UpdateModelGroupDeploymentDetails containing all optional
+            update_model_deployment_details : UpdateModelDeploymentDetails, optional
+                An instance of UpdateModelDeploymentDetails containing all optional
                 fields for updating a model deployment via Aqua.
             kwargs:
                 display_name (str): The name of the model deployment.
@@ -1289,15 +1288,15 @@ def update(
         """
         if not update_model_deployment_details:
             try:
-                update_model_deployment_details = UpdateModelGroupDeploymentDetails(
-                    **kwargs
-                )
+                update_model_deployment_details = UpdateModelDeploymentDetails(**kwargs)
             except ValidationError as ex:
                 custom_errors = build_pydantic_error_message(ex)
                 raise AquaValueError(
                     f"Invalid parameters for updating a model group deployment. Error details: {custom_errors}."
                 ) from ex
 
+        self._validate_input_models(update_model_deployment_details)
+
         model_deployment = ModelDeployment.from_id(model_deployment_id)
 
         infrastructure = model_deployment.infrastructure
@@ -1308,6 +1307,7 @@ def update(
                 "Invalid 'model_deployment_id'. Only model group deployment is supported to update."
             )
 
+        # updates model group if fine tuned weights changed.
         model = self._update_model_group(
             runtime.model_group_id, update_model_deployment_details
         )
@@ -1324,10 +1324,6 @@ def update(
                 update_model_deployment_details.web_concurrency
                 or infrastructure.web_concurrency
             )
-            .with_private_endpoint_id(
-                update_model_deployment_details.private_endpoint_id
-                or infrastructure.private_endpoint_id
-            )
         )
 
         if (
@@ -1358,6 +1354,7 @@ def update(
                 memory_in_gbs=update_model_deployment_details.memory_in_gbs,
             )
 
+        # applies ZDT as default type to update parameters if model group id hasn't been changed
         update_type = ModelDeploymentUpdateType.ZDT
         # applies LIVE update if model group id has been changed
         if runtime.model_group_id != model.id:
@@ -1400,16 +1397,16 @@ def update(
     def _update_model_group(
         self,
         model_group_id: str,
-        update_model_deployment_details: UpdateModelGroupDeploymentDetails,
+        update_model_deployment_details: UpdateModelDeploymentDetails,
     ) -> DataScienceModelGroup:
         """Creates a new model group if fine tuned weights changed.
 
         Parameters
         ----------
         model_group_id: str
             The model group id.
-        update_model_deployment_details: UpdateModelGroupDeploymentDetails
-            An instance of UpdateModelGroupDeploymentDetails containing all optional
+        update_model_deployment_details: UpdateModelDeploymentDetails
+            An instance of UpdateModelDeploymentDetails containing all optional
             fields for updating a model deployment via Aqua.
 
         Returns
@@ -1462,6 +1459,10 @@ def _update_model_group(
                 .create()
             )
 
+            logger.info(
+                f"Model group of base model {target_base_model_id} has been updated: {model_group.id}."
+            )
+
         return model_group
 
     @telemetry(entry_point="plugin=deployment&action=list", name="aqua")