Skip to content

Commit c1f1693

Browse files
esrakartalOptesrakartalOpt
committed
Correct the event url
1 parent a777fa0 commit c1f1693

File tree

2 files changed

+28
-14
lines changed

2 files changed

+28
-14
lines changed

‎tests/test_event_builder.py‎

Lines changed: 21 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ def test_create_impression_event(self):
100100
)
101101
self._validate_event_object(
102102
event_obj,
103-
event_builder.EventBuilder.EVENTS_URL,
103+
event_builder.EventBuilder.EVENTS_URLS.get('US'),
104104
expected_params,
105105
event_builder.EventBuilder.HTTP_VERB,
106106
event_builder.EventBuilder.HTTP_HEADERS,
@@ -155,7 +155,7 @@ def test_create_impression_event__with_attributes(self):
155155
)
156156
self._validate_event_object(
157157
event_obj,
158-
event_builder.EventBuilder.EVENTS_URL,
158+
event_builder.EventBuilder.EVENTS_URLS.get('US'),
159159
expected_params,
160160
event_builder.EventBuilder.HTTP_VERB,
161161
event_builder.EventBuilder.HTTP_HEADERS,
@@ -208,7 +208,7 @@ def test_create_impression_event_when_attribute_is_not_in_datafile(self):
208208
)
209209
self._validate_event_object(
210210
event_obj,
211-
event_builder.EventBuilder.EVENTS_URL,
211+
event_builder.EventBuilder.EVENTS_URLS.get('US'),
212212
expected_params,
213213
event_builder.EventBuilder.HTTP_VERB,
214214
event_builder.EventBuilder.HTTP_HEADERS,
@@ -280,7 +280,7 @@ def side_effect(*args, **kwargs):
280280

281281
self._validate_event_object(
282282
event_obj,
283-
event_builder.EventBuilder.EVENTS_URL,
283+
event_builder.EventBuilder.EVENTS_URLS.get('US'),
284284
expected_params,
285285
event_builder.EventBuilder.HTTP_VERB,
286286
event_builder.EventBuilder.HTTP_HEADERS,
@@ -345,7 +345,7 @@ def test_create_impression_event__with_user_agent_when_bot_filtering_is_enabled(
345345

346346
self._validate_event_object(
347347
event_obj,
348-
event_builder.EventBuilder.EVENTS_URL,
348+
event_builder.EventBuilder.EVENTS_URLS.get('US'),
349349
expected_params,
350350
event_builder.EventBuilder.HTTP_VERB,
351351
event_builder.EventBuilder.HTTP_HEADERS,
@@ -409,7 +409,7 @@ def test_create_impression_event__with_empty_attributes_when_bot_filtering_is_en
409409

410410
self._validate_event_object(
411411
event_obj,
412-
event_builder.EventBuilder.EVENTS_URL,
412+
event_builder.EventBuilder.EVENTS_URLS.get('US'),
413413
expected_params,
414414
event_builder.EventBuilder.HTTP_VERB,
415415
event_builder.EventBuilder.HTTP_HEADERS,
@@ -479,7 +479,7 @@ def test_create_impression_event__with_user_agent_when_bot_filtering_is_disabled
479479

480480
self._validate_event_object(
481481
event_obj,
482-
event_builder.EventBuilder.EVENTS_URL,
482+
event_builder.EventBuilder.EVENTS_URLS.get('US'),
483483
expected_params,
484484
event_builder.EventBuilder.HTTP_VERB,
485485
event_builder.EventBuilder.HTTP_HEADERS,
@@ -515,6 +515,7 @@ def test_create_conversion_event(self):
515515
'enrich_decisions': True,
516516
'anonymize_ip': False,
517517
'revision': '42',
518+
'region': 'US',
518519
}
519520

520521
with mock.patch('time.time', return_value=42.123), mock.patch(
@@ -525,7 +526,7 @@ def test_create_conversion_event(self):
525526
)
526527
self._validate_event_object(
527528
event_obj,
528-
event_builder.EventBuilder.EVENTS_URL,
529+
event_builder.EventBuilder.EVENTS_URLS.get('US'),
529530
expected_params,
530531
event_builder.EventBuilder.HTTP_VERB,
531532
event_builder.EventBuilder.HTTP_HEADERS,
@@ -563,6 +564,7 @@ def test_create_conversion_event__with_attributes(self):
563564
'enrich_decisions': True,
564565
'anonymize_ip': False,
565566
'revision': '42',
567+
'region': 'US',
566568
}
567569

568570
with mock.patch('time.time', return_value=42.123), mock.patch(
@@ -573,7 +575,7 @@ def test_create_conversion_event__with_attributes(self):
573575
)
574576
self._validate_event_object(
575577
event_obj,
576-
event_builder.EventBuilder.EVENTS_URL,
578+
event_builder.EventBuilder.EVENTS_URLS.get('US'),
577579
expected_params,
578580
event_builder.EventBuilder.HTTP_VERB,
579581
event_builder.EventBuilder.HTTP_HEADERS,
@@ -618,6 +620,7 @@ def test_create_conversion_event__with_user_agent_when_bot_filtering_is_enabled(
618620
'enrich_decisions': True,
619621
'anonymize_ip': False,
620622
'revision': '42',
623+
'region': 'US',
621624
}
622625

623626
with mock.patch('time.time', return_value=42.123), mock.patch(
@@ -631,7 +634,7 @@ def test_create_conversion_event__with_user_agent_when_bot_filtering_is_enabled(
631634

632635
self._validate_event_object(
633636
event_obj,
634-
event_builder.EventBuilder.EVENTS_URL,
637+
event_builder.EventBuilder.EVENTS_URLS.get('US'),
635638
expected_params,
636639
event_builder.EventBuilder.HTTP_VERB,
637640
event_builder.EventBuilder.HTTP_HEADERS,
@@ -681,6 +684,7 @@ def test_create_conversion_event__with_user_agent_when_bot_filtering_is_disabled
681684
'enrich_decisions': True,
682685
'anonymize_ip': False,
683686
'revision': '42',
687+
'region': 'US',
684688
}
685689

686690
with mock.patch('time.time', return_value=42.123), mock.patch(
@@ -694,7 +698,7 @@ def test_create_conversion_event__with_user_agent_when_bot_filtering_is_disabled
694698

695699
self._validate_event_object(
696700
event_obj,
697-
event_builder.EventBuilder.EVENTS_URL,
701+
event_builder.EventBuilder.EVENTS_URLS.get('US'),
698702
expected_params,
699703
event_builder.EventBuilder.HTTP_VERB,
700704
event_builder.EventBuilder.HTTP_HEADERS,
@@ -735,6 +739,7 @@ def test_create_conversion_event__with_event_tags(self):
735739
'enrich_decisions': True,
736740
'anonymize_ip': False,
737741
'revision': '42',
742+
'region': 'US',
738743
}
739744

740745
with mock.patch('time.time', return_value=42.123), mock.patch(
@@ -749,7 +754,7 @@ def test_create_conversion_event__with_event_tags(self):
749754
)
750755
self._validate_event_object(
751756
event_obj,
752-
event_builder.EventBuilder.EVENTS_URL,
757+
event_builder.EventBuilder.EVENTS_URLS.get('US'),
753758
expected_params,
754759
event_builder.EventBuilder.HTTP_VERB,
755760
event_builder.EventBuilder.HTTP_HEADERS,
@@ -788,6 +793,7 @@ def test_create_conversion_event__with_invalid_event_tags(self):
788793
'enrich_decisions': True,
789794
'anonymize_ip': False,
790795
'revision': '42',
796+
'region': 'US',
791797
}
792798

793799
with mock.patch('time.time', return_value=42.123), mock.patch(
@@ -802,7 +808,7 @@ def test_create_conversion_event__with_invalid_event_tags(self):
802808
)
803809
self._validate_event_object(
804810
event_obj,
805-
event_builder.EventBuilder.EVENTS_URL,
811+
event_builder.EventBuilder.EVENTS_URLS.get('US'),
806812
expected_params,
807813
event_builder.EventBuilder.HTTP_VERB,
808814
event_builder.EventBuilder.HTTP_HEADERS,
@@ -843,6 +849,7 @@ def test_create_conversion_event__when_event_is_used_in_multiple_experiments(sel
843849
'enrich_decisions': True,
844850
'anonymize_ip': False,
845851
'revision': '42',
852+
'region': 'US',
846853
}
847854

848855
with mock.patch('time.time', return_value=42.123), mock.patch(
@@ -857,7 +864,7 @@ def test_create_conversion_event__when_event_is_used_in_multiple_experiments(sel
857864
)
858865
self._validate_event_object(
859866
event_obj,
860-
event_builder.EventBuilder.EVENTS_URL,
867+
event_builder.EventBuilder.EVENTS_URLS.get('US'),
861868
expected_params,
862869
event_builder.EventBuilder.HTTP_VERB,
863870
event_builder.EventBuilder.HTTP_HEADERS,

‎tests/test_event_factory.py‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -582,6 +582,7 @@ def test_create_conversion_event(self):
582582
'enrich_decisions': True,
583583
'anonymize_ip': False,
584584
'revision': '42',
585+
'region': 'US',
585586
}
586587

587588
with mock.patch('time.time', return_value=42.123), mock.patch(
@@ -629,6 +630,7 @@ def test_create_conversion_event__with_attributes(self):
629630
'enrich_decisions': True,
630631
'anonymize_ip': False,
631632
'revision': '42',
633+
'region': 'US',
632634
}
633635

634636
with mock.patch('time.time', return_value=42.123), mock.patch(
@@ -683,6 +685,7 @@ def test_create_conversion_event__with_user_agent_when_bot_filtering_is_enabled(
683685
'enrich_decisions': True,
684686
'anonymize_ip': False,
685687
'revision': '42',
688+
'region': 'US',
686689
}
687690

688691
with mock.patch('time.time', return_value=42.123), mock.patch(
@@ -744,6 +747,7 @@ def test_create_conversion_event__with_user_agent_when_bot_filtering_is_disabled
744747
'enrich_decisions': True,
745748
'anonymize_ip': False,
746749
'revision': '42',
750+
'region': 'US',
747751
}
748752

749753
with mock.patch('time.time', return_value=42.123), mock.patch(
@@ -796,6 +800,7 @@ def test_create_conversion_event__with_event_tags(self):
796800
'enrich_decisions': True,
797801
'anonymize_ip': False,
798802
'revision': '42',
803+
'region': 'US',
799804
}
800805

801806
with mock.patch('time.time', return_value=42.123), mock.patch(
@@ -848,6 +853,7 @@ def test_create_conversion_event__with_invalid_event_tags(self):
848853
'enrich_decisions': True,
849854
'anonymize_ip': False,
850855
'revision': '42',
856+
'region': 'US',
851857
}
852858

853859
with mock.patch('time.time', return_value=42.123), mock.patch(
@@ -902,6 +908,7 @@ def test_create_conversion_event__when_event_is_used_in_multiple_experiments(sel
902908
'enrich_decisions': True,
903909
'anonymize_ip': False,
904910
'revision': '42',
911+
'region': 'US',
905912
}
906913

907914
with mock.patch('time.time', return_value=42.123), mock.patch(

0 commit comments

Comments
 (0)