Skip to content

Commit 3792c52

Browse files
update: type checking fix
1 parent 3312944 commit 3792c52

20 files changed

+22
-22
lines changed

optimizely/bucketer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
if version_info < (3, 8):
2323
from typing_extensions import Final
2424
else:
25-
from typing import Final # type: ignore
25+
from typing import Final
2626

2727

2828
if TYPE_CHECKING:

optimizely/cmab/cmab_service.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
from optimizely.project_config import ProjectConfig
2323
from optimizely.decision.optimizely_decide_option import OptimizelyDecideOption
2424
from optimizely import logger as _logging
25-
25+
from optimizely.lib import pymmh3 as mmh3
2626
NUM_LOCK_STRIPES = 1000
2727

2828

@@ -61,8 +61,8 @@ def _get_lock_index(self, user_id: str, rule_id: str) -> int:
6161
"""Calculate the lock index for a given user and rule combination."""
6262
# Create a hash of user_id + rule_id for consistent lock selection
6363
hash_input = f"{user_id}{rule_id}"
64-
hash_value = int(hashlib.md5(hash_input.encode()).hexdigest(), 16) % NUM_LOCK_STRIPES
65-
return hash_value
64+
hash_value = mmh3.hash(hash_input, seed=0) & 0xFFFFFFFF # Convert to unsigned
65+
return hash_value % NUM_LOCK_STRIPES
6666

6767
def get_decision(self, project_config: ProjectConfig, user_context: OptimizelyUserContext,
6868
rule_id: str, options: List[str]) -> CmabDecision:

optimizely/decision/optimizely_decide_option.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
if version_info < (3, 8):
1717
from typing_extensions import Final
1818
else:
19-
from typing import Final # type: ignore
19+
from typing import Final
2020

2121

2222
class OptimizelyDecideOption:

optimizely/decision/optimizely_decision_message.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
if version_info < (3, 8):
1717
from typing_extensions import Final
1818
else:
19-
from typing import Final # type: ignore
19+
from typing import Final
2020

2121

2222
class OptimizelyDecisionMessage:

optimizely/entities.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
if version_info < (3, 8):
1818
from typing_extensions import Final
1919
else:
20-
from typing import Final # type: ignore
20+
from typing import Final
2121

2222

2323
if TYPE_CHECKING:

optimizely/event/event_factory.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
if version_info < (3, 8):
2626
from typing_extensions import Final
2727
else:
28-
from typing import Final # type: ignore
28+
from typing import Final
2929

3030
if TYPE_CHECKING:
3131
# prevent circular dependenacy by skipping import at runtime

optimizely/event/event_processor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
if version_info < (3, 8):
3535
from typing_extensions import Final
3636
else:
37-
from typing import Final # type: ignore
37+
from typing import Final
3838

3939

4040
class BaseEventProcessor(ABC):

optimizely/event/log_event.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
if version_info < (3, 8):
2121
from typing_extensions import Literal
2222
else:
23-
from typing import Literal # type: ignore
23+
from typing import Literal
2424

2525

2626
class LogEvent(event_builder.Event):

optimizely/event/user_event.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
if version_info < (3, 8):
2323
from typing_extensions import Final
2424
else:
25-
from typing import Final # type: ignore
25+
from typing import Final
2626

2727

2828
if TYPE_CHECKING:

optimizely/event_builder.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
if version_info < (3, 8):
2626
from typing_extensions import Final, Literal
2727
else:
28-
from typing import Final, Literal # type: ignore
28+
from typing import Final, Literal
2929

3030
if TYPE_CHECKING:
3131
# prevent circular dependenacy by skipping import at runtime

0 commit comments

Comments
 (0)