update: make cmab_uuid parameter optional in _send_impression_event method

Author: FarhanAnjum-opti

optimizely/optimizely.py

@@ -261,7 +261,7 @@ def _validate_user_inputs(
     def _send_impression_event(
         self, project_config: project_config.ProjectConfig, experiment: Optional[entities.Experiment],
         variation: Optional[entities.Variation], flag_key: str, rule_key: str, rule_type: str,
-        enabled: bool, user_id: str, attributes: Optional[UserAttributes], cmab_uuid: Optional[str]
+        enabled: bool, user_id: str, attributes: Optional[UserAttributes], cmab_uuid: Optional[str] = None
     ) -> None:
         """ Helper method to send impression event.
 

tests/test_optimizely.py

@@ -4890,66 +4890,6 @@ def test_odp_events_not_sent_with_legacy_apis(self):
 
         client.close()
 
-    def test_activate_with_cmab_uuid(self):
-        """ Test that activate includes CMAB UUID when available from CMAB service. """
-        expected_cmab_uuid = "test-cmab-uuid-123"
-        variation_result = {
-            'variation': self.project_config.get_variation_from_id('test_experiment', '111129'),
-            'cmab_uuid': expected_cmab_uuid,
-            'reasons': [],
-            'error': False
-        }
-
-        with mock.patch(
-            'optimizely.decision_service.DecisionService.get_variation',
-            return_value=variation_result,
-        ), mock.patch('time.time', return_value=42), mock.patch(
-            'uuid.uuid4', return_value='a68cf1ad-0393-4e18-af87-efe8f01a7c9c'
-        ), mock.patch(
-            'optimizely.event.event_processor.BatchEventProcessor.process'
-        ) as mock_process:
-            result = self.optimizely.activate('test_experiment', 'test_user')
-            self.assertEqual('variation', result)
-
-        # Verify the impression event includes CMAB UUID
-        impression_event = mock_process.call_args[0][0]
-        self.assertEqual(impression_event.cmab_uuid, expected_cmab_uuid)
-
-        # Verify the log event includes CMAB UUID in metadata
-        log_event = EventFactory.create_log_event(impression_event, self.optimizely.logger)
-        metadata = log_event.params['visitors'][0]['snapshots'][0]['decisions'][0]['metadata']
-        self.assertIn('cmab_uuid', metadata)
-        self.assertEqual(metadata['cmab_uuid'], expected_cmab_uuid)
-
-    def test_activate_without_cmab_uuid(self):
-        """ Test that activate works correctly when CMAB service returns None. """
-        variation_result = {
-            'variation': self.project_config.get_variation_from_id('test_experiment', '111129'),
-            'cmab_uuid': None,
-            'reasons': [],
-            'error': False
-        }
-
-        with mock.patch(
-            'optimizely.decision_service.DecisionService.get_variation',
-            return_value=variation_result,
-        ), mock.patch('time.time', return_value=42), mock.patch(
-            'uuid.uuid4', return_value='a68cf1ad-0393-4e18-af87-efe8f01a7c9c'
-        ), mock.patch(
-            'optimizely.event.event_processor.BatchEventProcessor.process'
-        ) as mock_process:
-            result = self.optimizely.activate('test_experiment', 'test_user')
-            self.assertEqual('variation', result)
-
-        # Verify the impression event has no CMAB UUID
-        impression_event = mock_process.call_args[0][0]
-        self.assertIsNone(impression_event.cmab_uuid)
-
-        # Verify the log event does not include CMAB UUID in metadata
-        log_event = EventFactory.create_log_event(impression_event, self.optimizely.logger)
-        metadata = log_event.params['visitors'][0]['snapshots'][0]['decisions'][0]['metadata']
-        self.assertNotIn('cmab_uuid', metadata)
-
     def test_get_variation_with_cmab_uuid(self):
         """ Test that get_variation works correctly with CMAB UUID. """
         expected_cmab_uuid = "get-variation-cmab-uuid"
@@ -4965,7 +4905,7 @@ def test_get_variation_with_cmab_uuid(self):
             return_value=variation_result,
         ), mock.patch('optimizely.notification_center.NotificationCenter.send_notifications') as mock_broadcast:
             variation = self.optimizely.get_variation('test_experiment', 'test_user')
-            self.assertEqual('variation', variation['variation'].key)
+            self.assertEqual('variation', variation)
 
         # Verify decision notification is sent with correct parameters
         mock_broadcast.assert_any_call(
@@ -4990,7 +4930,7 @@ def test_get_variation_without_cmab_uuid(self):
             return_value=variation_result,
         ), mock.patch('optimizely.notification_center.NotificationCenter.send_notifications') as mock_broadcast:
             variation = self.optimizely.get_variation('test_experiment', 'test_user')
-            self.assertEqual('variation', variation['variation'].key)
+            self.assertEqual('variation', variation)
 
         # Verify decision notification is sent correctly
         mock_broadcast.assert_any_call(