set minimum TSL (#338)

Author: thomaszurkan-optimizely

OptimizelyDemoApp/AppDelegate.swift

@@ -36,7 +36,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
 
     // customizable settings
     let datafileName = "demoTestDatafile" // default parameter for initializing Optimizely from saved datafile
-    var projectId = "11093712109" // project name: X Mobile - Sample App
+    var projectId:String? // project name: X Mobile - Sample App
     var experimentKey = "background_experiment"
     var eventKey = "sample_conversion"
     let attributes = ["sample_attribute_key":"sample_attribute_value"]

OptimizelySDKCore/OptimizelySDKCore/OPTLYHTTPRequestManager.m

@@ -26,6 +26,8 @@
 
 @interface OPTLYHTTPRequestManager()
 
+- (NSURLSession *)session;
+
 // Use this flag to deterine if we are running a unit test
 // The flag is needed to track some values for unit test
 @property (nonatomic, assign) BOOL isRunningTest;
@@ -35,6 +37,13 @@ @interface OPTLYHTTPRequestManager()
 
 @implementation OPTLYHTTPRequestManager
 
+- (NSURLSession *)session {
+    NSURLSession *ephemeralSession = [NSURLSession sessionWithConfiguration:[NSURLSessionConfiguration ephemeralSessionConfiguration]];
+    ephemeralSession.configuration.TLSMinimumSupportedProtocol = kTLSProtocol12;
+
+    return ephemeralSession;
+}
+
 # pragma mark - Object Initializers
 
 - (id)init
@@ -83,9 +92,9 @@ - (void)GETWithParameters:(NSDictionary *)parameters
                       url:(NSURL *)url
         completionHandler:(OPTLYHTTPRequestManagerResponse)completion
 {
-    NSURLSession *ephemeralSession = [NSURLSession sessionWithConfiguration:[NSURLSessionConfiguration ephemeralSessionConfiguration]];
+    
     NSURL *urlWithParameterQuery = [self buildQueryURL:url withParameters:parameters];
-    NSURLSessionDataTask *downloadTask = [ephemeralSession dataTaskWithURL:urlWithParameterQuery
+    NSURLSessionDataTask *downloadTask = [self.session dataTaskWithURL:urlWithParameterQuery
                                                          completionHandler:^(NSData *data, NSURLResponse *response, NSError *error) {
                                                              if (completion) {
                                                                  completion(data, response, error);
@@ -178,8 +187,7 @@ - (void)GETIfModifiedSince:(NSString *)lastModifiedDate
     NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:url];
     [request setValue:lastModifiedDate forHTTPHeaderField:@"If-Modified-Since"];
 
-    NSURLSession *ephemeralSession = [NSURLSession sessionWithConfiguration:[NSURLSessionConfiguration ephemeralSessionConfiguration]];
-    NSURLSessionDataTask *dataTask = [ephemeralSession dataTaskWithRequest:request completionHandler:^(NSData * _Nullable data, NSURLResponse * _Nullable response, NSError * _Nullable error) {
+    NSURLSessionDataTask *dataTask = [self.session dataTaskWithRequest:request completionHandler:^(NSData * _Nullable data, NSURLResponse * _Nullable response, NSError * _Nullable error) {
         if (completion) {
             completion(data, response, error);
         }
@@ -272,7 +280,6 @@ - (void)POSTWithParameters:(NSDictionary *)parameters
                        url:(NSURL *)url
          completionHandler:(OPTLYHTTPRequestManagerResponse)completion
 {
-    NSURLSession *ephemeralSession = [NSURLSession sessionWithConfiguration:[NSURLSessionConfiguration ephemeralSessionConfiguration]];
     NSMutableURLRequest *request = [[NSMutableURLRequest alloc] initWithURL:url];
     [request setHTTPMethod:kHTTPRequestMethodPost];
 
@@ -288,7 +295,7 @@ - (void)POSTWithParameters:(NSDictionary *)parameters
 
     [request addValue:kHTTPHeaderFieldValueApplicationJSON forHTTPHeaderField:kHTTPHeaderFieldContentType];
 
-    NSURLSessionUploadTask *uploadTask = [ephemeralSession uploadTaskWithRequest:request
+    NSURLSessionUploadTask *uploadTask = [self.session uploadTaskWithRequest:request
                                                                         fromData:data
                                                                completionHandler:^(NSData *data,NSURLResponse *response,NSError *error) {
                                                                    if (completion) {