[AI-FSSDK] [FSSDK-12735] Fix decisionEventDispatched for holdout impression and add missing decision reason

Author: esrakartalOpt

lib/core/decision_service/index.spec.ts

@@ -19,7 +19,7 @@ import {
   USER_HAS_NO_FORCED_VARIATION
 } from 'log_message';
 import { beforeEach, describe, expect, it, MockInstance, vi } from 'vitest';
-import { CMAB_DUMMY_ENTITY_ID, CMAB_FETCH_FAILED, DecisionService } from '.';
+import { CMAB_DUMMY_ENTITY_ID, CMAB_FETCH_FAILED, DecisionService, TARGETED_DELIVERY_EXCLUDED_FROM_HOLDOUT } from '.';
 import OptimizelyUserContext from '../../optimizely_user_context';
 import { createProjectConfig, ProjectConfig } from '../../project_config/project_config';
 import { BucketerParams, Experiment, ExperimentBucketMap, Holdout, OptimizelyDecideOption, UserAttributes, UserProfile } from '../../shared_types';
@@ -2286,6 +2286,9 @@ describe('DecisionService', () => {
               variation: config.variationIdMap['holdout_variation_running_id'],
             },
           });
+
+          const reasonStrings = variation.reasons.map((r: any) => typeof r === 'string' ? r : r[0]);
+          expect(reasonStrings).toContain(TARGETED_DELIVERY_EXCLUDED_FROM_HOLDOUT);
         });
 
         it('should return null decision with holdout info when excludeTargetedDeliveries is true but no delivery matches', async () => {

lib/core/decision_service/index.ts

@@ -119,7 +119,7 @@ export const USER_MEETS_CONDITIONS_FOR_HOLDOUT = 'User %s meets conditions for h
 export const USER_DOESNT_MEET_CONDITIONS_FOR_HOLDOUT = 'User %s does not meet conditions for holdout %s.';
 export const USER_BUCKETED_INTO_HOLDOUT_VARIATION = 'User %s is in variation %s of holdout %s.';
 export const USER_NOT_BUCKETED_INTO_HOLDOUT_VARIATION = 'User %s is in no holdout variation.';
-export const TARGETED_DELIVERY_EXCLUDED_FROM_HOLDOUT = 'User %s is in holdout %s but targeted deliveries are excluded from holdout.';
+export const TARGETED_DELIVERY_EXCLUDED_FROM_HOLDOUT = "Holdout '%s' has excludeTargetedDeliveries enabled, continuing to rollout evaluation.";
 
 export interface DecisionObj {
   experiment: Experiment | Holdout | null;
@@ -984,8 +984,8 @@ export class DecisionService {
       if (holdoutDecision.result.variation) {
         if (holdout.excludeTargetedDeliveries) {
           const userId = user.getUserId();
-          this.logger?.info(TARGETED_DELIVERY_EXCLUDED_FROM_HOLDOUT, userId, holdout.key);
-          decideReasons.push([TARGETED_DELIVERY_EXCLUDED_FROM_HOLDOUT, userId, holdout.key]);
+          this.logger?.info(TARGETED_DELIVERY_EXCLUDED_FROM_HOLDOUT, holdout.key);
+          decideReasons.push([TARGETED_DELIVERY_EXCLUDED_FROM_HOLDOUT, holdout.key]);
           activeHoldoutDecision = holdoutDecision.result;
           activeHoldout = holdout;
           break;

lib/optimizely/index.spec.ts

@@ -875,6 +875,11 @@ describe('Optimizely', () => {
 
     it('should dispatch separate holdout impression when decisionObj.holdout is populated', async () => {
       const processSpy = vi.spyOn(eventProcessor, 'process');
+      const notificationSpyLocal = vi.fn();
+      optimizely.notificationCenter.addNotificationListener(
+        NOTIFICATION_TYPES.DECISION,
+        notificationSpyLocal
+      );
 
       const holdoutExperiment = projectConfig.holdouts[0];
       const holdoutVariation = projectConfig.holdouts[0].variations[0];
@@ -917,6 +922,15 @@ describe('Optimizely', () => {
       expect(holdoutImpression.ruleKey).toBe('holdout_test_key');
       expect(holdoutImpression.ruleType).toBe('holdout');
       expect(holdoutImpression.enabled).toBe(false);
+
+      expect(notificationSpyLocal).toHaveBeenCalledWith(
+        expect.objectContaining({
+          type: DECISION_NOTIFICATION_TYPES.FLAG,
+          decisionInfo: expect.objectContaining({
+            decisionEventDispatched: true,
+          }),
+        })
+      );
     });
   });
 

lib/optimizely/index.ts

@@ -1549,6 +1549,7 @@ export default class Optimizely extends BaseService implements Client {
           decisionSource: DECISION_SOURCES.HOLDOUT,
         };
         this.sendImpressionEvent(holdoutDecisionObj, key, userId, false, attributes);
+        decisionEventDispatched = true;
       }
 
       const shouldIncludeReasons = options[OptimizelyDecideOption.INCLUDE_REASONS];