Enforce go fmt in CI (errors are present). (#313)

* Enforce go fmt in CI (errors are present).

* s/esle/else

* Fix fmt

* Use existing linter without simplify.

* Adjust copyright.

Author: keppel2

.golangci.yml

@@ -25,6 +25,8 @@ linters-settings:
      - wrapperFunc
      - hugeParam
      - rangeValCopy
+ gofmt:
+   simplify: false
 
 linters:
  disable-all: true
@@ -54,6 +56,7 @@ linters:
    - gosimple
    - prealloc 
    - maligned
+   - gofmt
  fast: false
 
 run:

optimizely.go

@@ -1,5 +1,5 @@
 /****************************************************************************
- * Copyright 2019, Optimizely, Inc. and contributors                        *
+ * Copyright 2019, 2021 Optimizely, Inc. and contributors                        *
  *                                                                          *
  * Licensed under the Apache License, Version 2.0 (the "License");          *
  * you may not use this file except in compliance with the License.         *
@@ -32,7 +32,7 @@ func Client(sdkKey string, options ...client.OptionFunc) (*client.OptimizelyClie
 // UserContext is a helper method for creating a user context
 func UserContext(userID string, attributes map[string]interface{}) entities.UserContext {
 	return entities.UserContext{
-		ID: userID,
+		ID:         userID,
 		Attributes: attributes,
 	}
 }

pkg/decision/bucketer/experiment_bucketer_test.go

@@ -47,7 +47,7 @@ func TestBucketExclusionGroups(t *testing.T) {
 		},
 	}
 
-	bucketer := NewMurmurhashExperimentBucketer(logging.GetLogger("","TestBucketExclusionGroups" ), DefaultHashSeed)
+	bucketer := NewMurmurhashExperimentBucketer(logging.GetLogger("", "TestBucketExclusionGroups"), DefaultHashSeed)
 	// ppid2 + 1886780722 (groupId) will generate bucket value of 2434 which maps to experiment 1
 	bucketedVariation, reason, _ := bucketer.Bucket("ppid2", experiment1, exclusionGroup)
 	assert.Equal(t, experiment1.Variations["22222"], *bucketedVariation)

pkg/decision/bucketer/murmurhashbucketer.go

@@ -1,5 +1,5 @@
 /****************************************************************************
- * Copyright 2019, Optimizely, Inc. and contributors                        *
+ * Copyright 2019, 2021 Optimizely, Inc. and contributors                        *
  *                                                                          *
  * Licensed under the Apache License, Version 2.0 (the "License");          *
  * you may not use this file except in compliance with the License.         *
@@ -49,7 +49,7 @@ type MurmurhashBucketer struct {
 func NewMurmurhashBucketer(logger logging.OptimizelyLogProducer, hashSeed uint32) *MurmurhashBucketer {
 	return &MurmurhashBucketer{
 		hashSeed: hashSeed,
-		logger: logger,
+		logger:   logger,
 	}
 }
 

pkg/logging/level_log_consumer.go

@@ -1,5 +1,5 @@
 /****************************************************************************
- * Copyright 2019, Optimizely, Inc. and contributors                        *
+ * Copyright 2019, 2021 Optimizely, Inc. and contributors                        *
  *                                                                          *
  * Licensed under the Apache License, Version 2.0 (the "License");          *
  * you may not use this file except in compliance with the License.         *
@@ -46,7 +46,7 @@ func (l *FilteredLevelLogConsumer) Log(level LogLevel, message string, fields ma
 		sort.Strings(keys)
 
 		for _, k := range keys {
-			if s, ok := fields[k].(string);ok && s != "" {
+			if s, ok := fields[k].(string); ok && s != "" {
 				fmt.Fprintf(&messBuilder, "[%s]", s)
 			}
 		}

pkg/notification/manager.go

@@ -1,5 +1,5 @@
 /****************************************************************************
- * Copyright 2019-2020, Optimizely, Inc. and contributors                   *
+ * Copyright 2019-2021, Optimizely, Inc. and contributors                   *
  *                                                                          *
  * Licensed under the Apache License, Version 2.0 (the "License");          *
  * you may not use this file except in compliance with the License.         *
@@ -43,7 +43,7 @@ type AtomicManager struct {
 // NewAtomicManager creates a new instance of the atomic manager
 func NewAtomicManager(logger logging.OptimizelyLogProducer) *AtomicManager {
 	return &AtomicManager{
-		logger: logger,
+		logger:   logger,
 		handlers: make(map[uint32]func(interface{})),
 	}
 }

pkg/utils/execgroup.go

@@ -1,5 +1,5 @@
 /****************************************************************************
- * Copyright 2019, Optimizely, Inc. and contributors                        *
+ * Copyright 2019, 2021 Optimizely, Inc. and contributors                        *
  *                                                                          *
  * Licensed under the Apache License, Version 2.0 (the "License");          *
  * you may not use this file except in compliance with the License.         *
@@ -36,7 +36,7 @@ func NewExecGroup(ctx context.Context, logger logging.OptimizelyLogProducer) *Ex
 	nctx, cancelFn := context.WithCancel(ctx)
 	wg := sync.WaitGroup{}
 
-	return &ExecGroup{wg: &wg, ctx: nctx, cancelFunc: cancelFn, logger:logger}
+	return &ExecGroup{wg: &wg, ctx: nctx, cancelFunc: cancelFn, logger: logger}
 }
 
 // Go initiates a goroutine with the inputted function. Each invocation increments a shared WaitGroup

pkg/utils/requester_test.go

@@ -1,5 +1,5 @@
 /****************************************************************************
- * Copyright 2019, Optimizely, Inc. and contributors                        *
+ * Copyright 2019, 2021 Optimizely, Inc. and contributors                        *
  *                                                                          *
  * Licensed under the Apache License, Version 2.0 (the "License");          *
  * you may not use this file except in compliance with the License.         *
@@ -40,7 +40,7 @@ func TestHeaders(t *testing.T) {
 func TestAddHeaders(t *testing.T) {
 
 	req, _ := http.NewRequest("GET", "", nil)
-	requester := &HTTPRequester{logger:logging.GetLogger("", "")}
+	requester := &HTTPRequester{logger: logging.GetLogger("", "")}
 	headers := []Header{{"one", "1"}}
 
 	fn := Headers(Header{"two", "2"})