[FSSDK-11150] review update 2

junaed-optimizely · junaed-optimizely · commit 5227e6d31518 · 2025-09-25T01:13:42.000+06:00
diff --git a/OptimizelySDK/Cmab/DefaultCmabClient.cs b/OptimizelySDK/Cmab/DefaultCmabClient.cs
@@ -151,12 +151,16 @@ private async Task<string> DoFetchOnceAsync(string url, CmabRequest request, Tim
                     _logger.Log(LogLevel.ERROR, CmabConstants.ErrorInvalidResponse);
                     throw new CmabInvalidResponseException(ex.Message);
                 }
+                catch(CmabInvalidResponseException)
+                {
+                    throw;
+                }
                 catch (HttpRequestException ex)
                 {
                     _logger.Log(LogLevel.ERROR, string.Format(CmabConstants.ErrorFetchFailedFmt, ex.Message));
                     throw new CmabFetchException(string.Format(CmabConstants.ErrorFetchFailedFmt, ex.Message));
                 }
-                catch (Exception ex) when (!(ex is CmabInvalidResponseException))
+                catch (Exception ex)
                 {
                     _logger.Log(LogLevel.ERROR, string.Format(CmabConstants.ErrorFetchFailedFmt, ex.Message));
                     throw new CmabFetchException(string.Format(CmabConstants.ErrorFetchFailedFmt, ex.Message));

Original file line number	Diff line number	Diff line change
`@@ -151,12 +151,16 @@ private async Task<string> DoFetchOnceAsync(string url, CmabRequest request, Tim`
`151`	`151`	`_logger.Log(LogLevel.ERROR, CmabConstants.ErrorInvalidResponse);`
`152`	`152`	`throw new CmabInvalidResponseException(ex.Message);`
`153`	`153`	`}`
	`154`	`+ catch(CmabInvalidResponseException)`
	`155`	`+ {`
	`156`	`+ throw;`
	`157`	`+ }`
`154`	`158`	`catch (HttpRequestException ex)`
`155`	`159`	`{`
`156`	`160`	`_logger.Log(LogLevel.ERROR, string.Format(CmabConstants.ErrorFetchFailedFmt, ex.Message));`
`157`	`161`	`throw new CmabFetchException(string.Format(CmabConstants.ErrorFetchFailedFmt, ex.Message));`
`158`	`162`	`}`
`159`		`- catch (Exception ex) when (!(ex is CmabInvalidResponseException))`
	`163`	`+ catch (Exception ex)`
`160`	`164`	`{`
`161`	`165`	`_logger.Log(LogLevel.ERROR, string.Format(CmabConstants.ErrorFetchFailedFmt, ex.Message));`
`162`	`166`	`throw new CmabFetchException(string.Format(CmabConstants.ErrorFetchFailedFmt, ex.Message));`