refactoring

Author: kirillshevch

Rakefile

@@ -1,2 +1,2 @@
-require "bundler/gem_tasks"
-task :default => :spec
+require 'bundler/gem_tasks'
+task default: :spec

lib/operators-service.rb

@@ -0,0 +1,2 @@
+require 'dry-monads'
+require 'operators/service'

lib/operators/service.rb

@@ -1,5 +1,3 @@
-require 'dry-monads'
-
 module Operators
   class Service
     def self.rescue_callbacks(*exceptions)
@@ -37,7 +35,7 @@ def success_wrap(result)
     end
 
     def calling
-      raise 'Must be redefined'
+      raise 'Not implemented'
     end
   end
 end

lib/operators_service.rb

@@ -1,4 +1,5 @@
 # coding: utf-8
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 

operators-service.gemspec

@@ -1,6 +1,6 @@
-RSpec.describe Operators::Service do
+describe Operators::Service do
   before do
-    class TestSerivce < Operators::Service
+    class TestService < Operators::Service
       rescue_callbacks SyntaxError
 
       def initialize(data, result)
@@ -19,17 +19,17 @@ def except_error(error)
   end
 
   it 'success result' do
-    result = TestSerivce.call('data', true)
+    result = TestService.call('data', true)
     expect(result.success?).to be_truthy
   end
 
   it 'failure result' do
-    result = TestSerivce.call('data', false)
+    result = TestService.call('data', false)
     expect(result.success?).to be_falsey
   end
 
   context 'catch error' do
-    subject { TestSerivce.new('error', true) }
+    subject { TestService.new('error', true) }
 
     it 'catch' do
       allow(subject).to receive(:calling).and_raise(SyntaxError)

spec/operators/service_spec.rb

@@ -1,6 +1,6 @@
 require 'bundler/setup'
 require 'byebug'
-require 'operators/service'
+require 'operators-service'
 
 RSpec.configure do |config|
   config.order = :random