-
Notifications
You must be signed in to change notification settings - Fork 566
Upgrade dependencies; ocp/api*, kube-openapi and indirects #3707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Upgrade dependencies; ocp/api*, kube-openapi and indirects #3707
Conversation
9875e78 to
41f6899
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b685610 to
d7bff60
Compare
d7bff60 to
874936f
Compare
Generated-by: Cursor
874936f to
d93b67e
Compare
| }, | ||
| }, | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmshort I need to address a breaking change in the recent ocp/api dependency upgrade.
Previous Behavior:
Our tests were loading ClusterOperator and ClusterVersion CRDs from YAML files in the vendor directory (github.com/openshift/api/config/v1/0000_00_cluster-version-operator_01_*.crd.yaml) and applying them directly to the envtest environment.
Breaking Change:
The upgraded github.com/openshift/api package (v0.0.0-20251111193948+) no longer provides individual CRD YAML files - they were removed in favor of a consolidated manifest.
Solution:
We're now generating the ClusterOperator and ClusterVersion CRDs programmatically in the test suite. This approach allows us still doing the test for OCP but still running it with kind/envtest.
Note: The CRD strict schema code in newClusterOperatorCRD() and newClusterVersionCRD() was generated by AI to match the required OpenShift API structure.
Dependency Updates
github.com/openshift/apiv0.0.0-20221021112143v0.0.0-20251111193948github.com/openshift/client-gov0.0.0-20220525160904v0.0.0-20251015124057k8s.io/kube-openapigolang.org/x/netgolang.org/x/termgithub.com/google/pprofBreaking Change
The upgraded
github.com/openshift/apiremoved individual CRD YAML files from vendor. Tests were loadingClusterOperatorandClusterVersionCRDs from these files.Fix: Generate CRDs programmatically in tests instead of loading from files.
newClusterOperatorCRD()andnewClusterVersionCRD()helper functions