fix tests to work with latest ocp/api versions

Generated-by: Cursor

Author: camilamacedo86

pkg/controller/operators/openshift/suite_test.go

@@ -2,7 +2,6 @@ package openshift
 
 import (
 	"context"
-	"path/filepath"
 	"testing"
 	"time"
 
@@ -46,15 +45,18 @@ const (
 var _ = BeforeSuite(func() {
 	logf.SetLogger(zap.New(zap.WriteTo(GinkgoWriter), zap.UseDevMode(true)))
 
-	base := filepath.Join("..", "..", "..", "..", "vendor", "github.com", "openshift", "api", "config", "v1")
+	// Note: OpenShift CRDs are created programmatically instead of loading from files.
+	// Breaking change: The github.com/openshift/api package (v0.0.0-20251111193948+)
+	// no longer ships individual CRD YAML files in vendor (they were removed in favor
+	// of a consolidated manifest). Previously, tests loaded CRDs directly from vendor
+	// paths like "0000_00_cluster-version-operator_01_clusteroperator.crd.yaml".
+	// Now we generate minimal CRDs programmatically to keep tests self-contained and
+	// ensure they work in envtest/kind environments. CRD schemas generated by AI.
 	testEnv = &envtest.Environment{
-		ErrorIfCRDPathMissing: true,
 		CRDs: []*apiextensionsv1.CustomResourceDefinition{
 			crds.ClusterServiceVersion(),
-		},
-		CRDDirectoryPaths: []string{
-			filepath.Join(base, "0000_00_cluster-version-operator_01_clusteroperator.crd.yaml"),
-			filepath.Join(base, "0000_00_cluster-version-operator_01_clusterversion.crd.yaml"),
+			newClusterOperatorCRD(),
+			newClusterVersionCRD(),
 		},
 	}
 
@@ -73,6 +75,9 @@ var _ = BeforeSuite(func() {
 	})
 	Expect(err).ToNot(HaveOccurred())
 
+	// Register OpenShift types with the scheme
+	Expect(configv1.AddToScheme(mgr.GetScheme())).To(Succeed())
+
 	k8sClient = mgr.GetClient()
 
 	syncCh = make(chan error)
@@ -111,3 +116,149 @@ var _ = AfterSuite(func() {
 	close(syncCh)
 	testEnv.Stop()
 })
+
+// newClusterOperatorCRD creates a minimal ClusterOperator CRD for testing.
+// This is required because github.com/openshift/api no longer ships individual
+// CRD YAML files in vendor. We create a programmatic CRD with the minimum schema
+// needed for the controller tests to pass.
+func newClusterOperatorCRD() *apiextensionsv1.CustomResourceDefinition {
+	return &apiextensionsv1.CustomResourceDefinition{
+		ObjectMeta: metav1.ObjectMeta{
+			Name: "clusteroperators.config.openshift.io",
+		},
+		Spec: apiextensionsv1.CustomResourceDefinitionSpec{
+			Group: "config.openshift.io",
+			Names: apiextensionsv1.CustomResourceDefinitionNames{
+				Plural:     "clusteroperators",
+				Singular:   "clusteroperator",
+				Kind:       "ClusterOperator",
+				ListKind:   "ClusterOperatorList",
+				ShortNames: []string{"co"},
+			},
+			Scope: apiextensionsv1.ClusterScoped,
+			Versions: []apiextensionsv1.CustomResourceDefinitionVersion{
+				{
+					Name:    "v1",
+					Served:  true,
+					Storage: true,
+					Schema: &apiextensionsv1.CustomResourceValidation{
+						OpenAPIV3Schema: &apiextensionsv1.JSONSchemaProps{
+							Type:        "object",
+							Description: "ClusterOperator is the Custom Resource object which holds the current state of an operator",
+							Properties: map[string]apiextensionsv1.JSONSchemaProps{
+								"spec": {
+									Type:        "object",
+									Description: "spec holds configuration that could apply to any operator",
+									Properties:  map[string]apiextensionsv1.JSONSchemaProps{},
+								},
+								"status": {
+									Type:        "object",
+									Description: "status holds the information about the state of an operator",
+									Properties: map[string]apiextensionsv1.JSONSchemaProps{
+										"conditions": {
+											Type: "array",
+											Items: &apiextensionsv1.JSONSchemaPropsOrArray{
+												Schema: &apiextensionsv1.JSONSchemaProps{
+													Type: "object",
+													Properties: map[string]apiextensionsv1.JSONSchemaProps{
+														"type":               {Type: "string"},
+														"status":             {Type: "string"},
+														"lastTransitionTime": {Type: "string", Format: "date-time"},
+														"reason":             {Type: "string"},
+														"message":            {Type: "string"},
+													},
+													Required: []string{"type", "status"},
+												},
+											},
+										},
+										"versions": {
+											Type: "array",
+											Items: &apiextensionsv1.JSONSchemaPropsOrArray{
+												Schema: &apiextensionsv1.JSONSchemaProps{
+													Type: "object",
+													Properties: map[string]apiextensionsv1.JSONSchemaProps{
+														"name":    {Type: "string"},
+														"version": {Type: "string"},
+													},
+													Required: []string{"name", "version"},
+												},
+											},
+										},
+										"relatedObjects": {
+											Type: "array",
+											Items: &apiextensionsv1.JSONSchemaPropsOrArray{
+												Schema: &apiextensionsv1.JSONSchemaProps{
+													Type: "object",
+													Properties: map[string]apiextensionsv1.JSONSchemaProps{
+														"group":     {Type: "string"},
+														"resource":  {Type: "string"},
+														"namespace": {Type: "string"},
+														"name":      {Type: "string"},
+													},
+													Required: []string{"group", "resource", "name"},
+												},
+											},
+										},
+									},
+								},
+							},
+						},
+					},
+					Subresources: &apiextensionsv1.CustomResourceSubresources{
+						Status: &apiextensionsv1.CustomResourceSubresourceStatus{},
+					},
+				},
+			},
+		},
+	}
+}
+
+// newClusterVersionCRD creates a minimal ClusterVersion CRD for testing.
+// This is required because github.com/openshift/api no longer ships individual
+// CRD YAML files in vendor. We create a programmatic CRD with the minimum schema
+// needed for the controller tests to pass.
+func newClusterVersionCRD() *apiextensionsv1.CustomResourceDefinition {
+	return &apiextensionsv1.CustomResourceDefinition{
+		ObjectMeta: metav1.ObjectMeta{
+			Name: "clusterversions.config.openshift.io",
+		},
+		Spec: apiextensionsv1.CustomResourceDefinitionSpec{
+			Group: "config.openshift.io",
+			Names: apiextensionsv1.CustomResourceDefinitionNames{
+				Plural:   "clusterversions",
+				Singular: "clusterversion",
+				Kind:     "ClusterVersion",
+				ListKind: "ClusterVersionList",
+			},
+			Scope: apiextensionsv1.ClusterScoped,
+			Versions: []apiextensionsv1.CustomResourceDefinitionVersion{
+				{
+					Name:    "v1",
+					Served:  true,
+					Storage: true,
+					Schema: &apiextensionsv1.CustomResourceValidation{
+						OpenAPIV3Schema: &apiextensionsv1.JSONSchemaProps{
+							Type:        "object",
+							Description: "ClusterVersion is the configuration for the ClusterVersionOperator",
+							Properties: map[string]apiextensionsv1.JSONSchemaProps{
+								"spec": {
+									Type:        "object",
+									Description: "spec is the desired state",
+									Properties:  map[string]apiextensionsv1.JSONSchemaProps{},
+								},
+								"status": {
+									Type:        "object",
+									Description: "status contains information about the available updates",
+									Properties:  map[string]apiextensionsv1.JSONSchemaProps{},
+								},
+							},
+						},
+					},
+					Subresources: &apiextensionsv1.CustomResourceSubresources{
+						Status: &apiextensionsv1.CustomResourceSubresourceStatus{},
+					},
+				},
+			},
+		},
+	}
+}