🌱 Bump k8s dependencies to v1.36.0 and update tooling#2717
🌱 Bump k8s dependencies to v1.36.0 and update tooling#2717dependabot[bot] wants to merge 4 commits into
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
9b704aa to
d02c464
Compare
d02c464 to
d2bcd24
Compare
5fb8856 to
aaaa412
Compare
aaaa412 to
c916376
Compare
c916376 to
ddc3098
Compare
ddc3098 to
d616a7d
Compare
| k8s.io/api v0.36.0 | ||
| k8s.io/apiextensions-apiserver v0.36.0 | ||
| k8s.io/apimachinery v0.36.0 | ||
| k8s.io/apiserver v0.36.0 | ||
| k8s.io/cli-runtime v0.35.1 |
| sigs.k8s.io/controller-tools v0.21.0 | ||
| sigs.k8s.io/crdify v0.6.0 |
|
/label go-verdiff-override @tmshort I hope we are ok with go upgrade, just learned that downstream go 1.26.3 is available since June 2. |
|
@pedjak: The label(s) `/label go-verdiff-override
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 41 out of 62 changed files in this pull request and generated 2 comments.
Files not reviewed (20)
- api/v1/zz_generated.deepcopy.go: Language not supported
- applyconfigurations/api/v1/assertion.go: Language not supported
- applyconfigurations/api/v1/bundlemetadata.go: Language not supported
- applyconfigurations/api/v1/catalogfilter.go: Language not supported
- applyconfigurations/api/v1/catalogsource.go: Language not supported
- applyconfigurations/api/v1/clustercatalog.go: Language not supported
- applyconfigurations/api/v1/clustercatalogspec.go: Language not supported
- applyconfigurations/api/v1/clustercatalogstatus.go: Language not supported
- applyconfigurations/api/v1/clustercatalogurls.go: Language not supported
- applyconfigurations/api/v1/clusterextension.go: Language not supported
- applyconfigurations/api/v1/clusterextensionconfig.go: Language not supported
- applyconfigurations/api/v1/clusterextensioninstallconfig.go: Language not supported
- applyconfigurations/api/v1/clusterextensioninstallstatus.go: Language not supported
- applyconfigurations/api/v1/clusterextensionspec.go: Language not supported
- applyconfigurations/api/v1/clusterextensionstatus.go: Language not supported
- applyconfigurations/api/v1/clusterobjectset.go: Language not supported
- applyconfigurations/api/v1/clusterobjectsetobject.go: Language not supported
- applyconfigurations/api/v1/clusterobjectsetphase.go: Language not supported
- applyconfigurations/api/v1/clusterobjectsetspec.go: Language not supported
- applyconfigurations/api/v1/clusterobjectsetstatus.go: Language not supported
| k8s.io/apimachinery v0.36.0 | ||
| k8s.io/apiserver v0.36.0 | ||
| k8s.io/cli-runtime v0.36.0 | ||
| k8s.io/client-go v1.5.2 |
There was a problem hiding this comment.
Same as above — this is unchanged from main and is standard k8s module management. The replace block overrides the effective version at build time.
| github.com/opencontainers/go-digest v1.0.0 | ||
| github.com/opencontainers/image-spec v1.1.1 | ||
| github.com/operator-framework/api v0.43.0 | ||
| github.com/operator-framework/api v0.42.0 | ||
| github.com/operator-framework/helm-operator-plugins v0.9.1 | ||
| github.com/operator-framework/operator-registry v1.71.0 | ||
| github.com/operator-framework/operator-registry v1.68.0 | ||
| github.com/prometheus/client_golang v1.23.2 |
|
Why were so many Go APIs added (i.e. failing |
|
Might need to update prometheus. |
3e31a38 to
aa3206d
Compare
Yes, but without real change - just the comment changed. I have fixed that by introducing the logic to detect that and revert the files. |
aa3206d to
e5b061a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 21 out of 27 changed files in this pull request and generated no new comments.
Files not reviewed (5)
- api/v1/zz_generated.deepcopy.go: Language not supported
- applyconfigurations/api/v1/clustercatalog.go: Language not supported
- applyconfigurations/api/v1/clusterextension.go: Language not supported
- applyconfigurations/api/v1/clusterobjectset.go: Language not supported
- applyconfigurations/internal/internal.go: Language not supported
e5b061a to
b0c23db
Compare
It looks like it helped - e2e tests are now green @tmshort |
Bump k8s.io/kubernetes from v1.35.0 to v1.36.0 along with all staging modules (k8s.io/api, k8s.io/apimachinery, k8s.io/client-go, etc.) to v0.36.0. Update controller-runtime from v0.23.3 to v0.24.1 for k8s v1.36 compatibility. Also bumps: - sigs.k8s.io/controller-tools from v0.20.1 to v0.21.0 - sigs.k8s.io/crdify from v0.5.1 to v0.6.0 - Go version from 1.25.7 to 1.26.3 - Bingo pins for controller-gen and crd-diff Regenerated CRD manifests, apply configurations, registryv1 bundle schema, and test golden files. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Predrag Knezevic <pknezevi@redhat.com>
b0c23db to
d793a9b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 24 changed files in this pull request and generated 2 comments.
Files not reviewed (5)
- api/v1/zz_generated.deepcopy.go: Language not supported
- applyconfigurations/api/v1/clustercatalog.go: Language not supported
- applyconfigurations/api/v1/clusterextension.go: Language not supported
- applyconfigurations/api/v1/clusterobjectset.go: Language not supported
- applyconfigurations/internal/internal.go: Language not supported
| func filterVersionAnnotation(s string) string { | ||
| var lines []string | ||
| sc := bufio.NewScanner(strings.NewReader(s)) | ||
| for sc.Scan() { | ||
| if !strings.Contains(sc.Text(), "controller-gen.kubebuilder.io/version") { |
| if kubectl cluster-info &>/dev/null; then | ||
| mkdir -p /tmp/artifacts | ||
| support-bundle --interactive=false -o /tmp/artifacts/support-bundle | ||
| support-bundle --auto-update=false --interactive=false -o /tmp/artifacts/support-bundle test/e2e/support-bundle.yaml |
d793a9b to
5097a7d
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5097a7d to
531a32a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 24 changed files in this pull request and generated 1 comment.
Files not reviewed (5)
- api/v1/zz_generated.deepcopy.go: Language not supported
- applyconfigurations/api/v1/clustercatalog.go: Language not supported
- applyconfigurations/api/v1/clusterextension.go: Language not supported
- applyconfigurations/api/v1/clusterobjectset.go: Language not supported
- applyconfigurations/internal/internal.go: Language not supported
| sc := bufio.NewScanner(strings.NewReader(s)) | ||
| for sc.Scan() { | ||
| if !strings.Contains(sc.Text(), "controller-gen.kubebuilder.io/version") { | ||
| lines = append(lines, sc.Text()) | ||
| } |
Wait for kube-proxy and kindnet daemonset pods to be ready on all nodes before proceeding. This prevents prometheus-operator from hitting API server connectivity timeouts when scheduled on a node where kube-proxy rules haven't fully converged yet. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The default-deny-all-traffic network policy in olmv1-system blocks all egress. The prometheus-operator pod (label app.kubernetes.io/name: prometheus-operator) had no matching allow policy, causing API server connectivity timeouts when scheduled on the second control-plane node. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 25 changed files in this pull request and generated 2 comments.
Files not reviewed (5)
- api/v1/zz_generated.deepcopy.go: Language not supported
- applyconfigurations/api/v1/clustercatalog.go: Language not supported
- applyconfigurations/api/v1/clusterextension.go: Language not supported
- applyconfigurations/api/v1/clusterobjectset.go: Language not supported
- applyconfigurations/internal/internal.go: Language not supported
| kubectl wait --for=condition=Ready pod -n kube-system -l k8s-app=kube-proxy --timeout=2m | ||
| kubectl wait --for=condition=Ready pod -n kube-system -l app=kindnet --timeout=2m |
| sc := bufio.NewScanner(strings.NewReader(s)) | ||
| for sc.Scan() { | ||
| if !strings.Contains(sc.Text(), "controller-gen.kubebuilder.io/version") { | ||
| lines = append(lines, sc.Text()) | ||
| } |
Summary
k8s.io/kubernetesfrom v1.35.0 to v1.36.0 with all staging modules aligned to v0.36.0sigs.k8s.io/controller-runtimefrom v0.23.3 to v0.24.1 (required for k8s v1.36 compatibility)sigs.k8s.io/controller-toolsfrom v0.20.1 to v0.21.0sigs.k8s.io/crdifyfrom v0.5.1 to v0.6.0