-
Notifications
You must be signed in to change notification settings - Fork 68
🌱 Only include ClusterExtensionRevision CRD when Boxcutter enabled #2331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Only include ClusterExtensionRevision CRD when Boxcutter enabled #2331
Conversation
Add a check for the BoxcutterRuntime feature-gate before including the ClusterExtensionRevision CRD into the manifest. Signed-off-by: Todd Short <tshort@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2331 +/- ##
=======================================
Coverage 74.30% 74.30%
=======================================
Files 91 91
Lines 7083 7083
=======================================
Hits 5263 5263
Misses 1405 1405
Partials 415 415
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
perdasilva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve thanks for this!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
anik120
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
c06f27f
into
operator-framework:main
Add a check for the BoxcutterRuntime feature-gate before including the ClusterExtensionRevision CRD into the manifest.
Description
Reviewer Checklist