Skip to content

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Nov 13, 2025

Add a check for the BoxcutterRuntime feature-gate before including the ClusterExtensionRevision CRD into the manifest.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Add a check for the BoxcutterRuntime feature-gate before including the
ClusterExtensionRevision CRD into the manifest.

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort requested a review from a team as a code owner November 13, 2025 14:20
@openshift-ci openshift-ci bot requested review from bentito and joelanford November 13, 2025 14:20
@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit aa629d3
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6915e92594f0e100082aaa10
😎 Deploy Preview https://deploy-preview-2331--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.30%. Comparing base (c95fc24) to head (aa629d3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2331   +/-   ##
=======================================
  Coverage   74.30%   74.30%           
=======================================
  Files          91       91           
  Lines        7083     7083           
=======================================
  Hits         5263     5263           
  Misses       1405     1405           
  Partials      415      415           
Flag Coverage Δ
e2e 45.69% <ø> (+0.04%) ⬆️
experimental-e2e 48.35% <ø> (ø)
unit 58.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve thanks for this!

@openshift-ci
Copy link

openshift-ci bot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2025
Copy link
Member

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit c06f27f into operator-framework:main Nov 13, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants