Skip to content

Commit 9e7f604

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "Remove tenant_id from networking code"
2 parents 8a05cc0 + 2581532 commit 9e7f604

4 files changed

Lines changed: 7 additions & 8 deletions

File tree

openstackclient/network/v2/network_trunk.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,7 @@ def _get_attrs_for_trunk(network_client, identity_client, parsed_args):
392392
parsed_args.project,
393393
parsed_args.project_domain,
394394
).id
395-
attrs['tenant_id'] = project_id
395+
attrs['project_id'] = project_id
396396

397397
return attrs
398398

openstackclient/network/v2/router.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,15 +76,15 @@ def _get_columns(item):
7676
}
7777
if hasattr(item, 'interfaces_info'):
7878
column_map['interfaces_info'] = 'interfaces_info'
79-
invisible_columns = ['location', 'tenant_id']
79+
hidden_columns = ['location', 'tenant_id']
8080
if item.is_ha is None:
81-
invisible_columns.append('is_ha')
81+
hidden_columns.append('is_ha')
8282
column_map.pop('is_ha')
8383
if item.is_distributed is None:
84-
invisible_columns.append('is_distributed')
84+
hidden_columns.append('is_distributed')
8585
column_map.pop('is_distributed')
8686
return utils.get_osc_show_columns_for_sdk_resource(
87-
item, column_map, invisible_columns
87+
item, column_map, hidden_columns
8888
)
8989

9090

openstackclient/network/v2/security_group_rule.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -524,7 +524,6 @@ def take_action_network(self, client, parsed_args):
524524
parsed_args.project,
525525
parsed_args.project_domain,
526526
).id
527-
query['tenant_id'] = project_id
528527
query['project_id'] = project_id
529528

530529
rules = [

openstackclient/tests/unit/network/v2/test_security_group_rule_network.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1265,7 +1265,7 @@ def test_list_with_project(self):
12651265
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
12661266

12671267
columns, data = self.cmd.take_action(parsed_args)
1268-
filters = {'tenant_id': project.id, 'project_id': project.id}
1268+
filters = {'project_id': project.id}
12691269

12701270
self.network_client.security_group_rules.assert_called_once_with(
12711271
**filters
@@ -1291,7 +1291,7 @@ def test_list_with_project_domain(self):
12911291
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
12921292

12931293
columns, data = self.cmd.take_action(parsed_args)
1294-
filters = {'tenant_id': project.id, 'project_id': project.id}
1294+
filters = {'project_id': project.id}
12951295

12961296
self.network_client.security_group_rules.assert_called_once_with(
12971297
**filters

0 commit comments

Comments
 (0)