Skip to content

Commit 8979c00

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "Always resolve domain id"
2 parents ac59673 + c8326b5 commit 8979c00

2 files changed

Lines changed: 27 additions & 3 deletions

File tree

openstackclient/identity/common.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@ def find_group(identity_client, name_or_id, domain_name_or_id=None):
204204
identity_client.groups, name_or_id, groups.Group
205205
)
206206
else:
207+
domain_id = find_domain(identity_client, domain_id).id
207208
return _find_identity_resource(
208209
identity_client.groups,
209210
name_or_id,
@@ -219,6 +220,7 @@ def find_project(identity_client, name_or_id, domain_name_or_id=None):
219220
identity_client.projects, name_or_id, projects.Project
220221
)
221222
else:
223+
domain_id = find_domain(identity_client, domain_id).id
222224
return _find_identity_resource(
223225
identity_client.projects,
224226
name_or_id,
@@ -234,6 +236,7 @@ def find_user(identity_client, name_or_id, domain_name_or_id=None):
234236
identity_client.users, name_or_id, users.User
235237
)
236238
else:
239+
domain_id = find_domain(identity_client, domain_id).id
237240
return _find_identity_resource(
238241
identity_client.users, name_or_id, users.User, domain_id=domain_id
239242
)

openstackclient/identity/v3/role_assignment.py

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,12 +146,19 @@ def take_action(self, parsed_args):
146146
domain_id=role_domain_id,
147147
)
148148

149+
user_domain_id = None
150+
if parsed_args.user_domain:
151+
project_domain_id = _find_sdk_id(
152+
identity_client.find_domain,
153+
name_or_id=parsed_args.user_domain,
154+
)
155+
149156
user_id = None
150157
if parsed_args.user:
151158
user_id = _find_sdk_id(
152159
identity_client.find_user,
153160
name_or_id=parsed_args.user,
154-
domain_id=parsed_args.user_domain,
161+
domain_id=user_domain_id,
155162
)
156163
elif parsed_args.authuser:
157164
if auth_ref:
@@ -171,14 +178,21 @@ def take_action(self, parsed_args):
171178
name_or_id=parsed_args.domain,
172179
)
173180

181+
project_domain_id = None
182+
if parsed_args.project_domain:
183+
project_domain_id = _find_sdk_id(
184+
identity_client.find_domain,
185+
name_or_id=parsed_args.project_domain,
186+
)
187+
174188
project_id = None
175189
if parsed_args.project:
176190
project_id = _find_sdk_id(
177191
identity_client.find_project,
178192
name_or_id=common._get_token_resource(
179193
identity_client, 'project', parsed_args.project
180194
),
181-
domain_id=parsed_args.project_domain,
195+
domain_id=project_domain_id,
182196
)
183197
elif parsed_args.authproject:
184198
if auth_ref:
@@ -187,12 +201,19 @@ def take_action(self, parsed_args):
187201
name_or_id=auth_ref.project_id,
188202
)
189203

204+
group_domain_id = None
205+
if parsed_args.group_domain:
206+
group_domain_id = _find_sdk_id(
207+
identity_client.find_domain,
208+
name_or_id=parsed_args.group_domain,
209+
)
210+
190211
group_id = None
191212
if parsed_args.group:
192213
group_id = _find_sdk_id(
193214
identity_client.find_group,
194215
name_or_id=parsed_args.group,
195-
domain_id=parsed_args.group_domain,
216+
domain_id=group_domain_id,
196217
)
197218

198219
include_names = True if parsed_args.names else None

0 commit comments

Comments
 (0)