typing: Add hints to shell module

Change-Id: If255c37f85a62205a9664c55ede39f3622c8185b
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Author: stephenfin

openstackclient/shell.py

@@ -16,7 +16,9 @@
 
 """Command-line interface to the OpenStack APIs"""
 
+import argparse
 import sys
+from typing import Any
 import warnings
 
 from osc_lib.api import auth
@@ -39,7 +41,7 @@
 class OpenStackShell(shell.OpenStackShell):
     client_manager: clientmanager.ClientManager
 
-    def __init__(self):
+    def __init__(self) -> None:
         command_manager = commandmanager.CommandManager(
             'openstack.cli', ignored_modules=IGNORED_MODULES
         )
@@ -60,15 +62,20 @@ def __init__(self):
         # about them
         warnings.filterwarnings('ignore', module='openstack')
 
-    def build_option_parser(self, description, version, argparse_kwargs=None):
+    def build_option_parser(
+        self,
+        description: str | None,
+        version: str | None,
+        argparse_kwargs: dict[str, Any] | None = None,
+    ) -> argparse.ArgumentParser:
         parser = super().build_option_parser(
             description, version, argparse_kwargs
         )
         parser = clientmanager.build_plugin_option_parser(parser)
         parser = auth.build_auth_plugins_option_parser(parser)
         return parser
 
-    def _final_defaults(self):
+    def _final_defaults(self) -> None:
         super()._final_defaults()
 
         # Set the default plugin to admin_token if endpoint and token are given
@@ -78,7 +85,7 @@ def _final_defaults(self):
         else:
             self._auth_type = 'password'
 
-    def _load_plugins(self):
+    def _load_plugins(self) -> None:
         """Load plugins via stevedore."""
         # Loop through extensions to get API versions
         for mod in clientmanager.PLUGIN_MODULES:
@@ -165,7 +172,7 @@ def _load_plugins(self):
                         },
                     )
 
-    def _load_commands(self):
+    def _load_commands(self) -> None:
         """Load commands via cliff/stevedore
 
         osc-lib has no opinion on what commands should be loaded
@@ -185,7 +192,7 @@ def _load_commands(self):
         # }
         self.command_manager.add_command_group('openstack.extension')
 
-    def initialize_app(self, argv):
+    def initialize_app(self, argv: list[str]) -> None:
         super().initialize_app(argv)
 
         # Re-create the client_manager with our subclass
@@ -196,7 +203,7 @@ def initialize_app(self, argv):
         )
 
 
-def main(argv=None):
+def main(argv: list[str] | None = None) -> int:
     if argv is None:
         argv = sys.argv[1:]