Merge "Fix: Make server resize options required"

Author: Zuul

openstackclient/compute/v2/server.py

@@ -4267,7 +4267,7 @@ def get_parser(self, prog_name):
             metavar='<server>',
             help=_('Server (name or ID)'),
         )
-        phase_group = parser.add_mutually_exclusive_group()
+        phase_group = parser.add_mutually_exclusive_group(required=True)
         phase_group.add_argument(
             '--flavor',
             metavar='<flavor>',

openstackclient/tests/unit/compute/v2/test_server.py

@@ -7896,15 +7896,13 @@ def test_server_resize_no_options(self):
             ('server', self.server.id),
         ]
 
-        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
-        result = self.cmd.take_action(parsed_args)
-
-        self.compute_client.find_server.assert_called_once_with(
-            self.server.id, ignore_missing=False
+        self.assertRaises(
+            test_utils.ParserException,
+            self.check_parser,
+            self.cmd,
+            arglist,
+            verifylist,
         )
-        self.compute_client.find_flavor.assert_not_called()
-        self.compute_client.resize_server.assert_not_called()
-        self.assertIsNone(result)
 
     def test_server_resize(self):
         arglist = [

releasenotes/notes/fix-resize-server-args-required-2e9013bcbf207f6a.yaml

@@ -0,0 +1,8 @@
+---
+fixes:
+  - |
+    The ``openstack server resize`` command now requires the ``--flavor``
+    option or one of the deprecated ``--confirm`` or ``--revert`` options
+    to be provided.
+    Previously, the command would silently exit successfully without
+    performing any action if no option was provided.