Skip to content

Commit 11495e6

Browse files
committed
Don't warn about unsupported version with SDK-based commands
This doesn't make sense: SDK (and the server) will handle this for us. Change-Id: I31b84e09eca0dc2bc5316d6727620346ae519512 Signed-off-by: Stephen Finucane <stephenfin@redhat.com> Closes-bug: #2106760
1 parent 7ecdb69 commit 11495e6

3 files changed

Lines changed: 10 additions & 6 deletions

File tree

openstackclient/compute/client.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,3 +46,8 @@ def build_option_parser(parser):
4646
% DEFAULT_API_VERSION,
4747
)
4848
return parser
49+
50+
51+
def check_api_version(check_version):
52+
# SDK supports auto-negotiation for us: always return True
53+
return True

openstackclient/image/client.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,3 +46,8 @@ def build_option_parser(parser):
4646
% DEFAULT_API_VERSION,
4747
)
4848
return parser
49+
50+
51+
def check_api_version(check_version):
52+
# SDK supports auto-negotiation for us: always return True
53+
return True

openstackclient/network/client.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,6 @@
2727

2828
def make_client(instance):
2929
"""Returns a network proxy"""
30-
# NOTE(dtroyer): As of osc-lib 1.8.0 and OpenStackSDK 0.10.0 the
31-
# old Profile interface and separate client creation
32-
# for each API that uses the SDK is unnecessary. This
33-
# callback remains as a remnant of the original plugin
34-
# interface and to avoid the code churn of changing all
35-
# of the existing references.
3630
LOG.debug(
3731
'Network client initialized using OpenStack SDK: %s',
3832
instance.sdk_connection.network,

0 commit comments

Comments
 (0)