Make --all-stores behave the same as in glanceclient.

In order for python-openstackclient to support image imports to
mutliple stores at the same time an update is needed to the --all-stores
argument used by the client whereby the argument is explicitly set to contain
a boolean value. This change makes the argument do what it's supposed to and
do it in a way consistent with the API contract exposed by Glance.

Amend tests to support the change in type of the --all-stores option.

Change-Id: If5a72ca3ca68656555b5eb478e104d43f419c77e
Closes-Bug: 2138903
Signed-off-by: Piotr Sipika <psipika@bloomberg.net>
Co-authored-by: Stephen Finucane <stephenfin@redhat.com>

Author: psipika

openstackclient/image/v2/image.py

@@ -1719,6 +1719,7 @@ def get_parser(self, prog_name):
         )
         stores_group.add_argument(
             '--all-stores',
+            action='store_true',
             help=_(
                 "Make image available to all stores "
                 "(either '--store' or '--all-stores' required with the "

openstackclient/tests/unit/image/v2/test_image.py

@@ -2085,7 +2085,7 @@ def test_import_image__glance_direct(self):
             remote_image_id=None,
             remote_service_interface=None,
             stores=None,
-            all_stores=None,
+            all_stores=False,
             all_stores_must_succeed=False,
         )
 
@@ -2115,7 +2115,7 @@ def test_import_image__web_download(self):
             remote_image_id=None,
             remote_service_interface=None,
             stores=None,
-            all_stores=None,
+            all_stores=False,
             all_stores_must_succeed=False,
         )
 
@@ -2253,7 +2253,7 @@ def test_import_image__copy_image(self):
             remote_image_id=None,
             remote_service_interface=None,
             stores=['fast'],
-            all_stores=None,
+            all_stores=False,
             all_stores_must_succeed=False,
         )
 
@@ -2285,7 +2285,7 @@ def test_import_image__copy_image_disallow_failure(self):
             remote_image_id=None,
             remote_service_interface=None,
             stores=['fast'],
-            all_stores=None,
+            all_stores=False,
             all_stores_must_succeed=True,
         )
 
@@ -2320,7 +2320,7 @@ def test_import_image__glance_download(self):
             remote_image_id='remote-image-id',
             remote_service_interface='private',
             stores=None,
-            all_stores=None,
+            all_stores=False,
             all_stores_must_succeed=False,
         )
 

releasenotes/notes/bug-2138903-f75c7348f22db195.yaml

@@ -0,0 +1,5 @@
+---
+fixes:
+  - |
+    The ``--all-stores`` of the ``image import`` command is now correctly
+    treated as a boolean flag.