NE-2494: Remove {docs,qe,px}-approved labels from NI&D repositories#80239
NE-2494: Remove {docs,qe,px}-approved labels from NI&D repositories#80239Miciah wants to merge 1 commit into
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@Miciah: This pull request references NE-2494 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (7)
💤 Files with no reviewable changes (7)
WalkthroughThis PR updates Prow Tide query configurations across seven OpenShift repositories ( ChangesProw Tide Configuration Migration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
openshift-merge-bot
Bot
added
the
rehearsals-ack
The no-FF (no-Feature-Freeze) process is no longer used by the
Network Ingress & DNS team. Remove the {docs,qe,px}-approved
labels from Tide merge queries for the team's repositories:
- openshift/aws-load-balancer-operator
- openshift/cluster-dns-operator
- openshift/cluster-ingress-operator
- openshift/coredns
- openshift/external-dns-operator
- openshift/route-controller-manager
- openshift/router
For repositories with dual main/master queries (one requiring the
approval labels, one without), the approval-label query is removed
entirely since it would be a duplicate of the remaining query after
the label removal. For repositories with a single query containing
these labels, the labels are removed from that query.
https://redhat.atlassian.net/browse/NE-2494
Follow-up to 7dcfe39.
Follow-up to f8ef768.
Follow-up to 34b15ab.
Follow-up to 1559bb3.
Follow-up to 1047530.
Follow-up to 5df39a4.
redhat-chai-bot
force-pushed
the
06081632-ne2494-v4
branch
from
f82394b to
e602e42
Compare
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@Miciah: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
The no-FF (no-Feature-Freeze) process is no longer used by the Network Ingress & DNS team. Remove the {docs,qe,px}-approved labels from Tide merge queries for the team's repositories:
For repositories with dual main/master queries (one requiring the approval labels, one without), the approval-label query is removed entirely since it would be a duplicate of the remaining query after the label removal. For repositories with a single query containing these labels, the labels are removed from that query.
Follow-up to #69214, #67715, #34681, #27727, #27247, and #26231.
Summary by CodeRabbit
This PR removes approval label requirements from Prow Tide merge queries for seven Network Ingress & DNS (NI&D) team repositories. The change reflects that these repositories no longer use the no-FF (no-Feature-Freeze) process, which previously required
docs-approved,qe-approved, andpx-approvedlabels for automated merges.Affected Repositories:
Changes to CI merge criteria:
For repositories with dual queries (one requiring approval labels, one without), the approval-label query is removed entirely to avoid duplication. For repositories with single queries containing these labels, the approval labels are stripped out. The merge criteria now rely on standard labels like
approved/lgtmalongside repository-specific requirements (e.g., Jira validation labels).This simplifies the merge automation by removing the additional approval gate that is no longer needed for these teams' workflows.