Skip to content

ROSAENG-8177 | task: Migrate cs-osd-ccs-aws-ad-integration-main#80231

Open
davidleerh wants to merge 1 commit into
openshift:mainfrom
davidleerh:ROSAENG-8177
Open

ROSAENG-8177 | task: Migrate cs-osd-ccs-aws-ad-integration-main#80231
davidleerh wants to merge 1 commit into
openshift:mainfrom
davidleerh:ROSAENG-8177

Conversation

@davidleerh

@davidleerh davidleerh commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

This PR adds a new CI configuration for the OpenShift Online ROSA E2E test suite. Specifically, it creates a ci-operator configuration file for the openshift-online/rosa-e2e repository variant ocm-fvt-osd-aws-integration.

The configuration defines a scheduled periodic integration test (ocm-fvt-periodic-cs-osd-ccs-aws-ad-integration-main) that:

  • Runs daily at 08:00 UTC
  • Tests CS OSD (Cloud Services OpenShift Dedicated) CCS AWS AD (Active Directory) integration
  • Uses nested-podman capabilities with OCP 4.22 nightly releases
  • Includes OCM FVT (Functional Verification Testing) environment configuration targeting the integration environment
  • Sets appropriate resource limits (4Gi memory) and requests (100m CPU, 200Mi memory) for test execution
  • Has a 4-hour timeout window

This migration brings the AWS AD integration testing for ROSA under the managed ci-operator configuration system, enabling standardized Prow job generation and test orchestration for this critical integration test scenario.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e26633e9-b63d-41f1-8fa3-d4c0f4f672c1

📥 Commits

Reviewing files that changed from the base of the PR and between 92a93e9 and 5216e3b.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-osd-aws-integration.yaml

Walkthrough

This pull request introduces a new CI operator configuration file for OpenShift Online's ROSA E2E testing pipeline. The file defines build settings, resource constraints, and a daily-scheduled integration test that validates OCP 4.22 nightly builds using nested-podman and OCM FVT environment variables.

Changes

ROSA E2E Integration Test Setup

Layer / File(s) Summary
OCM FVT CI configuration with scheduled test, build settings, and resource limits
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-osd-aws-integration.yaml
Introduces nested-podman base image configuration, OCP 4.22 nightly release targeting, pod resource requests/limits, a cron-scheduled daily integration test at 08:00 with OCM FVT environment variables, and generated metadata for pipeline tracking.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the specific task (migrate cs-osd-ccs-aws-ad-integration-main) and matches the changeset which adds a ROSA E2E configuration for this integration test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR adds CI configuration files (YAML) and Prow job definitions, not Ginkgo test definitions. The custom check for stable test names is not applicable to this PR.
Test Structure And Quality ✅ Passed PR adds CI configuration YAML files and step registry files, not Ginkgo test code. Test Structure and Quality check is not applicable.
Microshift Test Compatibility ✅ Passed PR adds CI operator YAML config for ROSA testing, not Ginkgo test code. The custom check applies only to new Ginkgo tests, which are not present.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR adds only CI configuration YAML files, not new Ginkgo e2e test code. The check applies only to new Go test code with Ginkgo syntax, which are not present.
Topology-Aware Scheduling Compatibility ✅ Passed PR adds a CI operator configuration file for test jobs, not deployment manifests, operator code, or controllers. No scheduling constraints that assume standard HA topology are introduced.
Ote Binary Stdout Contract ✅ Passed PR adds CI configuration YAML and utility tools, not OTE binary code subject to stdout JSON contract requirements.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds only CI configuration YAML files, not Ginkgo e2e test source code. The custom check applies only when new Ginkgo e2e tests are added; this PR contains no test implementations.
No-Weak-Crypto ✅ Passed PR adds only a YAML CI configuration file with no cryptographic code, weak crypto patterns, custom crypto implementations, or insecure secret comparisons detected.
Container-Privileges ✅ Passed No privileged container configurations, hostPID, hostNetwork, hostIPC, SYS_ADMIN capabilities, or allowPrivilegeEscalation settings found in the added CI configuration files.
No-Sensitive-Data-In-Logs ✅ Passed The new CI configuration file contains no passwords, tokens, API keys, PII, session IDs, internal hostnames, or customer data. Only standard CI metadata and test configuration parameters are present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from bmeng and dustman9000 June 8, 2026 15:22
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@davidleerh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-osd-aws-integration-ocm-fvt-periodic-cs-osd-ccs-aws-ad-integration-main N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@davidleerh

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-osd-aws-integration-ocm-fvt-periodic-cs-osd-ccs-aws-ad-integration-main

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@davidleerh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@davidleerh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jfrazierRedHat

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2026
@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidleerh, jfrazierRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants