mongo something stable (#2013)

Remove local must-gather directory and build process in favor of using the
external quay.io/konveyor/oadp-must-gather:latest image via oc adm must-gather.
This eliminates architecture mismatch issues and keeps must-gather code in its
dedicated repository.

Changes:
- Updated RunMustGather() in tests/e2e/lib/apps.go to use oc adm must-gather
- Added MUST_GATHER_IMAGE env var (defaults to quay.io/konveyor/oadp-must-gather:latest)
- Removed build-must-gather target from Makefile
- Removed entire must-gather/ directory (3,174 lines deleted)
- Updated documentation in TESTING.md

The SKIP_MUST_GATHER flag is preserved for skipping must-gather collection.
Version-specific images can be used by setting MUST_GATHER_IMAGE env var.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Revert "refactor(e2e): migrate to external oadp-must-gather container image"

This reverts commit 09a2a49.

Revert "fix(e2e): derive must-gather directory pattern from image name"

This reverts commit 2ae6d45.

fix(e2e): update mongo image version and resource limits in mongo-persistent deployment

fix(e2e): update mongo image version and resource limits in mongo-persistent deployment

fix(e2e): derive must-gather directory pattern from image name

The directory pattern was hardcoded to 'quay-io-konveyor-oadp-must-gather-*'
which breaks when using custom images via MUST_GATHER_IMAGE env var.

Now dynamically derives the pattern from the actual image name by replacing
registry separators (. / :) with hyphens to match oc adm must-gather's
directory naming convention.

Examples:
- quay.io/konveyor/oadp-must-gather:latest -> quay-io-konveyor-oadp-must-gather-latest-*
- docker.io/myuser/custom:v1 -> docker-io-myuser-custom-v1-*

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude <noreply@anthropic.com>

Author: kaovilai

tests/e2e/sample-applications/mongo-persistent/mongo-persistent-block.yaml

@@ -71,7 +71,7 @@ items:
           # Used to format the block device (put filesystem on it).
           # This allows Mongo to use the filesystem which lives on block device.
           initContainers:
-            - image: docker.io/library/mongo:latest
+            - image: docker.io/library/mongo:7.0
               imagePullPolicy: IfNotPresent
               securityContext:
                 privileged: true
@@ -102,7 +102,7 @@ items:
                 - name: block-volume-pv
                   devicePath: /dev/xvdx
           containers:
-            - image: docker.io/library/mongo:latest
+            - image: docker.io/library/mongo:7.0
               name: mongo
               securityContext:
                 privileged: true
@@ -117,8 +117,10 @@ items:
                 - containerPort: 27017
                   name: mongo
               resources:
-                limits:
+                requests:
                   memory: 512Mi
+                limits:
+                  memory: 1Gi
               command:
                 - "sh"
                 - "-c"
@@ -131,23 +133,38 @@ items:
               volumeDevices:
                 - name:  block-volume-pv
                   devicePath: /dev/xvdx
-              livenessProbe:
-                tcpSocket:
-                  port: mongo
-                initialDelaySeconds: 5
+              readinessProbe:
+                exec:
+                  command:
+                  - /bin/bash
+                  - -c
+                  - "mongosh --eval 'db.runCommand(\"ping\")' --quiet"
+                initialDelaySeconds: 30
                 periodSeconds: 10
+                timeoutSeconds: 5
+                failureThreshold: 3
+              livenessProbe:
+                exec:
+                  command:
+                  - /bin/bash
+                  - -c
+                  - "mongosh --eval 'db.runCommand(\"ping\")' --quiet"
+                initialDelaySeconds: 60
+                periodSeconds: 30
+                timeoutSeconds: 10
+                failureThreshold: 3
               startupProbe:
                 exec:
                   command:
                   - bash
                   - -c
                   - |
                     mongosh admin --authenticationDatabase admin -u "$MONGO_INITDB_ROOT_USERNAME" -p "$MONGO_INITDB_ROOT_PASSWORD" --eval 'db.adminCommand("ping")'
-                initialDelaySeconds: 5
-                periodSeconds: 30
-                timeoutSeconds: 2
+                initialDelaySeconds: 10
+                periodSeconds: 10
+                timeoutSeconds: 5
                 successThreshold: 1
-                failureThreshold: 40 # 40x30sec before restart pod
+                failureThreshold: 12 # 12x10sec = 2min before restart pod
             - image: docker.io/curlimages/curl:8.5.0
               name: curl-tool
               command: ["/bin/sleep", "infinity"]

tests/e2e/sample-applications/mongo-persistent/mongo-persistent-csi.yaml

@@ -67,7 +67,7 @@ items:
         spec:
           serviceAccountName: mongo-persistent-sa
           containers:
-          - image: docker.io/library/mongo:latest
+          - image: docker.io/library/mongo:7.0
             imagePullPolicy: IfNotPresent
             name: mongo
             securityContext:
@@ -83,28 +83,45 @@ items:
             - containerPort: 27017
               name: mongo
             resources:
-              limits:
+              requests:
                 memory: 512Mi
+              limits:
+                memory: 1Gi
             volumeMounts:
             - name: mongo-data
               mountPath: /data/db
-            livenessProbe:
-              tcpSocket:
-                port: mongo
-              initialDelaySeconds: 5
+            readinessProbe:
+              exec:
+                command:
+                - /bin/bash
+                - -c
+                - "mongosh --eval 'db.runCommand(\"ping\")' --quiet"
+              initialDelaySeconds: 30
               periodSeconds: 10
+              timeoutSeconds: 5
+              failureThreshold: 3
+            livenessProbe:
+              exec:
+                command:
+                - /bin/bash
+                - -c
+                - "mongosh --eval 'db.runCommand(\"ping\")' --quiet"
+              initialDelaySeconds: 60
+              periodSeconds: 30
+              timeoutSeconds: 10
+              failureThreshold: 3
             startupProbe:
               exec:
                 command:
                 - bash
                 - -c
                 - |
                   mongosh admin --authenticationDatabase admin -u "$MONGO_INITDB_ROOT_USERNAME" -p "$MONGO_INITDB_ROOT_PASSWORD" --eval 'db.adminCommand("ping")'
-              initialDelaySeconds: 5
-              periodSeconds: 30
-              timeoutSeconds: 2
+              initialDelaySeconds: 10
+              periodSeconds: 10
+              timeoutSeconds: 5
               successThreshold: 1
-              failureThreshold: 40 # 40x30sec before restart pod
+              failureThreshold: 12 # 12x10sec = 2min before restart pod
           - image: docker.io/curlimages/curl:8.5.0
             name: curl-tool
             command: ["/bin/sleep", "infinity"]

tests/e2e/sample-applications/mongo-persistent/mongo-persistent.yaml

@@ -80,7 +80,7 @@ items:
         spec:
           serviceAccountName: mongo-persistent-sa
           containers:
-          - image: docker.io/library/mongo:latest
+          - image: docker.io/library/mongo:7.0
             imagePullPolicy: IfNotPresent
             name: mongo
             securityContext:
@@ -96,28 +96,45 @@ items:
             - containerPort: 27017
               name: mongo
             resources:
-              limits:
+              requests:
                 memory: 512Mi
+              limits:
+                memory: 1Gi
             volumeMounts:
             - name: mongo-data
               mountPath: /data/db
-            livenessProbe:
-              tcpSocket:
-                port: mongo
-              initialDelaySeconds: 5
+            readinessProbe:
+              exec:
+                command:
+                - /bin/bash
+                - -c
+                - "mongosh --eval 'db.runCommand(\"ping\")' --quiet"
+              initialDelaySeconds: 30
               periodSeconds: 10
+              timeoutSeconds: 5
+              failureThreshold: 3
+            livenessProbe:
+              exec:
+                command:
+                - /bin/bash
+                - -c
+                - "mongosh --eval 'db.runCommand(\"ping\")' --quiet"
+              initialDelaySeconds: 60
+              periodSeconds: 30
+              timeoutSeconds: 10
+              failureThreshold: 3
             startupProbe:
               exec:
                 command:
                 - bash
                 - -c
                 - |
                   mongosh admin --authenticationDatabase admin -u "$MONGO_INITDB_ROOT_USERNAME" -p "$MONGO_INITDB_ROOT_PASSWORD" --eval 'db.adminCommand("ping")'
-              initialDelaySeconds: 5
-              periodSeconds: 30
-              timeoutSeconds: 2
+              initialDelaySeconds: 10
+              periodSeconds: 10
+              timeoutSeconds: 5
               successThreshold: 1
-              failureThreshold: 40 # 40x30sec before restart pod
+              failureThreshold: 12 # 12x10sec = 2min before restart pod
           - image: docker.io/curlimages/curl:8.5.0
             name: curl-tool
             command: ["/bin/sleep", "infinity"]