Automatic merge of T1.5.1-689-g9d41208f0 and 18 pull requests

- Pull request #570 at c59c788: Experimental glTF 2.0 support with PBR lighting
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #865 at 67014b7: Dispatcher window improvements
- Pull request #874 at f8dbeab: Dynamic brake controller refactoring
- Pull request #875 at 43bf33e: Bug fix for https://bugs.launchpad.net/or/+bug/2036346 Player train switching doesn't work with 3D cabs
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #878 at a088cf7: Implement Polach Adhesion
- Pull request #882 at 753b622: Blueprint/train car operations UI window
- Pull request #883 at edcc2dd: SwitchPanel disconnect/connect handling
- Pull request #885 at c81447b: feat: Add notifications to Menu
- Pull request #886 at 34e8cae: Scene viewer extension to TrackViewer
- Pull request #888 at d7daf62: docs: Document player application model
- Pull request #890 at 39a9fa4: Allow depart early
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #893 at bf8876b: Signal errors
- Pull request #894 at 794fddf: Correct Decrease Colour
- Pull request #896 at 5866028: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #897 at 64a29c8: feat: Improved system information collection

Author: openrails-bot

Source/Orts.Formats.Msts/SignalConfigurationFile.cs

@@ -1052,8 +1052,6 @@ public class SignalAspect
         public float SpeedMpS { get; private set; }
         /// <summary>Set to true if SignalFlags ASAP option specified, meaning train needs to go to speed As Soon As Possible</summary>
         public bool Asap { get; private set; }
-        /// <summary>Set to true if SignalFlags NoSpeedUpdate option specified, meaning speed limits are not in any way affected by the state of this signal>
-        public bool NoSpeedUpdate { get; private set; }
         /// <summary>Set to true if SignalFlags RESET option specified (ORTS only)</summary>
         public bool Reset; 
         /// <summary>Set to true if no speed reduction is required for RESTRICTED or STOP_AND_PROCEED aspects (ORTS only) </summary>
@@ -1070,7 +1068,6 @@ public SignalAspect(MstsSignalAspect reqAspect, string reqName)
             DrawStateName = String.Copy(reqName);
             SpeedMpS = -1;
             Asap = false;
-            NoSpeedUpdate = false;
             NoSpeedReduction = false;
         }
 
@@ -1102,7 +1099,6 @@ public SignalAspect(STFReader stf)
                         switch (stf.ReadString().ToLower())
                         {
                             case "asap": Asap = true; break;
-                            case "or_nospeedupdate": NoSpeedUpdate = true; break;
                             case "or_speedreset": Reset = true; break;
                             case "or_nospeedreduction": NoSpeedReduction = true; break;
                             default: stf.StepBackOneItem(); STFException.TraceInformation(stf, "Skipped unknown DrawLight flag " + stf.ReadString()); break;

Source/Orts.Simulation/Simulation/AIs/AITrain.cs

@@ -6846,7 +6846,6 @@ public static ObjectItemInfo RestoreActiveItem(BinaryReader inf, Signals signalR
             thisInfo.speed_passenger = inf.ReadSingle();
             thisInfo.speed_freight = inf.ReadSingle();
             thisInfo.speed_flag = inf.ReadInt32();
-            thisInfo.no_speedUpdate = inf.ReadInt32();
             thisInfo.actual_speed = inf.ReadSingle();
 
             thisInfo.processed = inf.ReadBoolean();
@@ -6898,7 +6897,6 @@ public static void SaveActiveItem(BinaryWriter outf, ObjectItemInfo ActiveItem)
             outf.Write(ActiveItem.speed_passenger);
             outf.Write(ActiveItem.speed_freight);
             outf.Write(ActiveItem.speed_flag);
-            outf.Write(ActiveItem.no_speedUpdate);
             outf.Write(ActiveItem.actual_speed);
 
             outf.Write(ActiveItem.processed);

Source/Orts.Simulation/Simulation/Physics/Train.cs

@@ -3514,7 +3514,6 @@ public void UpdateSignalState(int backward)
                         firstObject.speed_passenger = thisSpeed?.speed_pass ?? -1;
                         firstObject.speed_freight = thisSpeed?.speed_freight ?? -1;
                         firstObject.speed_flag = thisSpeed?.speed_flag ?? 0;
-                        firstObject.no_speedUpdate = thisSpeed?.no_speedUpdate ?? 0;
                         firstObject.speed_reset = thisSpeed?.speed_reset ?? 0;
                         break;
 
@@ -3525,7 +3524,6 @@ public void UpdateSignalState(int backward)
                         firstObject.speed_freight = thisSpeed?.speed_freight ?? -1;
                         firstObject.speed_flag = thisSpeed?.speed_flag ?? 0;
                         firstObject.speed_reset = thisSpeed?.speed_reset ?? 0;
-                        firstObject.no_speedUpdate = thisSpeed?.no_speedUpdate ?? 0;
                         firstObject.speed_noSpeedReductionOrIsTempSpeedReduction = thisSpeed?.speed_noSpeedReductionOrIsTempSpeedReduction ?? 0;
                         firstObject.speed_isWarning = thisSpeed?.speed_isWarning ?? false;
                         break;
@@ -3555,15 +3553,13 @@ public void UpdateSignalState(int backward)
                                 nextObject.speed_passenger = -1;
                                 nextObject.speed_freight = -1;
                                 nextObject.speed_flag = 0;
-                                nextObject.no_speedUpdate = 0;
                                 nextObject.speed_reset = 0;
                             }
                             else
                             {
                                 nextObject.speed_passenger = thisSpeed?.speed_pass ?? -1;
                                 nextObject.speed_freight = thisSpeed?.speed_freight ?? -1;
                                 nextObject.speed_flag = thisSpeed?.speed_flag ?? 0;
-                                nextObject.no_speedUpdate = thisSpeed?.no_speedUpdate ?? 0;
                                 nextObject.speed_reset = thisSpeed?.speed_reset ?? 0;
                             }
                             break;
@@ -3574,7 +3570,6 @@ public void UpdateSignalState(int backward)
                             nextObject.speed_passenger = thisSpeed?.speed_pass ?? -1;
                             nextObject.speed_freight = thisSpeed?.speed_freight ?? -1;
                             nextObject.speed_flag = thisSpeed?.speed_flag ?? 0;
-                            nextObject.no_speedUpdate = thisSpeed?.no_speedUpdate ?? 0;
                             nextObject.speed_reset = thisSpeed?.speed_reset ?? 0;
                             nextObject.speed_noSpeedReductionOrIsTempSpeedReduction = thisSpeed?.speed_noSpeedReductionOrIsTempSpeedReduction ?? 0;
                             nextObject.speed_isWarning = thisSpeed?.speed_isWarning ?? false;
@@ -3650,7 +3645,6 @@ public void UpdateSignalState(int backward)
                                 nextObject.speed_passenger = thisSpeed?.speed_pass ?? -1;
                                 nextObject.speed_freight = thisSpeed?.speed_freight ?? -1;
                                 nextObject.speed_flag = thisSpeed?.speed_flag ?? 0;
-                                nextObject.no_speedUpdate = thisSpeed?.no_speedUpdate ?? 0;
                                 nextObject.speed_reset = thisSpeed?.speed_reset ?? 0;
                                 break;
 
@@ -3660,7 +3654,6 @@ public void UpdateSignalState(int backward)
                                 nextObject.speed_passenger = thisSpeed?.speed_pass ?? -1;
                                 nextObject.speed_freight = thisSpeed?.speed_freight ?? -1;
                                 nextObject.speed_flag = thisSpeed?.speed_flag ?? 0;
-                                nextObject.no_speedUpdate = thisSpeed?.no_speedUpdate ?? 0;
                                 nextObject.speed_reset = thisSpeed?.speed_reset ?? 0;
                                 nextObject.speed_noSpeedReductionOrIsTempSpeedReduction = thisSpeed?.speed_noSpeedReductionOrIsTempSpeedReduction ?? 0;
                                 nextObject.speed_isWarning = thisSpeed?.speed_isWarning ?? false;
@@ -3828,7 +3821,7 @@ public void UpdateSpeedInfo()
 #endif
                         }
                     }
-                    else if (thisObject.no_speedUpdate == 1)
+                    else
                     {
                         validSpeedSignalMpS = TrainMaxSpeedMpS;
                         float newSpeedMpS = Math.Min(validSpeedSignalMpS, Math.Min(validSpeedLimitMpS, validTempSpeedLimitMpS));

Source/Orts.Simulation/Simulation/Signalling/ObjectItemInfo.cs

@@ -57,7 +57,6 @@ public enum ObjectItemFindState
         public int speed_reset;
         // for signals: if = 1 no speed reduction; for speedposts: if = 0 standard; = 1 start of temp speedreduction post; = 2 end of temp speed reduction post
         public int speed_noSpeedReductionOrIsTempSpeedReduction;
-        public int no_speedUpdate;
         public bool speed_isWarning;
         public float actual_speed;                   // set active by TRAIN
 
@@ -79,7 +78,6 @@ public ObjectItemInfo(SignalObject thisObject, float distance)
                 speed_passenger = -1;                      // set active by TRAIN
                 speed_freight = -1;                      // set active by TRAIN
                 speed_flag = 0;                       // set active by TRAIN
-                no_speedUpdate = 0;                     // set active by TRAIN 
                 speed_reset = 0;                      // set active by TRAIN
                 speed_noSpeedReductionOrIsTempSpeedReduction = 0;
             }
@@ -91,7 +89,6 @@ public ObjectItemInfo(SignalObject thisObject, float distance)
                 speed_passenger = speed_info.speed_pass;
                 speed_freight = speed_info.speed_freight;
                 speed_flag = speed_info.speed_flag;
-                no_speedUpdate = speed_info.no_speedUpdate;
                 speed_reset = speed_info.speed_reset;
                 speed_noSpeedReductionOrIsTempSpeedReduction = speed_info.speed_noSpeedReductionOrIsTempSpeedReduction;
                 speed_isWarning = speed_info.speed_isWarning;

Source/Orts.Simulation/Simulation/Signalling/ObjectSpeedInfo.cs

@@ -22,18 +22,16 @@ public class ObjectSpeedInfo
         public float speed_pass;
         public float speed_freight;
         public int speed_flag;
-        public int no_speedUpdate;
         public int speed_reset;
         public int speed_noSpeedReductionOrIsTempSpeedReduction;
         public bool speed_isWarning;
 
-        public ObjectSpeedInfo(float pass, float freight, bool asap, bool reset, int nospeedreductionOristempspeedreduction, bool isWarning, bool nospeedupdate = false)
+        public ObjectSpeedInfo(float pass, float freight, bool asap, bool reset, int nospeedreductionOristempspeedreduction, bool isWarning)
         {
             speed_pass = pass;
             speed_freight = freight;
             speed_flag = asap ? 1 : 0;
             speed_reset = reset ? 1 : 0;
-            no_speedUpdate = nospeedupdate ? 1 : 0;
             speed_noSpeedReductionOrIsTempSpeedReduction = nospeedreductionOristempspeedreduction;
             speed_isWarning = isWarning;
         }

Source/Orts.Simulation/Simulation/Signalling/SignalHead.cs

@@ -99,8 +99,7 @@ public SignalHead(SignalObject sigObject, int trItem, int TDBRef, SpeedPostItem
 
             float passSpeed = speedItem.IsPassenger ? speedMpS : -1;
             float freightSpeed = speedItem.IsFreight ? speedMpS : -1;
-            ObjectSpeedInfo speedinfo = new ObjectSpeedInfo(passSpeed, freightSpeed, false, false, speedItem is TempSpeedPostItem ? (speedMpS == 999f ? 2 : 1) : 0,
-                                  speedItem.IsWarning);
+            ObjectSpeedInfo speedinfo = new ObjectSpeedInfo(passSpeed, freightSpeed, false, false, speedItem is TempSpeedPostItem ? (speedMpS == 999f ? 2 : 1) : 0, speedItem.IsWarning);
             speed_info[(int)state] = speedinfo;
         }
 
@@ -129,8 +128,7 @@ public void SetSignalType(TrItem[] TrItems, SignalConfigurationFile sigCFG)
                     foreach (SignalAspect thisAspect in signalType.Aspects)
                     {
                         int arrindex = (int)thisAspect.Aspect;
-                        speed_info[arrindex] = new ObjectSpeedInfo(thisAspect.SpeedMpS, thisAspect.SpeedMpS, thisAspect.Asap, thisAspect.Reset, 
-                            thisAspect.NoSpeedReduction ? 1 : 0, false, thisAspect.NoSpeedUpdate);
+                        speed_info[arrindex] = new ObjectSpeedInfo(thisAspect.SpeedMpS, thisAspect.SpeedMpS, thisAspect.Asap, thisAspect.Reset, thisAspect.NoSpeedReduction ? 1 : 0, false);
                     }
 
                     // set normal subtype