Automatic merge of T1.5.1-722-g01614a154 and 18 pull requests

- Pull request #570 at 7a89d90: Experimental glTF 2.0 support with PBR lighting
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #865 at 3b5a2fe: Dispatcher window improvements
- Pull request #874 at f8dbeab: Dynamic brake controller refactoring
- Pull request #875 at 43bf33e: Bug fix for https://bugs.launchpad.net/or/+bug/2036346 Player train switching doesn't work with 3D cabs
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #882 at 481ed9d: Blueprint/train car operations UI window
- Pull request #885 at c81447b: feat: Add notifications to Menu
- Pull request #886 at 697a4b6: Scene viewer extension to TrackViewer
- Pull request #888 at d7daf62: docs: Document player application model
- Pull request #890 at 39a9fa4: Allow depart early
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #893 at bf8876b: Signal errors
- Pull request #894 at 794fddf: Correct Decrease Colour
- Pull request #896 at 5866028: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #897 at 0a9d939: feat: Improved system information collection
- Pull request #898 at e271395: Extra line with all the arguments for debugging purposes in logfile
- Pull request #900 at 42ea7ad: DMI updates

Author: openrails-bot

Source/RunActivity/Viewer3D/GltfShape.cs

@@ -711,7 +711,13 @@ internal Stream GetBufferView(int? bufferViewNumber, int accessorByteOffset, out
                 return stream;
             }
 
-            internal int GetSizeInBytes(Accessor accessor) => GetComponentNumber(accessor.Type) * GetComponentSizeInBytes(accessor.ComponentType);
+            internal int GetSizeInBytes(Accessor accessor)
+            {
+                var componentNumber = GetComponentNumber(accessor.Type);
+                var size = componentNumber * GetComponentSizeInBytes(accessor.ComponentType);
+                var padding = componentNumber == 1 ? 0 : size % 4; // do not add padding to the index buffers
+                return size + padding;
+            }
 
             int GetComponentNumber(Accessor.TypeEnum type)
             {
@@ -773,6 +779,7 @@ VertexElementFormat GetVertexElementFormat(Accessor accessor, bool msfsFlavoured
                     case Accessor.TypeEnum.VEC4 when accessor.ComponentType == Accessor.ComponentTypeEnum.FLOAT: return VertexElementFormat.Vector4;
 
                     // MSFS twisted out, reversed definitions:
+                    // non-normalized, VEC3 FLOAT, VEC4 BYTE, VEC2 SHORT, VEC4 USHORT, SCALAR FLOAT
                     case Accessor.TypeEnum.VEC2 when accessor.ComponentType == Accessor.ComponentTypeEnum.SHORT && msfsFlavoured: return accessor.Normalized ? VertexElementFormat.Short2 : VertexElementFormat.HalfVector2;
                     case Accessor.TypeEnum.VEC2 when accessor.ComponentType == Accessor.ComponentTypeEnum.UNSIGNED_SHORT && msfsFlavoured: return accessor.Normalized ? VertexElementFormat.Short2 : VertexElementFormat.HalfVector2;
                     case Accessor.TypeEnum.VEC4 when accessor.ComponentType == Accessor.ComponentTypeEnum.BYTE && msfsFlavoured: return VertexElementFormat.Color;

Source/RunActivity/Viewer3D/RenderFrame.cs

@@ -390,7 +390,7 @@ public class RenderFrame
         static readonly Vector3 MoonGlow = new Vector3(245f / 255f, 243f / 255f, 206f / 255f);
         const float SunIntensity = 1;
         const float MoonIntensity = SunIntensity / 380000;
-        float HeadLightIntensity = 50000; // Can be 10 in case of linear calculation method
+        float HeadLightIntensity = 25000; // See some sample values: https://docs.unity3d.com/Packages/com.unity.cloud.gltfast@5.2/manual/LightUnits.html
 
         // Local shadow map data.
         Matrix[] ShadowMapLightView;
@@ -589,6 +589,11 @@ public void PrepareFrame(Viewer viewer)
                     }
                     lastLightState = lightState;
                 }
+                else
+                {
+                    fadeStartTimer = 0;
+                    fadeDuration = 0;
+                }
                 if (SolarDirection.Y <= -0.05)
                 {
                     clampValue = 1; // at nighttime max headlight