Fix: BrakeHose not sync when coupling cars

Author: mbm-OR

Source/RunActivity/Content/TrainOperations/TrainOperationsMap32.png

@@ -75,6 +75,7 @@ public class TrainCarOperationsViewerWindow : Window
         internal static Texture2D RearAngleCockPartial;
         internal static Texture2D ResetBrakesOff;
         internal static Texture2D ResetBrakesOn;
+        internal static Texture2D ResetBrakesWarning;
 
         public List<bool> AngleCockAPartiallyOpened = new List<bool>();
         public List<bool> AngleCockBPartiallyOpened = new List<bool>();
@@ -85,6 +86,8 @@ public class TrainCarOperationsViewerWindow : Window
         public int RowsCount;
         public int SpacerRowCount;
         public int SymbolsRowCount;
+        public bool BrakeHoseCarCoupling;
+
         const int SymbolWidth = 32;
         public static bool FontChanged;
         public static bool FontToBold;
@@ -231,6 +234,7 @@ protected internal override void Initialize()
 
                 Rectangle ResetBrakesOffRect = new Rectangle(64, 256, 32, 32);
                 Rectangle ResetBrakesOnRect = new Rectangle(96, 256, 32, 32);
+                Rectangle ResetBrakesWarningRect = new Rectangle(96, 32, 32, 32);
 
                 var GraphicsDeviceRender = Owner.Viewer.RenderProcess.GraphicsDevice;
                 var TrainOperationsPath = System.IO.Path.Combine(Owner.Viewer.ContentPath, "TrainOperations\\TrainOperationsMap32.png");
@@ -280,6 +284,7 @@ protected internal override void Initialize()
 
                 ResetBrakesOff = SharedTextureManager.Get(GraphicsDeviceRender, TrainOperationsPath, ResetBrakesOffRect);
                 ResetBrakesOn = SharedTextureManager.Get(GraphicsDeviceRender, TrainOperationsPath, ResetBrakesOnRect);
+                ResetBrakesWarning = SharedTextureManager.Get(GraphicsDeviceRender, TrainOperationsPath, ResetBrakesWarningRect);
 
                 PowerOn = SharedTextureManager.Get(GraphicsDeviceRender, TrainOperationsPath, PowerOnRect);
                 PowerOff = SharedTextureManager.Get(GraphicsDeviceRender, TrainOperationsPath, PowerOffRect);
@@ -638,7 +643,7 @@ public buttonInitializeBrakes(int x, int y, int size, Viewer viewer, int carPosi
                 Viewer = viewer;
                 TrainCarViewer = Viewer.TrainCarOperationsViewerWindow;
                 WarningCars = warningCars;
-                Texture = WarningCars > 2 ? ResetBrakesOn : ResetBrakesOff;
+                Texture = WarningCars > 2 ? ResetBrakesOn : WarningCars > 0 && WarningCars < 3 ? ResetBrakesWarning : ResetBrakesOff;
                 Source = new Rectangle(0, 0, size, size);
                 Click += new Action<Control, Point>(buttonInitializeBrakes_Click);
             }
@@ -815,7 +820,6 @@ class buttonFrontAngleCock : Image
             readonly TrainCarOperationsViewerWindow TrainCarViewer;
             readonly int CarPosition;
             readonly bool First;
-            readonly float carAngleCockAOpenAmount;
             public buttonFrontAngleCock(int x, int y, int size, Viewer viewer, TrainCar car, int carPosition)
                 : base(x, y, size, size)
             {

Source/RunActivity/Viewer3D/Popups/TrainCarOperationsViewerWindow.cs

@@ -83,6 +83,7 @@ public class TrainCarOperationsWindow : Window
         public int SeparatorCount;
         public int SpacerRowCount;
         public int SymbolsRowCount;
+        public bool BrakeHoseCarCoupling;
 
         public ControlLayout Client;
         public bool CarPositionChanged;
@@ -499,6 +500,8 @@ void AddSpace()
                     // Allows to resize the window according to the carPosition value.
                     if (RowsCount > carPosition) RowsCount = carPosition;
                     if (SeparatorCount > carPosition -1) SeparatorCount = carPosition - 1;
+
+                    BrakeHoseCarCoupling = false;// All brake hoses checked
                 }
             }
             return Vbox;
@@ -603,14 +606,11 @@ public override void PrepareFrame(ElapsedTime elapsedTime, bool updateFull)
                     PlayerTrain = Owner.Viewer.PlayerTrain;
                     if (LastPlayerTrainCars != Owner.Viewer.PlayerTrain.Cars.Count || !LayoutUpdated)
                     {
-                        // Updates BrakeHoses
+                        // Updates brake hoses
                         if (LastPlayerTrainCars > 0 && PlayerTrain.Cars.Count > LastPlayerTrainCars && ((PlayerTrain.Cars[LastPlayerTrainCars] as MSTSWagon).BrakeSystem.FrontBrakeHoseConnected != (PlayerTrain.Cars[LastPlayerTrainCars - 1] as MSTSWagon).BrakeSystem.RearBrakeHoseConnected))
                         {
-                            // When coupling cars. The front brake hose of the new car is unconnected, the brake hose of the previous car must also be unconnected.
-                            new WagonBrakeHoseRearConnectCommand(Owner.Viewer.Log, (PlayerTrain.Cars[LastPlayerTrainCars - 1] as MSTSWagon), !(PlayerTrain.Cars[LastPlayerTrainCars - 1] as MSTSWagon).BrakeSystem.RearBrakeHoseConnected);
-                            new WagonBrakeHoseRearConnectCommand(Owner.Viewer.Log, (PlayerTrain.Cars[LastPlayerTrainCars] as MSTSWagon), !(PlayerTrain.Cars[LastPlayerTrainCars] as MSTSWagon).BrakeSystem.FrontBrakeHoseConnected);
+                            BrakeHoseCarCoupling = true;// Enable to check all brake hoses when coupling cars
                         }
-
                         LayoutUpdated = true;
                         Layout();
                         localScrollLayout(SelectedCarPosition);
@@ -837,6 +837,7 @@ class buttonFrontBrakeHose : Image
     {
         readonly Viewer Viewer;
         readonly TrainCarOperationsViewerWindow TrainCarViewer;
+        readonly TrainCarOperationsWindow TrainCarOperations;
         readonly CarOperationsWindow CarOperations;
         readonly int CarPosition;
         readonly bool First;
@@ -845,10 +846,25 @@ public buttonFrontBrakeHose(int x, int y, int size, Viewer viewer, TrainCar car,
         {
             Viewer = viewer;
             TrainCarViewer = Viewer.TrainCarOperationsViewerWindow;
+            TrainCarOperations = Viewer.TrainCarOperationsWindow;
             CarOperations = Viewer.CarOperationsWindow;
+            var PlayerTrain = Viewer.PlayerTrain;
 
             CarPosition = carPosition;
             First = car == viewer.PlayerTrain.Cars.First();
+            if (CarPosition > 0 && TrainCarOperations.BrakeHoseCarCoupling)
+            {   // Sometimes when coupling cars. The front brake hose of the new car and the brake hose of the previous car are not synchronised.
+                var frontBrakeHoseCurrentCar = (PlayerTrain.Cars[CarPosition] as MSTSWagon).BrakeSystem.FrontBrakeHoseConnected;
+                var rearBrakeHosePreviousCar = (PlayerTrain.Cars[CarPosition - 1] as MSTSWagon).BrakeSystem.RearBrakeHoseConnected;
+                if (frontBrakeHoseCurrentCar && !rearBrakeHosePreviousCar)
+                {
+                    new WagonBrakeHoseConnectCommand(Viewer.Log, (PlayerTrain.Cars[CarPosition] as MSTSWagon), !(PlayerTrain.Cars[CarPosition] as MSTSWagon).BrakeSystem.FrontBrakeHoseConnected);
+                }
+                else if (!frontBrakeHoseCurrentCar && rearBrakeHosePreviousCar)
+                {
+                    new WagonBrakeHoseRearConnectCommand(Viewer.Log, (PlayerTrain.Cars[CarPosition - 1] as MSTSWagon), !(PlayerTrain.Cars[CarPosition - 1] as MSTSWagon).BrakeSystem.RearBrakeHoseConnected);
+                }
+            }
             Texture = First ? BrakeHoseFirstDis : (viewer.PlayerTrain.Cars[carPosition] as MSTSWagon).BrakeSystem.FrontBrakeHoseConnected ? BrakeHoseCon : BrakeHoseDis;
 
             // Allows compatibility with CarOperationWindow