Merge pull request #1083 from sweiland-openrails/MenuRouteNameClash

Menu contents route name clash

Author: cjakeman

Source/Menu/ContentForm.Designer.cs

@@ -61,6 +61,8 @@ public partial class ContentForm : Form
         private bool In_dataGridViewManualInstall_SelectionChanged = false;
         private bool In_buttonManualInstallAdd_Click = false;
 
+        private bool ManualInstallChangesMade = false;
+
         public ContentForm(UserSettings settings, string baseDocumentationUrl)
         {
             InitializeComponent();
@@ -93,6 +95,10 @@ public ContentForm(UserSettings settings, string baseDocumentationUrl)
                     route.Installed ? route.DateInstalled.ToString(CultureInfo.CurrentCulture.DateTimeFormat) : "",
                     route.Url });
                 dataGridViewAutoInstall.Rows[indexAdded].Cells[2].ToolTipText = route.Url;
+                if (!route.Installed)
+                {
+                    changeManualInstallRoute(routeName);
+                }
             }
 
             dataGridViewAutoInstall.Sort(dataGridViewAutoInstall.Columns[0], ListSortDirection.Ascending);
@@ -113,6 +119,10 @@ public ContentForm(UserSettings settings, string baseDocumentationUrl)
             // set focus to datagridview so that arrow keys can be used to scroll thru the list
             dataGridViewAutoInstall.Select();
 
+            // tab "Auto Installed" does not contain a Cancel button
+            // it's too difficult and not logical to rollback an "Auto Installed" route
+            buttonCancel.Hide();
+
             //
             // "Manually Installed" tab
             //
@@ -130,6 +140,45 @@ public ContentForm(UserSettings settings, string baseDocumentationUrl)
             dataGridViewManualInstall.Sort(dataGridViewManualInstall.Columns[0], ListSortDirection.Ascending);
 
             ManualInstallBrouwseDir = determineBrowseDir();
+            buttonCancel.Enabled = false;
+
+            setTextBoxesManualInstall();
+        }
+
+        void changeManualInstallRoute(string Route)
+        {
+            bool found = false;
+
+            foreach (var folder in Settings.Folders.Folders)
+            {
+                if (folder.Key == Route)
+                {
+                    // Route found in folder settings
+                    found = true;
+                }
+            }
+
+            if (found)
+            {
+                // search for the next route (1), (2) etc. not found in folder settings
+                int seqNr = 1;
+                string route = Route + " (" + seqNr + ")";
+                while (found)
+                {
+                    found = false;
+                    foreach (var folder in Settings.Folders.Folders)
+                    {
+                        if (folder.Key == route)
+                        {
+                            found = true;
+                            seqNr++;
+                            route = Route + " (" + seqNr + ")";
+                        }
+                    }
+                }
+                Settings.Folders.Folders[route] = Settings.Folders.Folders[Route];
+                Settings.Folders.Folders.Remove(Route);
+            }
         }
 
         private void tabControlContent_Selecting(object sender, TabControlCancelEventArgs e)
@@ -138,9 +187,12 @@ private void tabControlContent_Selecting(object sender, TabControlCancelEventArg
             {
                 case "tabPageAutoInstall":
                     dataGridViewAutoInstall.Select();
+                    buttonCancel.Hide();
                     break;
                 case "tabPageManuallyInstall":
                     dataGridViewManualInstall.Select();
+                    buttonCancel.Show();
+                    buttonCancel.Enabled = ManualInstallChangesMade;
                     break;
             }
         }
@@ -1051,7 +1103,6 @@ private void DisableAutoInstallButtons()
             buttonAutoInstallUpdate.Enabled = false;
             buttonAutoInstallDelete.Enabled = false;
             buttonOK.Enabled = false;
-            buttonCancel.Enabled = false;
         }
 
         private void setCursorToWaitCursor()
@@ -1073,7 +1124,6 @@ private void EnableAutoInstalButtons()
             buttonAutoInstallUpdate.Enabled = route.Installed && (route.getDownloadType() == ContentRouteSettings.DownloadType.github);
             buttonAutoInstallDelete.Enabled = route.Installed;
             buttonOK.Enabled = true;
-            buttonCancel.Enabled = true;
 
             setCursorToDefaultCursor();
         }
@@ -1398,6 +1448,18 @@ private void textBoxManualInstallRoute_TextChanged(object sender, EventArgs e)
             {
                 // only update the grid when user is filling/changing the route in the textbox
                 dataGridViewManualInstall.CurrentRow.Cells[0].Value = textBoxManualInstallRoute.Text;
+                ManualInstallChangesMade = true;
+                buttonCancel.Enabled = true;
+            }
+        }
+
+        private void textBoxManualInstallRoute_Leave(object sender, EventArgs e)
+        {
+            string route = textBoxManualInstallRoute.Text.Trim();
+            textBoxManualInstallRoute.Text = determineUniqueRoute(route);
+            if (textBoxManualInstallRoute.Text != route)
+            {
+                dataGridViewManualInstall.CurrentRow.Cells[0].Value = textBoxManualInstallRoute.Text;
             }
         }
 
@@ -1452,6 +1514,8 @@ private void buttonManualInstallAdd_Click(object sender, EventArgs e)
                     string route = determineUniqueRoute(Path.GetFileName(folderBrowser.SelectedPath));
                     dataGridViewManualInstall.CurrentRow.Cells[0].Value = route;
                     dataGridViewManualInstall.CurrentRow.Cells[1].Value = folderBrowser.SelectedPath;
+                    ManualInstallChangesMade = true;
+                    buttonCancel.Enabled = ManualInstallChangesMade;
                 }
                 else
                 {
@@ -1477,6 +1541,8 @@ private void buttonManualInstallDelete_Click(object sender, EventArgs e)
             if (dataGridViewManualInstall.CurrentRow != null)
             {
                 dataGridViewManualInstall.Rows.Remove(dataGridViewManualInstall.CurrentRow);
+                ManualInstallChangesMade = true;
+                buttonCancel.Enabled = ManualInstallChangesMade;
             }
         }
 
@@ -1499,6 +1565,7 @@ private void setTextBoxesManualInstall()
                 }
                 else
                 {
+                    // route automatically installed
                     textBoxManualInstallRoute.Text = "";
                     textBoxManualInstallPath.Text = "";
                     textBoxManualInstallRoute.Enabled = false;
@@ -1507,25 +1574,47 @@ private void setTextBoxesManualInstall()
                     buttonManualInstallDelete.Enabled = false;
                 }
             }
+            else
+            {
+                // empty form, like after installing OR
+                textBoxManualInstallRoute.Text = "";
+                textBoxManualInstallPath.Text = "";
+                textBoxManualInstallRoute.Enabled = false;
+                textBoxManualInstallPath.Enabled = false;
+                buttonManualInstallBrowse.Enabled = false;
+                buttonManualInstallDelete.Enabled = false;
+            }
         }
 
         string determineUniqueRoute(string Route)
         {
             string route = Route;
+            long seqNr = 0;
+            bool foundUniqueRoute = false;
 
-            bool found = false;
+            if (AutoInstallRoutes.ContainsKey(route))
+            {
+                // route already exists in the AutoInstall routes
+                seqNr = 1;
+                route = Route + " (" + seqNr + ")";
+            }
 
-            while (!found)
+            while (!foundUniqueRoute)
             {
-                found = true;
-                for (int i = 0; i < dataGridViewManualInstall.Rows.Count - 1; i++)
+                bool found = false;
+                for (int i = 0; i < dataGridViewManualInstall.Rows.Count; i++)
                 {
-                    if (dataGridViewManualInstall.Rows[i].Cells[0].Value.ToString() == route)
+                    if ((!dataGridViewManualInstall.Rows[i].Selected) && (dataGridViewManualInstall.Rows[i].Cells[0].Value.ToString() == route))
                     {
-                        route += " copy";
-                        found = false;
+                        seqNr++;
+                        route = Route + " (" + seqNr + ")";
+                        found = true;
                     }
                 }
+                if (!found)
+                {
+                    foundUniqueRoute = true;
+                }
             }
 
             return route;
@@ -1588,6 +1677,21 @@ private static bool isWrongPath(string path, GettextResourceManager catalog)
             return false;
         }
 
+        private void buttonCancel_Click(object sender, EventArgs e)
+        {
+            string message = Catalog.GetString("Cancel: changes made in the 'Manually Installed' tab will not be saved, are you sure?");
+            if (MessageBox.Show(message, Catalog.GetString("Attention"), MessageBoxButtons.YesNo, MessageBoxIcon.Warning) == DialogResult.No)
+            {
+                // not sure, cancel the cancel
+                this.DialogResult = DialogResult.None;
+            }
+            else 
+            {
+                // sure to cancel the changes
+                ManualInstallChangesMade = false;
+            }
+        }
+
         private void buttonOK_Click(object sender, EventArgs e)
         {
             // save "Manually Installed" tab changes into the registry/ini file via Settings.Folders.Folders
@@ -1641,6 +1745,8 @@ private void buttonOK_Click(object sender, EventArgs e)
 
             Settings.Save();
 
+            ManualInstallChangesMade = false;
+
             this.Close();
         }
 
@@ -1672,6 +1778,17 @@ private int findIndexDgvManualInstall(string route)
 
         private void DownloadContentForm_FormClosing(object sender, FormClosingEventArgs formClosingEventArgs)
         {
+            if (ManualInstallChangesMade)
+            {
+                string message = Catalog.GetString("Cancel: changes made in the 'Manually Installed' tab will not be saved, are you sure?");
+                if (MessageBox.Show(message, Catalog.GetString("Attention"), MessageBoxButtons.YesNo, MessageBoxIcon.Warning) == DialogResult.No)
+                {
+                    // not sure, cancel the cancel
+                    formClosingEventArgs.Cancel = true;
+                    return;
+                }
+            }
+
             if (AutoInstallClosingBlocked)
             {
                 // cancelled event, so continue