missing error handling

[trondhindenes]

I'm trying to install openplotter on a jetson device, and noticed that the signalk installation is failing:

Looking in the source code, I see a lot of subprocess.call statements in a try block and there does seem to be some error handling but it always writes "DONE" even if an exception happened.

IMHO this can be made more robust by testing that "npm" is available after having set up packages, parsing the apt log etc to give clearer detailed errors

In the installer script I can see nodejs is being installed/reinstalled, but I don't see "npm" being reinstalled. Wondering if that's why I'm having issues

[trondhindenes]

Also discovered this, which seems to point at the same bug:
https://forum.openmarine.net/showthread.php?tid=6593 - probably more error-handling around apt/npm operations is needed

[Not-a-bug]

Are you using an officially supported release ?

I faced the same issue on last Raspberry Pi OS (Debian Trixie). I tested 2 solutions which seem to work but to be confirmed -as it is not supported and kind of gross-:

Solution 1

• Force codeName to 'bookworm' instead of taking the 'real' value in signalkPostInstall, line 38
• Building using instructions provided in the readme
• With this solution, npm is installed along nodejs

Solution 2

• Adding npm in signalkPostInstall, line 52
• Building using instructions provided in the readme
• With this solution, you force the installation of npm separately as it is not installed with nodejs

[Not-a-bug]

Tested on a fresh and official install of OpenPlotter 4.2.x, after an apt update/upgrade, and facing the same error.

[sailoog]

#4