Skip to content

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Nov 11, 2025

Backporting JDK-8317678: Fix up hashCode() for ZipFile.Source.Key. Fixes the hashCode() implementation and adds a new benchmark test. Ran GHA Sanity Checks (passed), related zip tests (passed) and the new benchmark test (executed properly). The merge conflict was due to the missing benchmark test file, which is in this PR.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317678 needs maintainer approval

Issue

  • JDK-8317678: Fix up hashCode() for ZipFile.Source.Key (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4169/head:pull/4169
$ git checkout pull/4169

Update a local copy of the PR:
$ git checkout pull/4169
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4169/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4169

View PR using the GUI difftool:
$ git pr show -t 4169

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4169.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 11, 2025

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 11, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 8d9a4b43f4fff30fd217dab2c224e641cb913c18 8317678: Fix up hashCode() for ZipFile.Source.Key Nov 11, 2025
@openjdk
Copy link

openjdk bot commented Nov 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base

Development

Successfully merging this pull request may close these issues.

1 participant