Skip to content

Conversation

@elifaslan1
Copy link
Contributor

@elifaslan1 elifaslan1 commented Nov 11, 2025

Clean backport. This is a trivial update to a comment that starts with an unnecessary extra slash and contains a typo.


Progress

  • JDK-8310915 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310915: Typo in aarch64.ad: "envcodings" (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4165/head:pull/4165
$ git checkout pull/4165

Update a local copy of the PR:
$ git checkout pull/4165
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4165/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4165

View PR using the GUI difftool:
$ git pr show -t 4165

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4165.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 11, 2025

👋 Welcome back elifaslan1! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 11, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 6f325db49365d3d06add5d194d4696a1428675fa 8310915: Typo in aarch64.ad: "envcodings" Nov 11, 2025
@openjdk
Copy link

openjdk bot commented Nov 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 11, 2025
@openjdk
Copy link

openjdk bot commented Nov 11, 2025

⚠️ @elifaslan1 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 11, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 11, 2025

Webrevs

@elifaslan1
Copy link
Contributor Author

/approval request This is a trivial update to a comment that starts with an unnecessary extra slash and contains a typo. Clean backport. Tests pass.

@openjdk
Copy link

openjdk bot commented Nov 11, 2025

@elifaslan1
8310915: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant