chore: proper client extraction #6996
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
# Conflicts: # codex-rs/Cargo.toml
aibrahim-oai
left a comment
aibrahim-oai
left a comment
There was a problem hiding this comment.
My initial reaction is we should move the remaining of client.rs, client_common.rs, default_client.rs, and anything client related to codex-api crate. Has as little pub functions/structs as possible. The codex-api internals is too public now and they are just being consumed by those files. I feel it would be great if we can hide those internals. Thoughts?
| @@ -0,0 +1,181 @@ | |||
| use chrono::DateTime; | |||
There was a problem hiding this comment.
how are you planning to use the bridge?
There was a problem hiding this comment.
This is used for the transistion phase mainly. I'll drop as much as possible now
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
No description provided.