Fix #692 [Bug]: Passing invalid parameters to gemini throws Undefined array key "choices" /www/htdocs/vendor/openai-php/client/src/Responses/Chat/CreateResponse.php 54

ammarcoux · ammarcoux · commit 273cc3752640 · 2025-10-01T19:55:27.000-04:00
Change-Id: Ibbf64cc554ef68844fd8338583f3fc8ec5fde413
diff --git a/src/Transporters/HttpTransporter.php b/src/Transporters/HttpTransporter.php
@@ -172,11 +172,13 @@ private function throwIfJsonError(ResponseInterface $response, string|ResponseIn
         }
 
         try {
-            /** @var array{error?: string|array{message: string|array<int, string>, type: string, code: string}} $data */
+            /** @var (array{error?: string|array{message: string|array<int, string>, type: string, code: string}})|(array{0?: array{error?: string|array{message: string|array<int, string>, code: string}}}) $data */
             $data = json_decode($contents, true, flags: JSON_THROW_ON_ERROR);
 
             if (isset($data['error'])) {
                 throw new ErrorException($data['error'], $response);
+            } elseif (isset($data[0]['error'])) {
+                throw new ErrorException($data[0]['error'], $response);
             }
         } catch (JsonException $jsonException) {
             throw new UnserializableResponse($jsonException, $response);

Original file line number	Diff line number	Diff line change
`@@ -172,11 +172,13 @@ private function throwIfJsonError(ResponseInterface $response, string\|ResponseIn`
`172`	`172`	`}`
`173`	`173`
`174`	`174`	`try {`
`175`		`- /** @var array{error?: string\|array{message: string\|array<int, string>, type: string, code: string}} $data */`
	`175`	`+ /** @var (array{error?: string\|array{message: string\|array<int, string>, type: string, code: string}})\|(array{0?: array{error?: string\|array{message: string\|array<int, string>, code: string}}}) $data */`
`176`	`176`	`$data = json_decode($contents, true, flags: JSON_THROW_ON_ERROR);`
`177`	`177`
`178`	`178`	`if (isset($data['error'])) {`
`179`	`179`	`throw new ErrorException($data['error'], $response);`
	`180`	`+ } elseif (isset($data[0]['error'])) {`
	`181`	`+ throw new ErrorException($data[0]['error'], $response);`
`180`	`182`	`}`
`181`	`183`	`} catch (JsonException $jsonException) {`
`182`	`184`	`throw new UnserializableResponse($jsonException, $response);`