refactor: fix issues found by using eslint-config-vaadin (#172)

Author: web-padawan

fixtures/lit/src/expansion-panel.ts

@@ -1,4 +1,11 @@
-import { LitElement, html, css, PropertyValues, TemplateResult } from 'lit';
+import {
+  css,
+  html,
+  LitElement,
+  type CSSResult,
+  type PropertyValues,
+  type TemplateResult
+} from 'lit';
 import { customElement } from 'lit/decorators/custom-element.js';
 import { property } from 'lit/decorators/property.js';
 import { query } from 'lit/decorators/query.js';
@@ -44,7 +51,7 @@ export class ExpansionPanel extends OpenedMixin(LitElement) {
 
   private _boundBodyKeyup = this._onBodyKeyup.bind(this);
 
-  static get styles() {
+  static get styles(): CSSResult {
     return css`
       :host {
         display: block;

fixtures/lit/src/fancy-accordion.ts

@@ -1,4 +1,11 @@
-import { LitElement, html, css, PropertyValues, TemplateResult } from 'lit';
+import {
+  css,
+  html,
+  LitElement,
+  type CSSResult,
+  type PropertyValues,
+  type TemplateResult
+} from 'lit';
 import { customElement } from 'lit/decorators/custom-element.js';
 import { property } from 'lit/decorators/property.js';
 import { ExpansionPanel } from './expansion-panel.js';
@@ -34,7 +41,7 @@ export class FancyAccordion extends LitElement {
 
   private _boundOnOpened = this._onOpened.bind(this) as EventListener;
 
-  static get styles() {
+  static get styles(): CSSResult {
     return css`
       :host {
         display: block;

fixtures/lit/src/intl-currency.ts

@@ -1,4 +1,10 @@
-import { LitElement, html, css, TemplateResult } from 'lit';
+import {
+  css,
+  html,
+  LitElement,
+  type CSSResult,
+  type TemplateResult
+} from 'lit';
 import { customElement } from 'lit/decorators/custom-element.js';
 import { property } from 'lit/decorators/property.js';
 
@@ -38,7 +44,7 @@ export class IntlCurrency extends LitElement {
    */
   @property() locale: string | null | undefined = 'en-GB';
 
-  static get styles() {
+  static get styles(): CSSResult {
     return css`
       :host {
         all: inherit;

fixtures/lit/src/opened-mixin.ts

@@ -1,4 +1,4 @@
-import { LitElement } from 'lit';
+import type { LitElement } from 'lit';
 import { property } from 'lit/decorators/property.js';
 
 /* eslint-disable @typescript-eslint/no-explicit-any */

fixtures/lit/src/progress-bar.ts

@@ -1,4 +1,11 @@
-import { LitElement, html, css, PropertyValues, TemplateResult } from 'lit';
+import {
+  css,
+  html,
+  LitElement,
+  type CSSResult,
+  type PropertyValues,
+  type TemplateResult
+} from 'lit';
 import { customElement } from 'lit/decorators/custom-element.js';
 import { property } from 'lit/decorators/property.js';
 
@@ -52,7 +59,7 @@ export class ProgressBar extends LitElement {
    */
   @property({ type: Boolean, reflect: true }) indeterminate = false;
 
-  static get styles() {
+  static get styles(): CSSResult {
     return css`
       :host {
         display: block;

packages/api-common/src/manifest-mixin.ts

@@ -1,6 +1,6 @@
-import { LitElement, html } from 'lit';
+import { html, type LitElement } from 'lit';
 import { property } from 'lit/decorators/property.js';
-import { fetchManifest, hasCustomElements, Package } from './manifest.js';
+import { fetchManifest, hasCustomElements, type Package } from './manifest.js';
 
 /* eslint-disable @typescript-eslint/no-explicit-any */
 export type Constructor<T = unknown> = new (...args: any[]) => T;

packages/api-common/src/manifest.ts

@@ -15,7 +15,7 @@ import type {
   Slot
 } from 'custom-elements-manifest/schema';
 
-export {
+export type {
   Attribute,
   ClassField,
   ClassMember,
@@ -119,16 +119,12 @@ export const getElementData = (
   };
 };
 
-export const getPublicFields = (members: ClassMember[] = []): ClassField[] => {
-  return members.filter(
+export const getPublicFields = (members: ClassMember[] = []): ClassField[] =>
+  members.filter(
     (x: ClassMember): x is ClassField => x.kind === 'field' && isPublic(x)
   );
-};
 
-export const getPublicMethods = (
-  members: ClassMember[] = []
-): ClassMethod[] => {
-  return members.filter(
+export const getPublicMethods = (members: ClassMember[] = []): ClassMethod[] =>
+  members.filter(
     (x: ClassMember): x is ClassMethod => x.kind === 'method' && isPublic(x)
   );
-};

packages/api-common/src/templates.ts

@@ -1,6 +1,6 @@
-const templates: Array<HTMLTemplateElement[]> = [];
+const templates: HTMLTemplateElement[][] = [];
 
-export const setTemplates = (id: number, tpl: HTMLTemplateElement[]) => {
+export const setTemplates = (id: number, tpl: HTMLTemplateElement[]): void => {
   templates[id] = tpl;
 };
 

packages/api-common/src/utils.ts

@@ -3,7 +3,10 @@ export const unquote = (value?: string): string | undefined =>
     ? value.slice(1, value.length - 1)
     : value;
 
-export function html(strings: TemplateStringsArray, ...values: string[]) {
+export function html(
+  strings: TemplateStringsArray,
+  ...values: string[]
+): HTMLTemplateElement {
   const template = document.createElement('template');
   template.innerHTML = values.reduce(
     (acc, v, idx) => acc + v + strings[idx + 1],

packages/api-demo/src/api-demo.ts

@@ -1,10 +1,11 @@
+import type { CSSResultArray } from 'lit';
 import sharedStyles from '@api-viewer/common/lib/shared-styles.js';
 import { setTemplates } from '@api-viewer/common/lib/templates.js';
 import { ApiDemoBase } from './base.js';
 import demoStyles from './styles.js';
 
 export class ApiDemo extends ApiDemoBase {
-  static get styles() {
+  static get styles(): CSSResultArray {
     return [sharedStyles, demoStyles];
   }
 
@@ -14,7 +15,7 @@ export class ApiDemo extends ApiDemoBase {
 
   public setTemplates(templates?: HTMLTemplateElement[]): void {
     setTemplates(
-      this._id as number,
+      this._id!,
       templates || Array.from(this.querySelectorAll('template'))
     );
   }