Skip to content

[API] Parse baggage value as spec compliant #3758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −2
Draft

[API] Parse baggage value as spec compliant #3758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7db87c2
[API] Parse baggage value as spec compliant
ThomsonTan Nov 21, 2025
edc245e
Merge branch 'main' into fix_baggage_value
ThomsonTan Nov 21, 2025
ab057f9
Merge branch 'main' into fix_baggage_value
marcalff Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/include/opentelemetry/baggage/baggage.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,8 @@ class OPENTELEMETRY_EXPORT Baggage
{
ret.push_back(' ');
}
else if (std::isalnum(str[i]) || str[i] == '-' || str[i] == '_' || str[i] == '.' ||
str[i] == '~')
else if (str[i] >= ' ' && str[i] <= '~' && str[i] != '"' && str[i] != ',' && str[i] != ';' &&
str[i] != '\\')
{
ret.push_back(str[i]);
}
Expand Down
2 changes: 2 additions & 0 deletions api/test/baggage/baggage_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ TEST(BaggageTest, ValidateExtractHeader)
{"1a-2f%40foo=bar%251,a%2A%2Ffoo-_%2Fbar=bar+4",
{"1a-2f@foo", "a*/foo-_/bar"},
{"bar%1", "bar 4"}}, // decoding is done properly
{"field=foo:bar", {"field"}, {"foo:bar"}}, // colon in value
{"mixed=a/b:c?d=e", {"mixed"}, {"a/b:c?d=e"}}, // mixed special characters
{"k1=v1,invalidmember,k2=v2", {"k1", "k2"}, {"v1", "v2"}}, // invalid member is skipped
{",", {}, {}},
{",=,", {}, {}},
Expand Down
Loading