use atomics in critnib find_*

bratpiorka · bratpiorka · commit d71076a616ca · 2025-03-03T22:09:41.000Z
diff --git a/src/critnib/critnib.c b/src/critnib/critnib.c
@@ -524,7 +524,9 @@ find_predecessor(struct critnib_node *__restrict n) {
     while (1) {
         int nib;
         for (nib = NIB; nib >= 0; nib--) {
-            if (n->child[nib]) {
+            struct critnib_node *m;
+            utils_atomic_load_acquire_ptr((void **)&n->child[nib], (void **)&m);
+            if (m) {
                 break;
             }
         }
@@ -533,7 +535,7 @@ find_predecessor(struct critnib_node *__restrict n) {
             return NULL;
         }
 
-        n = n->child[nib];
+        utils_atomic_load_acquire_ptr((void **)&n->child[nib], (void **)&n);
         if (is_leaf(n)) {
             return to_leaf(n);
         }

Original file line number	Diff line number	Diff line change
`@@ -524,7 +524,9 @@ find_predecessor(struct critnib_node *__restrict n) {`
`524`	`524`	`while (1) {`
`525`	`525`	`int nib;`
`526`	`526`	`for (nib = NIB; nib >= 0; nib--) {`
`527`		`- if (n->child[nib]) {`
	`527`	`+ struct critnib_node *m;`
	`528`	`+ utils_atomic_load_acquire_ptr((void )&n->child[nib], (void )&m);`
	`529`	`+ if (m) {`
`528`	`530`	`break;`
`529`	`531`	`}`
`530`	`532`	`}`
`@@ -533,7 +535,7 @@ find_predecessor(struct critnib_node *__restrict n) {`
`533`	`535`	`return NULL;`
`534`	`536`	`}`
`535`	`537`
`536`		`- n = n->child[nib];`
	`538`	`+ utils_atomic_load_acquire_ptr((void )&n->child[nib], (void )&n);`
`537`	`539`	`if (is_leaf(n)) {`
`538`	`540`	`return to_leaf(n);`
`539`	`541`	`}`