Skip to content
Open
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions estate/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from . import models
30 changes: 30 additions & 0 deletions estate/__manifest__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# Part of Odoo. See LICENSE file for full copyright and licensing details.

{
'name': 'Estate',
'version': '1.0',
'category': 'Sales/Estate',
'sequence': 15,
'description': """
This module is here to help you manage your real estate business.
""",
'summary': 'Track all the properties you own',
'website': 'https://www.odoo.com/app/estate',
'depends': [
'base'
],
'data': [
'security/ir.model.access.csv',
'views/estate_property_views.xml',
'views/estate_property_type_views.xml',
'views/estate_property_tag_views.xml',
'views/estate_property_offer_views.xml',
'views/estate_menus.xml'
],
'demo': [
],
'installable': True,
'application': True,
'author': 'Odoo S.A.',
'license': 'LGPL-3',
}
4 changes: 4 additions & 0 deletions estate/models/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
from . import estate_property
from . import estate_property_type
from . import estate_property_tag
from . import estate_property_offer
71 changes: 71 additions & 0 deletions estate/models/estate_property.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
from odoo import models, fields, api, exceptions


class EstateProperty(models.Model):
_name = "estate.property"
_description = "Estate properties"

name = fields.Char('Name', required=True, translate=True)
description = fields.Text('Description', required=True)
postcode = fields.Char('Postcode')
date_availability = fields.Date('Available From', copy=False, default=fields.Date.add(fields.Date.today(), months=3))
expected_price = fields.Float('Expected Price')
selling_price = fields.Float('Selling Price', readonly=True)
bedrooms = fields.Integer(default=2)
active = fields.Boolean(default=True)
living_area = fields.Integer('Living Area (sqm)')
facades = fields.Integer('Facades')
garage = fields.Boolean('Garage')
garden = fields.Boolean('Garden')
garden_area = fields.Float('Garden Area (sqm)')
garden_orientation = fields.Selection(
string='Garden Orientation',
selection=[('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
selection=[('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')])
selection=[
('north', 'North'),
('south', 'South'),
('east', 'East'),
('west',` 'West')
])

Would be better for readability to have them in multiple lines

state = fields.Selection(
string='State',
required=True,
default='new',
copy=False,
selection=[('new', 'New'), ('offer_received', 'Offer Received'), ('offer_accepted', 'Offer Accepted'), ('sold', 'Sold'), ('cancelled', 'Cancelled')])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
selection=[('new', 'New'), ('offer_received', 'Offer Received'), ('offer_accepted', 'Offer Accepted'), ('sold', 'Sold'), ('cancelled', 'Cancelled')])
selection=[
('new', 'New'),
('offer_received', 'Offer Received'),
('offer_accepted', 'Offer Accepted'),
('sold', 'Sold'),
('cancelled', 'Cancelled')
])

property_type_id = fields.Many2one("estate.property.type", "Type")
property_tags_ids = fields.Many2many("estate.property.tag", "Tags")
sales_person_id = fields.Many2one('res.users', string='Salesperson', default=lambda self: self.env.user)
buyer_id = fields.Many2one('res.partner', string='Buyer', copy=False)
offer_ids = fields.One2many('estate.property.offer', 'property_id', string="Offers")
total_area = fields.Float('Total Area', compute='_compute_total_area')
best_price = fields.Float('Best Offer', compute='_compute_best_price')

@api.depends('garden_area', 'living_area')
def _compute_total_area(self):
for record in self:
record.total_area = record.garden_area + record.living_area

@api.depends('offer_ids.price')
def _compute_best_price(self):
for record in self:
record.best_price = max(record.offer_ids, key=lambda p: p.price).price

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the offer_ids recordset is empty it will trigger a ValueError so it is better to either check that offer_ids has something before we call max or we fallback on a default value

Suggested change
record.best_price = max(record.offer_ids, key=lambda p: p.price).price
record.best_price = max(record.offer_ids.mapped('price'), default=0.0)


@api.onchange('garden')
def _onchange_garden(self):
if not self.garden:
self.garden_area = None
self.garden_orientation = None
else:
self.garden_area = 10
self.garden_orientation = 'north'

def action_cancel_property(self):
for record in self:
if record.state == 'sold':
raise exceptions.UserError('Sold properties cannot be cancelled')
else:
record.state = 'cancelled'
return True

def action_sold_property(self):
for record in self:
if record.state == 'cancelled':
raise exceptions.UserError('Cancelled properties cannot be sold')
else:
record.state = 'sold'
return True

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing EOL

42 changes: 42 additions & 0 deletions estate/models/estate_property_offer.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
from odoo import models, fields ,api, exceptions


class EstatePropertyOffer(models.Model):
_name = "estate.property.offer"
_description = "Estate properties Offers"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to have the description here as title case

Suggested change
_description = "Estate properties Offers"
_description = "Estate Properties Offers"


price = fields.Float('Price')
status = fields.Selection(
string='Status',
default='new',
copy=False,
selection=[('accepted', 'Accepted'), ('refused', 'Refused'), ('new', 'New')])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above to have in multiple lines

partner_id = fields.Many2one('res.partner', string='Buyer', required=True)
property_id = fields.Many2one('estate.property', string='Estate Property', required=True)
validity = fields.Integer('Validity', default=7)
date_deadline = fields.Datetime('Deadline', compute='_compute_date_deadline', inverse='_inverse_date_deadline')

@api.depends('validity', 'create_date')
def _compute_date_deadline(self):
for record in self:
record.date_deadline = fields.Date.add(record.create_date, days=record.validity)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create_date will have a value only after the record is already created so it is better to have a fallback on today to avoid crash during record creation

Suggested change
record.date_deadline = fields.Date.add(record.create_date, days=record.validity)
record.date_deadline = fields.Date.add(record.create_date or fields.Date.today(), days=record.validity)


def _inverse_date_deadline(self):
for record in self:
record.validity = (record.date_deadline - record.create_date).days

def action_accept_offer(self):
if any(record.status == 'accepted' for record in self.property_id.offer_ids):
raise exceptions.UserError('An offer is already accepted for this property')
for record in self:
record.status = 'accepted'
record.property_id.buyer_id = record.partner_id
record.property_id.selling_price = record.price
return True

def action_refuse_offer(self):
for record in self:
if record.status == 'accepted':
raise exceptions.UserError('You cant refuse an already accepted offer')
record.status = 'refused'
return True
8 changes: 8 additions & 0 deletions estate/models/estate_property_tag.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
from odoo import models, fields


class EstatePropertyTag(models.Model):
_name = "estate.property.tag"
_description = "Estate properties Tags"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same about the title-case convention we should use in description


name = fields.Char('Name', required=True, translate=True)
8 changes: 8 additions & 0 deletions estate/models/estate_property_type.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
from odoo import models, fields


class EstatePropertyType(models.Model):
_name = "estate.property.type"
_description = "Estate properties Types"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same


name = fields.Char('Name', required=True, translate=True)
5 changes: 5 additions & 0 deletions estate/security/ir.model.access.csv
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1
access_estate_property_type,access_estate_property_type,model_estate_property_type,base.group_user,1,1,1,1
access_estate_property_tag,access_estate_property_tag,model_estate_property_tag,base.group_user,1,1,1,1
access_estate_property_offer,access_estate_property_offer,model_estate_property_offer,base.group_user,1,1,1,1
12 changes: 12 additions & 0 deletions estate/views/estate_menus.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?xml version="1.0"?>
<odoo>
<menuitem id="estate_main_menu" name="Real Estate">
<menuitem id="estate_advertisement_menu" name="Advertisment">
<menuitem id="estate_property_menu_action" action="estate_property_action" />
</menuitem>
<menuitem id="estate_settings_menu" name="Settings">
<menuitem id="estate_property_type_menu_action" action="estate_property_type_action" />
<menuitem id="estate_property_tag_menu_action" action="estate_property_tag_action" />
</menuitem>
</menuitem>
</odoo>
34 changes: 34 additions & 0 deletions estate/views/estate_property_offer_views.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<?xml version="1.0"?>
<odoo>
<record id="estate_property_offer_view_form" model="ir.ui.view">
<field name="name">estate.property.offer.form</field>
<field name="model">estate.property.offer</field>
<field name="arch" type="xml">
<form string="Estate Property Offer">
<group>
<field name="price" />
<field name="status" />
<field name="partner_id" />
<field name="validity" />
<field name="date_deadline" />
</group>
</form>
</field>
</record>

<record id="estate_property_offer_view_tree" model="ir.ui.view">
<field name="name">estate.property.offer.list</field>
<field name="model">estate.property.offer</field>
<field name="arch" type="xml">
<list string="Channel">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<list string="Channel">
<list string="Offers">

Would be reflecting better what is shown 😄

<field name="price" />
<field name="partner_id" />
<field name="validity" />
<field name="date_deadline" />
<button name="action_accept_offer" string="Accept" type="object" icon="fa-check"/>
<button name="action_refuse_offer" string="Refuse" type="object" icon="fa-times"/>
<field name="status" />
</list>
</field>
</record>
</odoo>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing EOL

29 changes: 29 additions & 0 deletions estate/views/estate_property_tag_views.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<?xml version="1.0"?>
<odoo>
<record id="estate_property_tag_view_form" model="ir.ui.view">
<field name="name">estate.property.tag.form</field>
<field name="model">estate.property.tag</field>
<field name="arch" type="xml">
<form string="Estate Property Tag">
<sheet>
<div class="oe_title">
<h1 class="mb32">
<field name="name" placeholder="Under Option" class="mb16" />
</h1>
</div>
</sheet>
</form>
</field>
</record>

<record id="estate_property_tag_action" model="ir.actions.act_window">
<field name="name">Estate Property Tags</field>
<field name="res_model">estate.property.tag</field>
<field name="view_mode">list,form</field>
<field name="help" type="html">
<p class="o_view_nocontent_smiling_face">
Property Tags.
</p>
</field>
</record>
</odoo>
29 changes: 29 additions & 0 deletions estate/views/estate_property_type_views.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<?xml version="1.0"?>
<odoo>
<record id="estate_property_type_view_form" model="ir.ui.view">
<field name="name">estate.property.type.form</field>
<field name="model">estate.property.type</field>
<field name="arch" type="xml">
<form string="Estate Property Type">
<sheet>
<div class="oe_title">
<h1 class="mb32">
<field name="name" placeholder="House" class="mb16" />
</h1>
</div>
</sheet>
</form>
</field>
</record>

<record id="estate_property_type_action" model="ir.actions.act_window">
<field name="name">Estate Property Types</field>
<field name="res_model">estate.property.type</field>
<field name="view_mode">list,form</field>
<field name="help" type="html">
<p class="o_view_nocontent_smiling_face">
A property type is, for example, a house or an apartment.
</p>
</field>
</record>
</odoo>
Loading