[FIX] estate: PR review adjustments

Author: wimar-odoo

estate/models/estate_property.py

@@ -1,4 +1,4 @@
-from odoo import fields, models, api
+from odoo import fields, models, api, _
 from odoo.exceptions import UserError, ValidationError
 from odoo.tools import float_is_zero, float_compare
 
@@ -63,17 +63,15 @@ def _onchange_garden(self):
             self.garden_orientation = ""
 
     def action_property_sold(self):
-        for record in self:
-            if record.state == "cancelled":
-                raise UserError("Cancelled properties cannot be sold.")
-            record.state = "sold"
+        if self.filtered(lambda x: x.state == "cancelled"):
+            raise UserError(_("Cancelled properties cannot be sold."))
+        self.state = "sold"
         return True
 
     def action_property_cancel(self):
-        for record in self:
-            if record.state == "sold":
-                raise UserError("Sold properties cannot be cancelled.")
-            record.state = "cancelled"
+        if self.filtered(lambda x: x.state == "sold"):
+            raise UserError(_("Sold properties cannot be cancelled."))
+        self.state = "cancelled"
         return True
 
     _positive_expected_price = models.Constraint(
@@ -86,4 +84,4 @@ def action_property_cancel(self):
     def _check_ninety_percent(self):
         for record in self:
             if not float_is_zero(record.selling_price, 2) and float_compare(record.expected_price * 0.9, record.selling_price, 2) == 1:
-                raise ValidationError("The selling price must be at least 90% of the expected price! You must reduce the expected price if you want to accept this offer.")
+                raise ValidationError(_("The selling price must be at least 90% of the expected price! You must reduce the expected price if you want to accept this offer."))

estate/models/estate_property_offer.py

@@ -12,7 +12,7 @@ class EstatePropertyOffer(models.Model):
         selection=[("accepted", "Accepted"), ("refused", "Refused")],
         copy=False,
     )
-    partner_id = fields.Many2one("res.partner", string="Buyer",  required=True)
+    partner_id = fields.Many2one("res.partner", string="Buyer", required=True)
     property_id = fields.Many2one("estate.property", required=True)
     validity = fields.Integer(string="Validity (days)", default=7)
     date_deadline = fields.Date(string="Deadline", compute="_compute_date_deadline", inverse="_inverse_date_deadline")
@@ -28,23 +28,18 @@ def _inverse_date_deadline(self):
             record.validity = (record.date_deadline - record.create_date.date()).days
 
     def action_accept_offer(self):
-        for record in self:
-            if record.property_id.state not in ("accepted", "sold", "cancelled"):
-                record.property_id.state = "accepted"
-                record.status = "accepted"
-                record.property_id.selling_price = self.price
-                record.property_id.buyer_id = self.partner_id
-            else:
-                raise UserError(_("This offer can't be accepted because the property is currently %s.")% record.property_id.state)
+        if self.filtered(lambda x: x.property_id.state in ("accepted", "sold", "cancelled")):
+            raise UserError(_("This offer can't be accepted because the property is currently %s.", self.property_id.state))
+
+        self.status = "accepted"
+        self.property_id.state = "accepted"
+        self.property_id.selling_price = self.price
+        self.property_id.buyer_id = self.partner_id
+
         return True
 
     def action_refuse_offer(self):
-        for record in self:
-            if record.status == "accepted":
-                record.property_id.state = "new"
-                record.property_id.selling_price = 0.0
-                record.property_id.buyer_id = ""
-            record.status = "refused"
+        self.status = "refused"
         return True
 
     _positive_offer_price = models.Constraint(

estate/security/ir.model.access.csv

@@ -2,4 +2,4 @@ id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
 access_estate_property_user,access_estate_property_user,model_estate_property,base.group_user,1,1,1,1
 access_estate_property_type_user,access_estate_property_type_user,model_estate_property_type,base.group_user,1,1,1,1
 access_estate_property_tag_user,access_estate_property_tag_user,model_estate_property_tag,base.group_user,1,1,1,1
-access_estate_property_offer_user,access_estate_property_offer_user,model_estate_property_offer,base.group_user,1,1,1,1
+access_estate_property_offer_user,access_estate_property_offer_user,model_estate_property_offer,base.group_user,1,1,1,1