[IMP] estate: Chapter 10 - SQL and Python Constraints

- Added SQL constraints to ensure positive prices and unique names
- Added Python constraints to enforce offers at least 90% of the expected price

Author: wimar-odoo

estate/models/estate_property.py

@@ -1,5 +1,6 @@
 from odoo import fields, models, api
-from odoo.exceptions import UserError
+from odoo.exceptions import UserError, ValidationError
+from odoo.tools import float_is_zero, float_compare
 
 
 class EstateProperty(models.Model):
@@ -73,3 +74,15 @@ def action_property_cancel(self):
                 raise UserError("Sold properties cannot be cancelled.")
             record.state = "cancelled"
         return True
+
+    _positive_expected_price = models.Constraint(
+        "CHECK(expected_price > 0)",
+        "The expected price must be strictly positive.",
+    )
+
+    @api.constrains("selling_price", "expected_price")
+    @api.onchange("selling_price", "expected_price")
+    def _check_ninety_percent(self):
+        for record in self:
+            if not float_is_zero(record.selling_price, 2) and float_compare(record.expected_price * 0.9, record.selling_price, 2) == 1:
+                raise ValidationError("The selling price must be at least 90% of the expected price! You must reduce the expected price if you want to accept this offer.")

estate/models/estate_property_offer.py

@@ -4,7 +4,7 @@
 
 class EstatePropertyOffer(models.Model):
     _name = "estate.property.offer"
-    _description = "estate.property.offer"
+    _description = "Estate Property Offer"
 
     price = fields.Float()
     status = fields.Selection(
@@ -38,9 +38,14 @@ def action_accept_offer(self):
 
     def action_refuse_offer(self):
         for record in self:
-            if record.property_id.state == "accepted":
+            if record.status == "accepted":
                 record.property_id.state = "new"
                 record.status = "refused"
                 record.property_id.selling_price = 0.0
                 record.property_id.buyer_id = ""
         return True
+
+    _positive_offer_price = models.Constraint(
+        "CHECK(price > 0)",
+        "The offer price must be strictly positive.",
+    )

estate/models/estate_property_tag.py

@@ -3,6 +3,11 @@
 
 class EstatePropertyTag(models.Model):
     _name = "estate.property.tag"
-    _description = "estate.property.tag"
+    _description = "Estate Property Tag"
 
     name = fields.Char(required=True)
+
+    _unique_property_tag_name = models.Constraint(
+        "UNIQUE(name)",
+        "The tag name must be unique.",
+    )

estate/models/estate_property_type.py

@@ -6,3 +6,8 @@ class EstatePropertyType(models.Model):
     _description = "Estate Property Type"
 
     name = fields.Char(required=True)
+
+    _unique_property_type_name = models.Constraint(
+        "UNIQUE(name)",
+        "The tag name must be unique.",
+    )

estate/views/estate_property_offer_views.xml

@@ -27,8 +27,8 @@
                 <field name="partner_id"/>
                 <field name="validity"/>
                 <field name="date_deadline"/>
-                <button name="action_accept_offer" type="object" icon="fa-check"/>
-                <button name="action_refuse_offer" type="object" icon="fa-times"/>
+                <button name="action_accept_offer" type="object" icon="fa-check" title="Accept offer"/>
+                <button name="action_refuse_offer" type="object" icon="fa-times" title="Refuse offer"/>
                 <field name="status"/>
             </list>
         </field>

estate/views/estate_property_type_views.xml

@@ -3,7 +3,7 @@
     <record id="estate_property_type_action" model="ir.actions.act_window">
         <field name="name">Property Types</field>
         <field name="res_model">estate.property.type</field>
-        <field name="view_mode">list,form</field>
+        <field name="view_mode">form</field>
     </record>
 
     <record id="estate_property_type_form" model="ir.ui.view">