[IMP] estate: add constraints for positive prices and unique names in property offers, tags, and types

Author: Sylsee

estate/models/estate_property.py

@@ -1,5 +1,6 @@
 from odoo import api, fields, models
-from odoo.exceptions import UserError
+from odoo.exceptions import UserError, ValidationError
+from odoo.tools import float_compare
 
 
 class EstateProperty(models.Model):
@@ -58,6 +59,10 @@ class EstateProperty(models.Model):
     total_area = fields.Integer('Total Area (sqm)', compute='_compute_total_area')
     best_price = fields.Float('Best Offer', compute='_compute_best_price')
 
+    _check_expected_price = models.Constraint(
+        'CHECK(expected_price > 0)', 'The expected price must be strictly positive.'
+    )
+
     @api.depends('garden_area', 'living_area')
     def _compute_total_area(self):
         for property in self:
@@ -80,6 +85,23 @@ def _onchange_garden(self):
             self.garden_area = 0
             self.garden_orientation = False
 
+    @api.constrains('selling_price', 'expected_price')
+    def _check_selling_price(self):
+        for property in self:
+            if (
+                property.state == 'offer_accepted'
+                and float_compare(property.selling_price, 0, 2) == -1
+            ):
+                raise ValidationError('The selling price must be positive.')
+
+            if (
+                float_compare(property.selling_price, property.expected_price * 0.9, 2)
+                == -1
+            ):
+                raise ValidationError(
+                    'Selling cannot be less than 90% of the expected price.'
+                )
+
     def action_set_property_as_sold(self):
         for property in self:
             if property.state == 'canceled':

estate/models/estate_property_offer.py

@@ -17,12 +17,18 @@ class EstatePropertyOffer(models.Model):
         copy=False,
     )
     partner_id = fields.Many2one('res.partner', string='Partner', required=True)
-    property_id = fields.Many2one('estate.property', string='Property', required=True)
+    property_id = fields.Many2one(
+        'estate.property', string='Property', required=True, ondelete='cascade'
+    )
     validity = fields.Integer('Validity (days)', default=7)
     date_deadline = fields.Date(
         'Deadline', compute='_compute_date_deadline', inverse='_inverse_date_deadline'
     )
 
+    _check_price = models.Constraint(
+        'CHECK(price > 0)', 'The price must be strictly positive.'
+    )
+
     @api.depends('validity')
     def _compute_date_deadline(self):
         for offer in self:

estate/models/estate_property_tag.py

@@ -6,3 +6,7 @@ class EstatePropertyTag(models.Model):
     _description = "Property Tag"
 
     name = fields.Char('Tag', required=True)
+
+    _name_uniq = models.Constraint(
+        'unique(name)', 'A tag with the same name already exists.'
+    )

estate/models/estate_property_type.py

@@ -6,3 +6,7 @@ class EstatePropertyType(models.Model):
     _description = "Property Type"
 
     name = fields.Char('Type', required=True)
+
+    _name_uniq = models.Constraint(
+        'unique(name)', 'A type with the same name already exists.'
+    )