[IMP] estate: Added stat button, related fields & business logic updates

-Introduced a stat button on Property Type to display related offer count.
-Restricted property deletion to New or Cancelled states, set status
 to Offer Received on offer creation, and prevented creation of offers lower
 than existing ones.

Author: haahi-odoo

estate/__manifest__.py

@@ -7,12 +7,11 @@
     'license': 'LGPL-3',
     'data': [
         'security/ir.model.access.csv',
+        'views/estate_property_offer_views.xml',
         'views/estate_property_views.xml',
         'views/estate_property_type_views.xml',
         'views/estate_property_tag_views.xml',
-        'views/estate_property_offer_views.xml',
         'views/estate_menus.xml'
     ],
 
 }
-

estate/models/estate_property.py

@@ -1,4 +1,5 @@
 from dateutil.relativedelta import relativedelta
+
 from odoo import models, fields, api
 from odoo.exceptions import UserError, ValidationError
 from odoo.tools.float_utils import float_compare, float_is_zero
@@ -7,31 +8,37 @@
 class EstateProperty(models.Model):
     _name = "estate.property"
     _description = "Real Estate Property"
+    _order = "id desc"
 
     name = fields.Char(required=True)
     description = fields.Text()
     postcode = fields.Char()
+
     date_availability = fields.Date(
         "Availability Date",
-        default=lambda self: fields.Date.today() + relativedelta(months=3)
+        default=lambda self: fields.Date.today() + relativedelta(months=3),
     )
+
     expected_price = fields.Float("Expected Price", required=True)
     selling_price = fields.Float("Selling Price", readonly=True)
-    bedrooms = fields.Integer(default=3)
-    living_area = fields.Integer("Living Area (sqft)")
+
+    bedrooms = fields.Integer(default=2)
+    living_area = fields.Integer("Living Area(sqft)")
     facades = fields.Integer()
     garage = fields.Boolean()
+
     garden = fields.Boolean()
-    garden_area = fields.Integer("Garden Area (sqft)")
+    garden_area = fields.Integer("Garden Area(sqft)")
     garden_orientation = fields.Selection(
-        selection=[
+        [
             ("north", "North"),
+            ("south", "South"),
             ("east", "East"),
             ("west", "West"),
-            ("South", "South"),
         ],
         string="Garden Orientation",
     )
+
     state = fields.Selection(
         [
             ("new", "New"),
@@ -40,20 +47,35 @@ class EstateProperty(models.Model):
             ("sold", "Sold"),
             ("cancelled", "Cancelled"),
         ],
-        string="Status",
+        "Status",
         required=True,
         copy=False,
         default="new",
     )
+
     active = fields.Boolean(default=True)
+
     property_type_id = fields.Many2one("estate.property.type", "Property Type")
     buyer_id = fields.Many2one("res.partner", "Buyer", copy=False)
     salesperson_id = fields.Many2one("res.users", string="Salesperson")
+
     tag_ids = fields.Many2many("estate.property.tag", string="Tags")
-    offer_ids = fields.One2many("estate.property.offer", "property_id", string="Offers")
-    total_area = fields.Integer("Total Area (sqft)", compute="_compute_total_area")
+
+    offer_ids = fields.One2many(
+        "estate.property.offer",
+        "property_id",
+        string="Offers"
+    )
+
+    total_area = fields.Integer("Total Area(sqm)", compute="_compute_total_area")
     best_price = fields.Float("Best Offer", compute="_compute_best_price")
 
+    _check_expected_price = models.Constraint(
+        'CHECK(expected_price > 0)',
+        'The expected price of a property must be strictly positive.',
+    )
+
+
     @api.depends("living_area", "garden_area")
     def _compute_total_area(self):
         for record in self:
@@ -62,26 +84,16 @@ def _compute_total_area(self):
     @api.depends("offer_ids.price")
     def _compute_best_price(self):
         for record in self:
-            record.best_price = max(record.offer_ids.mapped("price") or [0])
+            record.best_price = max(record.offer_ids.mapped("price"), default=0)
 
     @api.onchange("garden")
     def _onchange_garden(self):
-        for record in self:
-            if record.garden:
-                if record.garden_area == 10:
-                    record.garden_orientation = "north"
-                elif record.garden_area == 20:
-                    record.garden_orientation = "east"
-                elif record.garden_area == 30:
-                    record.garden_orientation = "west"
-                elif record.garden_area == 40:
-                    record.garden_orientation = "south"
-                else:
-                    record.garden_area = 0
-                    record.garden_orientation = False
-            else:
-                record.garden_area = 0
-                record.garden_orientation = False
+        if self.garden:
+            self.garden_area = 10
+            self.garden_orientation = "north"
+        else:
+            self.garden_area = 0
+            self.garden_orientation = False
 
     def action_cancel(self):
         for record in self:
@@ -95,29 +107,18 @@ def action_sold(self):
                 raise UserError("A cancelled property cannot be set as sold")
             record.state = "sold"
 
-    _check_expected_price = models.Constraint(
-        'CHECK(expected_price > 0)',
-        'The expected price must be strictly positive.'
-    )
-
-    _check_selling_price = models.Constraint(
-        'CHECK(selling_price > 0)',
-        'The selling price must be positive.'
-    )
-
     @api.constrains("selling_price", "expected_price")
-    def _check_selling_price_ratio(self):
+    def _check_selling_price(self):
         for record in self:
             if not float_is_zero(record.selling_price, precision_digits=2):
-                if (
-                    float_compare(
-                        record.selling_price,
-                        record.expected_price * 0.9,
-                        precision_digits=2,
-                    )
-                    < 0
-                ):
+                min_price = record.expected_price * 0.9
+                if float_compare(record.selling_price, min_price, precision_digits=2) < 0:
                     raise ValidationError(
-                        "The selling price cannot be lower then 90% of the expected price."
+                        "The selling price cannot be lower than 90% of the expected price."
                     )
 
+    @api.ondelete(at_uninstall=False)
+    def _unlink_if_new_or_cancelled(self):
+        for record in self:
+            if record.state not in ("new", "cancelled"):
+                raise UserError("Only 'New' or 'Cancelled' property can be deleted.")

estate/models/estate_property_offer.py

@@ -1,5 +1,4 @@
 from dateutil.relativedelta import relativedelta
-
 from odoo import fields, models, api
 from odoo.exceptions import UserError
 
@@ -11,41 +10,90 @@ class EstatePropertyOffer(models.Model):
 
     price = fields.Float()
     status = fields.Selection(
-        [("accept", "Accept"), ("refuse", "Refuse")],
+        [("accepted", "Accepted"), ("refused", "Refused")],
         copy=False,
     )
-    partner_id = fields.Many2one("res.partner", string="Partner", required=True)
-    property_id = fields.Many2one("estate.property", string="Property", required=True)
-    validity = fields.Integer(string="Validity(days)", default=15)
-    date_deadline = fields.Date(string="Deadline Date", compute="_compute_date_deadline", inverse="_inverse_date_deadline")
+    partner_id = fields.Many2one("res.partner", required=True)
+    property_id = fields.Many2one("estate.property", required=True)
+    validity = fields.Integer(default=7)
+    date_deadline = fields.Date(
+        string="Deadline Date",
+        compute="_compute_date_deadline",
+        inverse="_inverse_date_deadline"
+    )
+
+    property_type_id = fields.Many2one(
+        related="property_id.property_type_id",
+        store=True
+    )
 
     @api.depends('validity')
     def _compute_date_deadline(self):
         for record in self:
             creation_date = record.create_date or fields.Date.today()
-            record.date_deadline =  relativedelta(days=record.validity) + creation_date
+            record.date_deadline = creation_date + relativedelta(days=record.validity)
 
     def _inverse_date_deadline(self):
         for record in self:
             creation_date = record.create_date or fields.Date.today()
-            record.validity = (record.date_deadline - fields.Date.to_date(creation_date)).days
+            record.validity = (record.date_deadline - creation_date).days
 
     def action_accept(self):
         for record in self:
             if record.property_id.buyer_id:
-                raise UserError("Property already accepted")
-            else:
-                record.status = 'accepted'
-                record.property_id.selling_price = record.price
-                record.property_id.state = 'offer_accepted'
-                record.property_id.buyer_id = record.partner_id
+                raise UserError("Property already has an accepted offer.")
+
+            record.status = 'accepted'
+            record.property_id.selling_price = record.price
+            record.property_id.state = 'offer_accepted'
+            record.property_id.buyer_id = record.partner_id
 
     def action_refuse(self):
-        for record in self:
-            record.status = 'refused'
+        self.status = 'refused'
         return True
 
+    @api.model
+    def create(self, vals):
+        """
+        Handles:
+        > avoid search inside loop
+        > validate in bulk
+        > update property state
+        """
+
+        vals_list = vals if isinstance(vals, list) else [vals]
+
+        property_offer_map = {}
+        for v in vals_list:
+            pid = v.get("property_id")
+            if pid:
+                property_offer_map.setdefault(pid, []).append(v)
+
+        for pid, offers in property_offer_map.items():
+            prices = [o.get("price") for o in offers if o.get("price") is not None]
+
+            if prices:
+                max_new_price = max(prices)
+
+                existing_offers = self.search([
+                    ("property_id", "=", pid),
+                    ("price", ">=", max_new_price),
+                ], limit=1)
+
+                if existing_offers:
+                    raise UserError(
+                        "You cannot create an offer with a lower amount than an existing offer for this property."
+                    )
+
+        records = super().create(vals)
+
+        if isinstance(records, models.Model):     
+            for offer in records:
+                offer.property_id.state = "offer_received"
+
+        return records
+
     _check_offer_price = models.Constraint(
         'CHECK(price > 0)',
-        'The price must be strictly positive.'
-    )
+        'The price of an offer must be strictly positive.'
+    )

estate/models/estate_property_type.py

@@ -1,4 +1,4 @@
-from odoo import fields, models
+from odoo import fields, models, api
 
 
 class EstatePropertyType(models.Model):
@@ -8,9 +8,16 @@ class EstatePropertyType(models.Model):
 
     name = fields.Char(required=True)
     property_ids = fields.One2many("estate.property", "property_type_id", string="Properties")
-    sequence = fields.Integer('Sequence', default=1)
+    sequence = fields.Integer("Sequence", default=1)
+    offer_ids = fields.One2many("estate.property.offer", "property_type_id", string="Offers")
+    offer_count = fields.Integer(string="Offer Count", compute="_compute_offer_count")
+
+    @api.depends("offer_ids")
+    def _compute_offer_count(self):
+        for record in self:
+            record.offer_count = len(record.offer_ids)
 
     _check_type_name_unique = models.Constraint(
-        'UNIQUE(name)', 
+        'UNIQUE(name)',
         'The name of the property type must be unique.'
-    )
+    )

estate/views/estate_property_offer_views.xml

@@ -1,38 +1,54 @@
 <odoo>
-    <record id="estate_property_offer_tree_view" model="ir.ui.view">
+    <!-- Action -->
+    <record id="estate_property_offer_action" model="ir.actions.act_window">
+        <field name="name">Property Offers</field>
+        <field name="res_model">estate.property.offer</field>
+        <field name="view_mode">list,form</field>
+        <field name="domain">[('property_type_id', '=', active_id)]</field>
+    </record>
+
+    <!-- List View -->
+    <record id="estate_property_offer_list_view" model="ir.ui.view">
         <field name="name">estate.property.offer.list</field>
         <field name="model">estate.property.offer</field>
         <field name="arch" type="xml">
             <list decoration-danger="status == 'refused'"
-                decoration-success="status == 'accepted'" editable="bottom">
-                <field name="price" />
-                <field name="partner_id" />
-                <field name="status" invisible="1" />
-                <field name="validity" />
-                <field name="date_deadline" />
-                <button name="action_accept" type="object" string="Accept" icon="fa-check"
-                    invisible="status in ['accepted', 'refused']" />
-                <button name="action_refuse" type="object" string="Refuse" icon="fa-times"
-                    invisible="status in ['accepted', 'refused']" />
+                  decoration-success="status == 'accepted'"
+                  editable="bottom">
+
+                <field name="price"/>
+                <field name="partner_id"/>
+                <field name="status"/>
+                <field name="validity"/>
+                <field name="date_deadline"/>
+                <field name="property_type_id"/>
             </list>
         </field>
     </record>
 
+    <!-- Form View -->
     <record id="estate_property_offer_form_view" model="ir.ui.view">
         <field name="name">estate.property.offer.form</field>
         <field name="model">estate.property.offer</field>
         <field name="arch" type="xml">
             <form>
                 <sheet>
                     <group>
-                        <field name="price" />
-                        <field name="partner_id" />
-                        <field name="status" />
-                        <field name="validity" />
-                        <field name="date_deadline" />
+                        <field name="price"/>
+                        <field name="partner_id"/>
+                        <field name="status"/>
+                        <field name="validity"/>
+                        <field name="date_deadline"/>
+                        <field name="property_type_id"/>
                     </group>
                 </sheet>
+
+                <footer>
+                    <button name="action_accept" type="object" string="Accept" class="btn-primary" />
+                    <button name="action_refuse" type="object" string="Refuse" class="btn-secondary" />
+                </footer>
             </form>
         </field>
     </record>
+
 </odoo>